[jira] [Commented] (GUACAMOLE-139) guacd cannot transfer pictures as JPEG

["Michael Jumper (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GUACAMOLE-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15744562#comment-15744562 ] 

Michael Jumper commented on GUACAMOLE-139:
------------------------------------------

This is not a bug - guacd will use JPEG only if WebP is not available because WebP greatly outperforms JPEG in terms of quality vs. compression ratio. The decision is made based on the supported image mimetypes provided by each connected user during the handshake:

https://github.com/apache/incubator-guacamole-server/blob/701e44a0cb8035dbc7f84e0c529d3eb06880e96c/src/common/guac_surface.c#L461-L463

https://github.com/apache/incubator-guacamole-server/blob/701e44a0cb8035dbc7f84e0c529d3eb06880e96c/src/libguac/client.c#L845-L889

https://github.com/apache/incubator-guacamole-server/blob/701e44a0cb8035dbc7f84e0c529d3eb06880e96c/src/libguac/user.c#L310-L334

> guacd cannot transfer pictures as JPEG
> --------------------------------------
>
>                 Key: GUACAMOLE-139
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-139
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole-server
>    Affects Versions: 0.9.9
>         Environment: Ubuntu 16.04 LTS
>            Reporter: wangxh
>
> I find a problem in guacamole-common/guac_surfaca.c. When guacd judge which is better choice(jpeg webp png), JPEG will nerver available. JPEG's judgment should be in front of webp's judgment. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)