You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "wayslog (via GitHub)" <gi...@apache.org> on 2026/02/22 17:13:16 UTC
[PR] feat(redis): add native Redis Cluster channel support (brpc)
wayslog opened a new pull request, #3222:
URL: https://github.com/apache/brpc/pull/3222
## Summary
- add brpc RedisClusterChannel for native Redis Cluster slot-based routing
- support MOVED/ASK redirection retry, topology refresh from CLUSTER SLOTS with CLUSTER NODES fallback
- support sync/async calls, pipeline, and common multi-key commands (MGET/MSET/DEL/EXISTS/UNLINK/EVAL/EVALSHA)
- add a new Redis Cluster example client under example/redis_c++/redis_cluster_client.cpp
- update Redis client docs in both English and Chinese
## Tests
- bazel test //test:brpc_redis_cluster_test --test_output=errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] feat(redis): add native Redis Cluster channel support (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #3222:
URL: https://github.com/apache/brpc/pull/3222#issuecomment-3944047822
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] feat(redis): add native Redis Cluster channel support (brpc)
Posted by "Huixxi (via GitHub)" <gi...@apache.org>.
Huixxi merged PR #3222:
URL: https://github.com/apache/brpc/pull/3222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] feat(redis): add native Redis Cluster channel support (brpc)
Posted by "wayslog (via GitHub)" <gi...@apache.org>.
wayslog commented on PR #3222:
URL: https://github.com/apache/brpc/pull/3222#issuecomment-3942784611
I investigated the flaky test failure in and pushed a fix:\n\n- commit: \n- root cause: ASK redirection was being written into the slot cache, which is incorrect (ASK is temporary during migration).\n- effect: subsequent requests could be routed directly to the ASK target without sending , then return intermittently under concurrency.\n- fix: only persist slot mapping for MOVED, not ASK.\n- test: added and re-ran //test:brpc_redis_cluster_test (cached) PASSED in 4.3s
Executed 0 out of 1 test: 1 test passes.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are..\n\nThis should eliminate the CI flake for that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] feat(redis): add native Redis Cluster channel support (brpc)
Posted by "wayslog (via GitHub)" <gi...@apache.org>.
wayslog commented on PR #3222:
URL: https://github.com/apache/brpc/pull/3222#issuecomment-3981818432
All tests was passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] feat(redis): add native Redis Cluster channel support (brpc)
Posted by "wayslog (via GitHub)" <gi...@apache.org>.
wayslog commented on PR #3222:
URL: https://github.com/apache/brpc/pull/3222#issuecomment-3942698667
Looks like this CI failure is not code-related but network-related:\n\n`rules_cc-0.1.1.tar.gz` download from GitHub returned **502 Bad Gateway / Proxy Error** during Bazel external fetch.\n\nIn other words: our code is fine, the internet had a mood swing 😅\n\nI have triggered a rerun. If it flakes again with the same fetch error, we can treat this as infra noise and rerun once more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] feat(redis): add native Redis Cluster channel support (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #3222:
URL: https://github.com/apache/brpc/pull/3222#issuecomment-3943151677
Can compare this with PR #2228. I prefer current PR because it only add a RedisClusterChannel class, without modifying bRPC core classes, that's amazing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] feat(redis): add native Redis Cluster channel support (brpc)
Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright commented on PR #3222:
URL: https://github.com/apache/brpc/pull/3222#issuecomment-3979327382
Please merge or rebase master branch which fixed CI failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org