You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "volatilemolotov (via GitHub)" <gi...@apache.org> on 2023/07/10 22:23:36 UTC
[GitHub] [beam] volatilemolotov opened a new pull request, #27441: adding runner image 738c02cac
volatilemolotov opened a new pull request, #27441:
URL: https://github.com/apache/beam/pull/27441
Change runner_image to 738c02cac sha.
Draft until proven stable
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] volatilemolotov commented on a diff in pull request #27441: adding runner image 738c02cac
Posted by "volatilemolotov (via GitHub)" <gi...@apache.org>.
volatilemolotov commented on code in PR #27441:
URL: https://github.com/apache/beam/pull/27441#discussion_r1261223203
##########
.github/gh-actions-self-hosted-runners/arc/environments/beam.env:
##########
@@ -31,11 +31,12 @@ deploy_webhook = "true"
runner_group = "beam"
main_runner = {
name = "main-runner"
+ runner_image = "us-central1-docker.pkg.dev/apache-beam-testing/beam-github-actions/beam-arc-runner:738c02cac4d6a88faa3dd02606d50f1d2efed5e7"
machine_type = "e2-standard-16"
min_node_count = "1"
- max_node_count = "7"
+ max_node_count = "10"
Review Comment:
Sure. Ill bump it to 16 to be safe and as time goes by and more jobs are added we can do more precise numbers.
They will scale down when not used so its fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #27441: adding runner image 738c02cac
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27441:
URL: https://github.com/apache/beam/pull/27441#discussion_r1261207453
##########
.github/gh-actions-self-hosted-runners/arc/environments/beam.env:
##########
@@ -31,11 +31,12 @@ deploy_webhook = "true"
runner_group = "beam"
main_runner = {
name = "main-runner"
+ runner_image = "us-central1-docker.pkg.dev/apache-beam-testing/beam-github-actions/beam-arc-runner:738c02cac4d6a88faa3dd02606d50f1d2efed5e7"
machine_type = "e2-standard-16"
min_node_count = "1"
- max_node_count = "7"
+ max_node_count = "10"
Review Comment:
Could we bump this up even further? For context, our Jenkins setup currently has 16 dedicated machines, each running 4 workers. So maybe jumping up to 16 makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #27441: adding runner image 738c02cac
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27441:
URL: https://github.com/apache/beam/pull/27441#discussion_r1261224606
##########
.github/gh-actions-self-hosted-runners/arc/environments/beam.env:
##########
@@ -31,11 +31,12 @@ deploy_webhook = "true"
runner_group = "beam"
main_runner = {
name = "main-runner"
+ runner_image = "us-central1-docker.pkg.dev/apache-beam-testing/beam-github-actions/beam-arc-runner:738c02cac4d6a88faa3dd02606d50f1d2efed5e7"
machine_type = "e2-standard-16"
min_node_count = "1"
- max_node_count = "7"
+ max_node_count = "10"
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #27441: adding runner image 738c02cac
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #27441:
URL: https://github.com/apache/beam/pull/27441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org