[GitHub] [beam] KonradJanica commented on a change in pull request #16283: [BEAM-13448] [Playground] track run code time to the analytics

[GitBox <gi...@apache.org>]

KonradJanica commented on a change in pull request #16283:
URL: https://github.com/apache/beam/pull/16283#discussion_r772633559



##########
File path: playground/frontend/lib/modules/analytics/analytics_service.dart
##########
@@ -99,12 +99,24 @@ class AnalyticsService {
     );
   }
 
-  void safeSendEvent(String category, String action, {String? label}) {
+  void trackRunTimeEvent(ExampleModel? example, int runTimeMs) {

Review comment:
       A null `ExampleModel` won't be very useful in analytics and it might produce a lot of noise. Perhaps make this a required parameter and check for null at the caller. The caller can then decide to either:
   a) Construct an `ExampleModel` with a label explaining that the selectedExample is unknown.
   or b) Not send an event for an unknown example.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org