[jira] [Comment Edited] (IGNITE-10896) Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify

["Ivan Rakov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16808883#comment-16808883 ] 

Ivan Rakov edited comment on IGNITE-10896 at 4/3/19 4:12 PM:
-------------------------------------------------------------

[~Denis Chudov],
1. 
{code:java}
            try {
                Pattern.compile(cacheName);
            } catch (PatternSyntaxException e) {
                throw new RuntimeException(format("Invalid cache name regexp '%s': %s", cacheName, e.getMessage()));
            }
{code}
catch should be on separate line
2. As I see from the code, cache filtering actually works on group names as well. Let's mention it in --cache help output.
3. Let's cover that non-trivial cache filter (e.g. PERSISTENT) works simultaneously with regexp filtering.
4. I agree with Sergey on his points 5 and 6. A descriptive message should be displayed in case there are no caches that match the filter.
5. "idle_verify task args were following" - doesn't it sound a bit rough? What about "idle_verify task was executed with the following args"?


was (Author: ivan.glukos):
[~Denis Chudov],
1. 
{code:java}
            try {
                Pattern.compile(cacheName);
            } catch (PatternSyntaxException e) {
                throw new RuntimeException(format("Invalid cache name regexp '%s': %s", cacheName, e.getMessage()));
            }
{code}
catch should be on separate line
2. As I see from the code, cache filtering actually works on group names as well. Let's meтtion it in --cache help output.
3. Let's cover that non-trivial cache filter (e.g. PERSISTENT) works simultaneously with regexp filtering.
4. I agree with Sergey on his points 5 and 6. A descriptive message should be displayed in case there are no caches that match the filter.
5. "idle_verify task args were following" - doesn't it sound a bit rough? What about "idle_verify task was executed with the following args"?

> Add ability to use simultaneous cache filtering options with control.sh --cache idle_verify
> -------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-10896
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10896
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: ARomantsov
>            Assignee: Denis Chudov
>            Priority: Major
>             Fix For: 2.8
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Now I can use only one of next options
> 1) --exclude-caches cache1,...,cacheN
> 2) --cache-filter ALL|SYSTEM|PERSISTENT|NOT_PERSISTENT
> 3) cache1,...,cacheN
> Trying to use two or more of this options currently results in error:
> {noformat}
> Error: Should use only one of option: --excludeCaches, --cache-filter or pass caches explicitly
> {noformat}
> Instead, utility should do the following:
>  1) when two or more options specified, result cache set to make dump of should be logical AND of results of each option applied individually.
>      ex. 
> {noformat}
>      cache.* --cache-filter PERSISTENT
> {noformat}
> should select all persistent caches starting from 'cache'
> {noformat}
>    --cache-filter ALL
>    --exclude-caches wrong-.*-caches
> {noformat}
> should select all caches but matching 'wrong-.*-caches' regexp
>  etc.
>  2) filtering options passed to control utility should be logged into result dump file, so that user could understand that dump was taken from subset of cluster caches
>  3) when result of filter or filters AND'ing is empty set of cache names, proper error message should be given and no dump file generated.
> e.g. 
> {noformat}Error: can't find any cache matching cache names '--skup-zerus' and cache filter 'PERSISTENT', dump won't be generated.{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)