You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Massimo Lusetti <ml...@gmail.com> on 2010/01/14 17:51:13 UTC

Re: svn commit: r898476 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: ValidationTrackerImpl.java ValidationTrackerWrapper.java corelib/components/Form.java

On Tue, Jan 12, 2010 at 8:29 PM,  <hl...@apache.org> wrote:

> Author: hlship
> Date: Tue Jan 12 19:29:11 2010
> New Revision: 898476
>
> URL: http://svn.apache.org/viewvc?rev=898476&view=rev
> Log:
> TAP5-979: Form component should be more careful with the validation tracker to ensure that a session is not created unless needed
>

I think this is causing some hassle to validation mechanism, i got a form with:

@Component
private Form formId;

void onValidateFormFromFormId()
{
    // while here do me check and...
    formId.recordErorr("BIG ERROR");
}

void onFailureFromFormId()
{
     // clean up
}


void onSuccessFromFormId()
{
    // record into db and go on...
}


Well my onFailure is never called while onSuccess is always... does
anyone else has noted this behavior?

Cheers
-- 
Massimo
http://meridio.blogspot.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

Re: svn commit: r898476 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: ValidationTrackerImpl.java ValidationTrackerWrapper.java corelib/components/Form.java

Posted by Massimo Lusetti <ml...@gmail.com>.
On Thu, Jan 14, 2010 at 6:23 PM, Howard Lewis Ship <hl...@gmail.com> wrote:

> Please add an issue, I'll check into it. Behavior was not intended to
> have changed, and not sure exactly how such a change slipped in.  Good
> catch!

Done: https://issues.apache.org/jira/browse/TAP5-987

Cheers
-- 
Massimo
http://meridio.blogspot.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

Re: svn commit: r898476 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: ValidationTrackerImpl.java ValidationTrackerWrapper.java corelib/components/Form.java

Posted by Howard Lewis Ship <hl...@gmail.com>.
Please add an issue, I'll check into it. Behavior was not intended to
have changed, and not sure exactly how such a change slipped in.  Good
catch!

On Thu, Jan 14, 2010 at 8:54 AM, Massimo Lusetti <ml...@gmail.com> wrote:
> On Thu, Jan 14, 2010 at 5:51 PM, Massimo Lusetti <ml...@gmail.com> wrote:
>
>> void onValidateFormFromFormId()
>> {
>>    // while here do me check and...
>>    formId.recordErorr("BIG ERROR");
>> }
>
>
> For the records changing onValidate from void to object and return
> this in case of error does reproduce the previous behavior...
>
> Cheers
> --
> Massimo
> http://meridio.blogspot.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>



-- 
Howard M. Lewis Ship

Creator of Apache Tapestry

The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!

(971) 678-5210
http://howardlewisship.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

Re: svn commit: r898476 - in /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5: ValidationTrackerImpl.java ValidationTrackerWrapper.java corelib/components/Form.java

Posted by Massimo Lusetti <ml...@gmail.com>.
On Thu, Jan 14, 2010 at 5:51 PM, Massimo Lusetti <ml...@gmail.com> wrote:

> void onValidateFormFromFormId()
> {
>    // while here do me check and...
>    formId.recordErorr("BIG ERROR");
> }


For the records changing onValidate from void to object and return
this in case of error does reproduce the previous behavior...

Cheers
-- 
Massimo
http://meridio.blogspot.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org