You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/03/14 17:03:20 UTC
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #40410: [SPARK-42783][SQL] Infer window group limit should run as late as possible
dongjoon-hyun commented on code in PR #40410:
URL: https://github.com/apache/spark/pull/40410#discussion_r1135912257
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkOptimizer.scala:
##########
@@ -84,6 +84,11 @@ class SparkOptimizer(
PushPredicateThroughNonJoin,
PushProjectionThroughLimit,
RemoveNoopOperators) :+
+ Batch("Infer window group limit", Once,
+ InferWindowGroupLimit,
+ LimitPushDown,
+ LimitPushDownThroughWindow,
+ EliminateLimits) :+
Review Comment:
May I ask why this is different from #40142 ? At that time, we only remove one rule. So, I guess we will recover only `InferWindowGroupLimit` here.
```
- Batch("Insert window group limit", Once, InsertWindowGroupLimit) :+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org