Re: [PR] KAFKA-19818: Move ClientQuotaMetadataManager logic to the metadata module [kafka]

["chia7712 (via GitHub)" <gi...@apache.org>]

chia7712 commented on code in PR #23555:
URL: https://github.com/apache/kafka/pull/23555#discussion_r4414497019


##########
metadata/src/main/java/org/apache/kafka/metadata/publisher/DynamicClientQuotaPublisher.java:
##########
@@ -16,34 +16,55 @@
  */
 package org.apache.kafka.metadata.publisher;
 
+import org.apache.kafka.common.quota.ClientQuotaEntity;
+import org.apache.kafka.image.ClientQuotaDelta;
 import org.apache.kafka.image.ClientQuotasDelta;
 import org.apache.kafka.image.MetadataDelta;
 import org.apache.kafka.image.MetadataImage;
 import org.apache.kafka.image.loader.LoaderManifest;
 import org.apache.kafka.image.publisher.MetadataPublisher;
+import org.apache.kafka.server.config.QuotaConfig;
 import org.apache.kafka.server.fault.FaultHandler;
 
-import java.util.function.Consumer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.net.InetAddress;
+import java.net.UnknownHostException;
+import java.util.Map;
+import java.util.Optional;
+import java.util.OptionalDouble;
+import java.util.OptionalInt;
+import java.util.function.BiConsumer;
+
+import static org.apache.kafka.common.quota.ClientQuotaEntity.CLIENT_ID;
+import static org.apache.kafka.common.quota.ClientQuotaEntity.IP;
+import static org.apache.kafka.common.quota.ClientQuotaEntity.USER;
 
 /**
- * Publishes dynamic client quota changes to the client quota metadata manager.
+ * Publishes dynamic client quota changes to quota managers.
  */
 public class DynamicClientQuotaPublisher implements MetadataPublisher {
+    private static final Logger log = LoggerFactory.getLogger(DynamicClientQuotaPublisher.class);
+
     private final int nodeId;
     private final FaultHandler faultHandler;
     private final String nodeType;
-    private final Consumer<ClientQuotasDelta> clientQuotaUpdater;
+    private final Map<String, BiConsumer<ClientQuotaEntity, OptionalDouble>> userClientQuotaUpdaters;
+    private final BiConsumer<Optional<InetAddress>, OptionalInt> ipQuotaUpdater;
 
     public DynamicClientQuotaPublisher(
         int nodeId,
         FaultHandler faultHandler,
         String nodeType,
-        Consumer<ClientQuotasDelta> clientQuotaUpdater
+        Map<String, BiConsumer<ClientQuotaEntity, OptionalDouble>> userClientQuotaUpdaters,

Review Comment:
   Sorry, I’m not convinced this is good-looking. IIRC, adding a custom interface was an option. Would you mind trying that approach?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org