You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2011/01/03 21:01:54 UTC
[jira] Created: (TS-613) Is transparency_enabled configuration
obsolete?
Is transparency_enabled configuration obsolete?
-----------------------------------------------
Key: TS-613
URL: https://issues.apache.org/jira/browse/TS-613
Project: Traffic Server
Issue Type: Bug
Components: HTTP
Reporter: Leif Hedstrom
Fix For: 2.1.5
This configuration option is used in one place, with some comments regarding it's use together with various browsers and header combos. I'm wondering if we should eliminate this configuration entirely (if so, file a docs bug as well), and/or use the new transparency flags that were added for transparent proxy configs.
void
HttpTransact::initialize_state_variables_from_request(State* s, HTTPHdr* obsolete_incoming_request)
{
...
MIMEField *pc = incoming_request->field_find(MIME_FIELD_PROXY_CONNECTION, MIME_LEN_PROXY_CONNECTION);
if (!s->txn_conf.keep_alive_enabled || (s->http_config_param->transparency_enabled && pc != NULL)) {
s->client_info.keep_alive = HTTP_NO_KEEPALIVE;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-613) Is transparency_enabled configuration
obsolete?
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978150#action_12978150 ]
Leif Hedstrom commented on TS-613:
----------------------------------
That NTLM code looks like it should be removed.
> Is transparency_enabled configuration obsolete?
> -----------------------------------------------
>
> Key: TS-613
> URL: https://issues.apache.org/jira/browse/TS-613
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: Leif Hedstrom
> Assignee: Alan M. Carroll
> Fix For: 2.1.5
>
>
> This configuration option is used in one place, with some comments regarding it's use together with various browsers and header combos. I'm wondering if we should eliminate this configuration entirely (if so, file a docs bug as well), and/or use the new transparency flags that were added for transparent proxy configs.
> void
> HttpTransact::initialize_state_variables_from_request(State* s, HTTPHdr* obsolete_incoming_request)
> {
> ...
> MIMEField *pc = incoming_request->field_find(MIME_FIELD_PROXY_CONNECTION, MIME_LEN_PROXY_CONNECTION);
> if (!s->txn_conf.keep_alive_enabled || (s->http_config_param->transparency_enabled && pc != NULL)) {
> s->client_info.keep_alive = HTTP_NO_KEEPALIVE;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-613) Is transparency_enabled configuration
obsolete?
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll resolved TS-613.
--------------------------------
Resolution: Fixed
Removed the NTLM code.
Removed the configuration record member "transparency_enabled" and modified the use sites to use either client_transparency_enabled or server_transparency_enabled as appropriate.
> Is transparency_enabled configuration obsolete?
> -----------------------------------------------
>
> Key: TS-613
> URL: https://issues.apache.org/jira/browse/TS-613
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: Leif Hedstrom
> Assignee: Alan M. Carroll
> Fix For: 2.1.5
>
>
> This configuration option is used in one place, with some comments regarding it's use together with various browsers and header combos. I'm wondering if we should eliminate this configuration entirely (if so, file a docs bug as well), and/or use the new transparency flags that were added for transparent proxy configs.
> void
> HttpTransact::initialize_state_variables_from_request(State* s, HTTPHdr* obsolete_incoming_request)
> {
> ...
> MIMEField *pc = incoming_request->field_find(MIME_FIELD_PROXY_CONNECTION, MIME_LEN_PROXY_CONNECTION);
> if (!s->txn_conf.keep_alive_enabled || (s->http_config_param->transparency_enabled && pc != NULL)) {
> s->client_info.keep_alive = HTTP_NO_KEEPALIVE;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-613) Is transparency_enabled configuration
obsolete?
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978146#action_12978146 ]
Leif Hedstrom commented on TS-613:
----------------------------------
There are two more places where the old config is used, both in HttpTransact.cc:
if (s->http_config_param->transparency_enabled) { // host header missing, and transparency on
build_error_response(s, HTTP_STATUS_BAD_REQUEST, "Host Header Required", "interception#no_host",
and
// NTLM proxy pass-through
if ((status_code == HTTP_STATUS_UNAUTHORIZED ||
// if build_response is called from
// handle_no_cache_operation_on_forward_server_response,
// the status_code passed is HTTP_STATUS_NONE
(status_code == HTTP_STATUS_NONE &&
s->hdr_info.server_response.valid() &&
s->hdr_info.server_response.status_get() == HTTP_STATUS_UNAUTHORIZED)) &&
!s->http_config_param->reverse_proxy_enabled && !s->http_config_param->transparency_enabled) {
MIMEField *auth_hdr = outgoing_response->field_find(MIME_FIELD_WWW_AUTHENTICATE, MIME_LEN_WWW_AUTHENTICATE);
if (auth_hdr) {
(the second one looks odd, seems NTLM related ??).
> Is transparency_enabled configuration obsolete?
> -----------------------------------------------
>
> Key: TS-613
> URL: https://issues.apache.org/jira/browse/TS-613
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: Leif Hedstrom
> Assignee: Alan M. Carroll
> Fix For: 2.1.5
>
>
> This configuration option is used in one place, with some comments regarding it's use together with various browsers and header combos. I'm wondering if we should eliminate this configuration entirely (if so, file a docs bug as well), and/or use the new transparency flags that were added for transparent proxy configs.
> void
> HttpTransact::initialize_state_variables_from_request(State* s, HTTPHdr* obsolete_incoming_request)
> {
> ...
> MIMEField *pc = incoming_request->field_find(MIME_FIELD_PROXY_CONNECTION, MIME_LEN_PROXY_CONNECTION);
> if (!s->txn_conf.keep_alive_enabled || (s->http_config_param->transparency_enabled && pc != NULL)) {
> s->client_info.keep_alive = HTTP_NO_KEEPALIVE;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TS-613) Is transparency_enabled configuration
obsolete?
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reopened TS-613:
------------------------------
Also, IF we can eliminate transparency_enabled, we should get rid of the configuration option.
> Is transparency_enabled configuration obsolete?
> -----------------------------------------------
>
> Key: TS-613
> URL: https://issues.apache.org/jira/browse/TS-613
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: Leif Hedstrom
> Assignee: Alan M. Carroll
> Fix For: 2.1.5
>
>
> This configuration option is used in one place, with some comments regarding it's use together with various browsers and header combos. I'm wondering if we should eliminate this configuration entirely (if so, file a docs bug as well), and/or use the new transparency flags that were added for transparent proxy configs.
> void
> HttpTransact::initialize_state_variables_from_request(State* s, HTTPHdr* obsolete_incoming_request)
> {
> ...
> MIMEField *pc = incoming_request->field_find(MIME_FIELD_PROXY_CONNECTION, MIME_LEN_PROXY_CONNECTION);
> if (!s->txn_conf.keep_alive_enabled || (s->http_config_param->transparency_enabled && pc != NULL)) {
> s->client_info.keep_alive = HTTP_NO_KEEPALIVE;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-613) Is transparency_enabled configuration
obsolete?
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll resolved TS-613.
--------------------------------
Resolution: Fixed
Assignee: Alan M. Carroll
Changed check to use the origin server side transparency flag.
> Is transparency_enabled configuration obsolete?
> -----------------------------------------------
>
> Key: TS-613
> URL: https://issues.apache.org/jira/browse/TS-613
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: Leif Hedstrom
> Assignee: Alan M. Carroll
> Fix For: 2.1.5
>
>
> This configuration option is used in one place, with some comments regarding it's use together with various browsers and header combos. I'm wondering if we should eliminate this configuration entirely (if so, file a docs bug as well), and/or use the new transparency flags that were added for transparent proxy configs.
> void
> HttpTransact::initialize_state_variables_from_request(State* s, HTTPHdr* obsolete_incoming_request)
> {
> ...
> MIMEField *pc = incoming_request->field_find(MIME_FIELD_PROXY_CONNECTION, MIME_LEN_PROXY_CONNECTION);
> if (!s->txn_conf.keep_alive_enabled || (s->http_config_param->transparency_enabled && pc != NULL)) {
> s->client_info.keep_alive = HTTP_NO_KEEPALIVE;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.