[GitHub] [knox] mudit-97 commented on a change in pull request #423: KNOX-2559: Added functionality to append headers in request in Config…

[GitBox <gi...@apache.org>]

mudit-97 commented on a change in pull request #423:
URL: https://github.com/apache/knox/pull/423#discussion_r625633724



##########
File path: gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/ConfigurableDispatch.java
##########
@@ -41,13 +47,26 @@
 public class ConfigurableDispatch extends DefaultDispatch {
   private Set<String> requestExcludeHeaders = super.getOutboundRequestExcludeHeaders();
   private Set<String> responseExcludeHeaders = super.getOutboundResponseExcludeHeaders();
+  private Map<String, String> requestAppendHeaders = new HashMap<>();
   private Set<String> responseExcludeSetCookieHeaderDirectives = super.getOutboundResponseExcludedSetCookieHeaderDirectives();
   private Boolean removeUrlEncoding = false;
 
   private Set<String> convertCommaDelimitedHeadersToSet(String headers) {
     return headers == null ?  Collections.emptySet(): new HashSet<>(Arrays.asList(headers.split("\\s*,\\s*")));
   }
 
+  private Map<String, String> convertJSONHeadersToMap(String headers) {

Review comment:
       @moresandeep , I tried testing this on my local, that was working fine. I tested one positive and one negative case, let me know if you face any issues




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org