[jira] [Resolved] (FELIX-6466) webconsole.configurationFactory.nameHint only detected via ConfigurationAdmin

["Carsten Ziegeler (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FELIX-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved FELIX-6466.
-------------------------------------
    Resolution: Fixed

Thanks for the PR [~kwin]

> webconsole.configurationFactory.nameHint only detected via ConfigurationAdmin
> -----------------------------------------------------------------------------
>
>                 Key: FELIX-6466
>                 URL: https://issues.apache.org/jira/browse/FELIX-6466
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>            Reporter: Konrad Windszus
>            Assignee: Carsten Ziegeler
>            Priority: Major
>             Fix For: webconsole-4.7.2
>
>
> The configuration object exposed from https://github.com/apache/felix-dev/blob/4c784623cc0dac44dbbe82027caf3eeb44020cb6/webconsole/src/main/java/org/apache/felix/webconsole/internal/configuration/ConfigJsonSupport.java#L237 only contains the explicitly set properties but not the ones the component description of DS (http://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-property.properties.elements) which is evaluated as well at http://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.properties.
> That means that if a DS component leverages metatype based configuration, only its properties are queried for {{webconsole.configurationFactory.nameHint}} while usually it does not make sense to include that attribute in the metatype definition (as you don't want to make it changeable).
> Instead the full service properties as exposed from https://docs.osgi.org/javadoc/r4v43/core/org/osgi/framework/ServiceReference.html#getProperty(java.lang.String) should be queried to look for  {{webconsole.configurationFactory.nameHint}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)