You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/24 19:12:46 UTC

[GitHub] [incubator-nuttx] jerpelea opened a new pull request #3171: arch: arm: tiva: License update licenses to Apache

jerpelea opened a new pull request #3171:
URL: https://github.com/apache/incubator-nuttx/pull/3171


   ## Summary
   Gregory Nutt has submitted the SGA and we can migrate the licenses to Apache.
   
   ## Impact
   NONE
   
   ## Testing
   NONE
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jerpelea commented on pull request #3171: arch: arm: tiva: License update licenses to Apache

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #3171:
URL: https://github.com/apache/incubator-nuttx/pull/3171#issuecomment-806388450


   @xiaoxiang781216 please merge after revew


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3171: arch: arm: tiva: License update licenses to Apache

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3171:
URL: https://github.com/apache/incubator-nuttx/pull/3171#discussion_r601093846



##########
File path: arch/arm/src/tiva/hardware/cc13x0/cc13x0_adi3_refsys.h
##########
@@ -182,6 +185,7 @@
 #  define ADI3_REFSYS_DCDCCTL0_VDDR_TRIM_TYPICAL              (5 << ADI3_REFSYS_DCDCCTL0_VDDR_TRIM_SHIFT)  /* Typical voltage after trim voltage 1.71V */
 #  define ADI3_REFSYS_DCDCCTL0_VDDR_TRIM_MAX                  (21 << ADI3_REFSYS_DCDCCTL0_VDDR_TRIM_SHIFT) /* Max voltage 1.96V */
 #  define ADI3_REFS */YS_DCDCCTL0_VDDR_TRIM_MIN               (22 << ADI3_REFSYS_DCDCCTL0_VDDR_TRIM_SHIFT) /* Min voltage 1.47V */

Review comment:
       The original code look strange.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3171: arch: arm: tiva: License update licenses to Apache

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3171:
URL: https://github.com/apache/incubator-nuttx/pull/3171#discussion_r601093846



##########
File path: arch/arm/src/tiva/hardware/cc13x0/cc13x0_adi3_refsys.h
##########
@@ -182,6 +185,7 @@
 #  define ADI3_REFSYS_DCDCCTL0_VDDR_TRIM_TYPICAL              (5 << ADI3_REFSYS_DCDCCTL0_VDDR_TRIM_SHIFT)  /* Typical voltage after trim voltage 1.71V */
 #  define ADI3_REFSYS_DCDCCTL0_VDDR_TRIM_MAX                  (21 << ADI3_REFSYS_DCDCCTL0_VDDR_TRIM_SHIFT) /* Max voltage 1.96V */
 #  define ADI3_REFS */YS_DCDCCTL0_VDDR_TRIM_MIN               (22 << ADI3_REFSYS_DCDCCTL0_VDDR_TRIM_SHIFT) /* Min voltage 1.47V */

Review comment:
       The original code look strange. Anyway, we can address this in new PR if need.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3171: arch: arm: tiva: License update licenses to Apache

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3171:
URL: https://github.com/apache/incubator-nuttx/pull/3171


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org