You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "necouchman (via GitHub)" <gi...@apache.org> on 2024/08/27 23:21:26 UTC
[PR] GUACAMOLE-1290: Document SFTP public key parameter. [guacamole-manual]
necouchman opened a new pull request, #249:
URL: https://github.com/apache/guacamole-manual/pull/249
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1290: Document SFTP public key parameter. [guacamole-manual]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on code in PR #249:
URL: https://github.com/apache/guacamole-manual/pull/249#discussion_r1733637636
##########
src/configuring-guacamole.md:
##########
@@ -2185,6 +2185,12 @@ transfer features.
authentication. This parameter is not needed if the private key does not
require a passphrase.
+`sftp-public-key`
+: If the SFTP connection is using key-based authentication, this field
+ allows you to specify the Base64-encoded CA certificate against which
Review Comment:
CA certificate? Is that right? That doesn't look like what's happening here https://github.com/apache/guacamole-server/pull/538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1290: Document SFTP public key parameter. [guacamole-manual]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #249:
URL: https://github.com/apache/guacamole-manual/pull/249#discussion_r1733644273
##########
src/configuring-guacamole.md:
##########
@@ -2185,6 +2185,12 @@ transfer features.
authentication. This parameter is not needed if the private key does not
require a passphrase.
+`sftp-public-key`
+: If the SFTP connection is using key-based authentication, this field
+ allows you to specify the Base64-encoded CA certificate against which
Review Comment:
Yeah, that's not quite right. Looking at the documentation for the `libssh2_userauth_publickey_frommemory()` function, it looks like:
* You can pass just a private key, in which case libssh2 will extract (compute) the public key based on the private key contents.
* You can pass the private key and a separate public key, in which case the separate public key takes precedence over extraction from the private key.
If the public key data doesn't match the private key, the authentication will fail, so it's a way to pass those separately such that you're validating the private key that is passed against a specific, known public key value.
So, I need to reword this - and the other instance of it - a little differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1290: Document SFTP public key parameter. [guacamole-manual]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on code in PR #249:
URL: https://github.com/apache/guacamole-manual/pull/249#discussion_r1733656943
##########
src/configuring-guacamole.md:
##########
@@ -2185,6 +2185,12 @@ transfer features.
authentication. This parameter is not needed if the private key does not
require a passphrase.
+`sftp-public-key`
+: If the SFTP connection is using key-based authentication, this field
+ allows you to specify the Base64-encoded CA certificate against which
Review Comment:
Looks reasonable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1290: Document SFTP public key parameter. [guacamole-manual]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #249:
URL: https://github.com/apache/guacamole-manual/pull/249#discussion_r1733647959
##########
src/configuring-guacamole.md:
##########
@@ -2185,6 +2185,12 @@ transfer features.
authentication. This parameter is not needed if the private key does not
require a passphrase.
+`sftp-public-key`
+: If the SFTP connection is using key-based authentication, this field
+ allows you to specify the Base64-encoded CA certificate against which
Review Comment:
Okay, let me know if it makes a bit more sense, now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1290: Document SFTP public key parameter. [guacamole-manual]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner merged PR #249:
URL: https://github.com/apache/guacamole-manual/pull/249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org