You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/24 02:55:15 UTC
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15715: [fix][doc] Message Deduplication: Add more links for how it works under the hood
Anonymitaet commented on code in PR #15715:
URL: https://github.com/apache/pulsar/pull/15715#discussion_r880012715
##########
site2/docs/concepts-messaging.md:
##########
@@ -906,7 +906,7 @@ Message deduplication is disabled in the scenario shown at the top. Here, a prod
In the second scenario at the bottom, the producer publishes message 1, which is received by the broker and persisted, as in the first scenario. When the producer attempts to publish the message again, however, the broker knows that it has already seen message 1 and thus does not persist the message.
> Message deduplication is handled at the namespace level or the topic level. For more instructions, see the [message deduplication cookbook](cookbooks-deduplication).
-
+> You can read the design of Message Deduplication in [PIP-6](https://github.com/aahmed-se/pulsar-wiki/blob/master/PIP-6:-Guaranteed-Message-Deduplication.md), and a get an overview in this [blog post](https://www.splunk.com/en_us/blog/it/effectively-once-semantics-in-apache-pulsar.html)
Review Comment:
To keep neutral and not to be challenged by ASF, we avoid adding blogs of commercial companies to the Pulsar documentation.
##########
site2/docs/concepts-messaging.md:
##########
@@ -906,7 +906,7 @@ Message deduplication is disabled in the scenario shown at the top. Here, a prod
In the second scenario at the bottom, the producer publishes message 1, which is received by the broker and persisted, as in the first scenario. When the producer attempts to publish the message again, however, the broker knows that it has already seen message 1 and thus does not persist the message.
> Message deduplication is handled at the namespace level or the topic level. For more instructions, see the [message deduplication cookbook](cookbooks-deduplication).
-
+> You can read the design of Message Deduplication in [PIP-6](https://github.com/aahmed-se/pulsar-wiki/blob/master/PIP-6:-Guaranteed-Message-Deduplication.md), and a get an overview in this [blog post](https://www.splunk.com/en_us/blog/it/effectively-once-semantics-in-apache-pulsar.html)
Review Comment:
To keep neutral and not to be challenged by ASF, we avoid adding blogs of commercial companies to the Pulsar documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org