[jira] [Commented] (JOHNZON-305) Johnzon should provide Java 9 module information

["Samael Bate (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JOHNZON-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628031#comment-17628031 ] 

Samael Bate commented on JOHNZON-305:
-------------------------------------

I created a branch to add the automatic module name to the manifest using the maven-jar-plugin but although the build completes the value is not in the manifest. I suspect the maven-bundle-plugin is interfering as it'll be adding the osgi config. bndtools can support JPMS (https://bnd.bndtools.org/chapters/330-jpms.html) so it's probably going to need to be done using the bundle plugin rather than the jar plugin.

> Johnzon should provide Java 9 module information
> ------------------------------------------------
>
>                 Key: JOHNZON-305
>                 URL: https://issues.apache.org/jira/browse/JOHNZON-305
>             Project: Johnzon
>          Issue Type: Improvement
>          Components: Core, JAX-RS, JSON-B, Mapper, OSGi, Websocket
>    Affects Versions: 1.2.3
>            Reporter: Adrian Price
>            Priority: Major
>
> Johnzon does not declare any Java 9 modules and consequently it is not usable with a modular Java 9+ program*. There are two possible approaches:
>  # Add module-info.java files to each of johnzon-core, johnzon-jaxrs, johnzon-jsonb, johnzon-json-extras, johnzon-jsonschema, johnzon-mapper, johnzon-osgi, johnzon-websocket and possibly johnzon-maven-plugin. (Preferred, the 'correct way'.)
>  # Configure maven-jar-plugin with an archive/manifestEntries/Automatic-Module-Name element. Probably best achieved with a plugin element in the parent /johnzon/pom.xml referencing a property to be defined in each sub-module (say ${johnzon.module.name}). (Quick 'n dirty?)
> I'm not sure, but it might even be appropriate to do both... needs research.
> *You get exceptions like this: 'Unable to make field private final javafx.beans.property.BooleanProperty io.github.demonfiddler.timer.model.MultiTimerBean.delayStart accessible: module io.github.demonfiddler.multitimer does not "opens io.github.demonfiddler.timer.model" to unnamed module @22036d57'. Also Eclipse problem markers like this: "Name of automatic module 'johnzon.core' is unstable, it is derived from the module's file name."



--
This message was sent by Atlassian Jira
(v8.20.10#820010)