You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fury.apache.org by "caicancai (via GitHub)" <gi...@apache.org> on 2024/01/05 09:04:23 UTC
[I] [Feature] Add PR and issue specification documents [incubator-fury]
caicancai opened a new issue, #1308:
URL: https://github.com/apache/incubator-fury/issues/1308
The specifications of issue and PR are the standards that a good community should have. We should explain these specifications to developers. This is conducive to community archiving and developers to learn. I don’t know if such a document already exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [Feature] Add PR and issue specification documents [incubator-fury]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on issue #1308:
URL: https://github.com/apache/incubator-fury/issues/1308#issuecomment-1878706252
> For PR titles, we can follow the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/).
>
> IMHO designing PR and issue templates is quite challenging. Additionally, I believe that excessive restrictions are not beneficial.
Thank you for your reply. Yes, how to ensure that there are no excessive restrictions is also a complex issue. Some communities are trying a very strict restriction, and the shortcomings are also very obvious, which may discourage some developers. Perhaps we should think about how to grasp this degree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [Feature] Add PR and issue specification documents [incubator-fury]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on issue #1308:
URL: https://github.com/apache/incubator-fury/issues/1308#issuecomment-1878675803
@chaokunyang I looked at other projects like calcite, spark, etc. I think it is a good choice to add a PR title check in cli. For example, restrict PR to have keywords: issue number, hotfix, etc. The standards we need to specify are which PRs should be issued and which ones are hotfixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [Feature] Add PR and issue specification documents [incubator-fury]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on issue #1308:
URL: https://github.com/apache/incubator-fury/issues/1308#issuecomment-1878368993
> If we update your PR/issue template, will it address this?
No, to completely solve this problem may require one-to-one communication between the memeber and the developer's PR, but this is unfair to the memeber. We can reduce this problem through documents + update your PR/issue template, etc. The occurrence of similar problems, such as adding a check on the PR title in the cli and updating your PR/issue template, etc. This method is very common in some communities. I know that the calcite community is currently more strict about this, but I feel that the calcite community is too strict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [Feature] Add PR and issue specification documents [incubator-fury]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on issue #1308:
URL: https://github.com/apache/incubator-fury/issues/1308#issuecomment-1878693117
For PR titles, we can follow the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/).
IMHO designing PR and issue templates is quite challenging. Additionally, I believe that excessive restrictions are not beneficial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [Feature] Add PR and issue specification documents [incubator-fury]
Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli commented on issue #1308:
URL: https://github.com/apache/incubator-fury/issues/1308#issuecomment-1878810279
Hello,
In my experience it is usually enough to have a good pr/issues template.
We could enforce the PR title to some specific format.
You check it out in apache/pulsar
@tisonkun worked on this topics for the Pulsar community
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [Feature] Add PR and issue specification documents [incubator-fury]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on issue #1308:
URL: https://github.com/apache/incubator-fury/issues/1308#issuecomment-1878342440
I have seen some communities leave some historical artifacts due to irregularities in raising PRs and issues. I hope Fury can avoid these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [Feature] Add PR and issue specification documents [incubator-fury]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on issue #1308:
URL: https://github.com/apache/incubator-fury/issues/1308#issuecomment-1879673253
thank everyone https://github.com/apache/incubator-fury/pull/1317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [Feature] Add PR and issue specification documents [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on issue #1308:
URL: https://github.com/apache/incubator-fury/issues/1308#issuecomment-1878361275
If we update your PR/issue template, will it address this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [Feature] Add PR and issue specification documents [incubator-fury]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on issue #1308:
URL: https://github.com/apache/incubator-fury/issues/1308#issuecomment-1878371923
My current thoughts are
1. update our PR/issue template
2. Add check for pr title in cli
3. Add this part of the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] [Feature] Add PR and issue specification documents [incubator-fury]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai closed issue #1308: [Feature] Add PR and issue specification documents
URL: https://github.com/apache/incubator-fury/issues/1308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org