You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by GitBox <gi...@apache.org> on 2018/09/29 05:14:23 UTC
[GitHub] cxfeng1 closed pull request #1593: [iOS] remove render_document.cpp
from sdk
cxfeng1 closed pull request #1593: [iOS] remove render_document.cpp from sdk
URL: https://github.com/apache/incubator-weex/pull/1593
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/weex_core/Source/android/jsengine/multiprocess/WeexJSConnection.cpp b/weex_core/Source/android/jsengine/multiprocess/WeexJSConnection.cpp
index d2a609bee9..f7cbd80e6c 100644
--- a/weex_core/Source/android/jsengine/multiprocess/WeexJSConnection.cpp
+++ b/weex_core/Source/android/jsengine/multiprocess/WeexJSConnection.cpp
@@ -117,7 +117,7 @@ WeexJSConnection::WeexJSConnection()
if (checkDirOrFileIsLink(SoUtils::crash_file_path())) {
std::string tmp = SoUtils::crash_file_path();
size_t length = tmp.length();
- char buf[length];
+ char *buf = new char[length];
memset(buf, 0, length);
if (!getDirOrFileLink(SoUtils::crash_file_path(), buf, length)) {
LOGE("getDirOrFileLink filePath(%s) error\n", SoUtils::crash_file_path());
@@ -125,6 +125,7 @@ WeexJSConnection::WeexJSConnection()
} else {
g_crashFileName = buf;
}
+ delete []buf;
} else {
g_crashFileName = SoUtils::crash_file_path();
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services