[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5960: [Target] Migrate data structure of TargetNode

[GitBox <gi...@apache.org>]

tqchen commented on a change in pull request #5960:
URL: https://github.com/apache/incubator-tvm/pull/5960#discussion_r448655057



##########
File path: python/tvm/relay/qnn/op/legalizations.py
##########
@@ -229,18 +229,17 @@ def _shift(data, zero_point, out_dtype):
 def is_fast_int8_on_intel():
     """ Checks whether the hardware has support for fast Int8 arithmetic operations. """
     target = tvm.target.Target.current(allow_none=False)
-    intel_supported_arches = {'-mcpu=skylake-avx512', '-mcpu=cascadelake'}
-    return intel_supported_arches.intersection(set(target.options))
+    return target.mcpu in {'skylake-avx512', 'cascadelake'}
 
 def is_fast_int8_on_arm():
     """ Checks whether the hardware has support for fast Int8 arithmetic operations. """
     target = tvm.target.Target.current(allow_none=False)
-    return '+v8.2a,+dotprod' in ' '.join(target.options)
+    return '+v8.2a,+dotprod' in target.mattr

Review comment:
       you can make the call




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org