You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2024/11/22 10:29:33 UTC
[PR] Make RealmEntityManagerFactory thread-safe [polaris]
adutra opened a new pull request, #466:
URL: https://github.com/apache/polaris/pull/466
# Description
`RealmEntityManagerFactory` is an application-scoped bean and as such is expected to be accessed by multiple threads concurrently; but its `getOrCreateEntityManager` method is not thread-safe: it exhibits a non-synchronized check-then-act sequence involving a non-thread-safe map implementation.
## Type of change
Please delete options that are not relevant.
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Documentation update
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
# How Has This Been Tested?
Manually as it is difficult to bring evidence of thread-safety issues in a unit test.
# Checklist:
Please delete options that are not relevant.
- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make RealmEntityManagerFactory thread-safe [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra merged PR #466:
URL: https://github.com/apache/polaris/pull/466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org