You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/20 08:34:35 UTC

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2042: Fix interrupt stack handlings for ARM SMP

masayuki2009 commented on a change in pull request #2042:
URL: https://github.com/apache/incubator-nuttx/pull/2042#discussion_r508312426



##########
File path: arch/arm/src/cxd56xx/cxd56_irq.c
##########
@@ -115,17 +112,17 @@ static uint64_t g_intstack_alloc[INTSTACK_ALLOC >> 3];
 
 const uint32_t g_cpu_intstack_top[CONFIG_SMP_NCPUS] =
 {
-  (uint32_t)g_intstack_alloc + INTSTACK_SIZE,
+  (uint32_t)g_intstack_alloc + INTSTACK_SIZE - 8,

Review comment:
       > so to avoid the similar issue happen again, it's better to fix the problem from root by removing -8 at all.
   
   @xiaoxiang781216 
   Thanks for your comments.
   I thought the current implementation of SMP_STACK_TOP was correct.
   So do you mean I should fix SMP_STACK_TOP as well ?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org