You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@otava.apache.org by "Phanindra899 (via GitHub)" <gi...@apache.org> on 2026/02/20 13:29:24 UTC

[PR] Add detailed documentation for JsonImporter [otava]

Phanindra899 opened a new pull request, #129:
URL: https://github.com/apache/otava/pull/129

   This PR adds detailed documentation for JsonImporter, including:
   
   - Expected JSON structure
   - Filtering behavior
   - Return format
   - Usage example
   - Error handling
   
   No functional changes were made.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add detailed documentation for JsonImporter [otava]

Posted by "henrikingo (via GitHub)" <gi...@apache.org>.

henrikingo commented on PR #129:
URL: https://github.com/apache/otava/pull/129#issuecomment-3941511027

   This PR deletes code (when it shouldn't / claims otherwise on the description), and the user that is the author doesn't have a name in their profile and the social links 404 or link to a different person.  Closing to avoid accidents.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add detailed documentation for JsonImporter [otava]

Posted by "henrikingo (via GitHub)" <gi...@apache.org>.

henrikingo closed pull request #129: Add detailed documentation for JsonImporter
URL: https://github.com/apache/otava/pull/129


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add detailed documentation for JsonImporter [otava]

Posted by "Phanindra899 (via GitHub)" <gi...@apache.org>.

Phanindra899 commented on PR #129:
URL: https://github.com/apache/otava/pull/129#issuecomment-3957812822

   Hi @henrikingo , thank you for the clarification.
   
   I sincerely apologize for the confusion. My intention was only to add documentation, not to remove any existing code. I’ll carefully review the diff again and ensure that no unintended deletions are included and that the PR description accurately reflects the changes.
   
   Regarding the profile details, I understand the concern. I will update my GitHub profile to include my real name and correct the social links so there’s no ambiguity.
   
   I appreciate you flagging this, and I’ll resubmit a clean PR after addressing these issues.
   
   Thank you for your time and review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org