Re: [PR] Reinstate handshake error handling on channel connect [tinkerpop]

["kenhuuu (via GitHub)" <gi...@apache.org>]

kenhuuu commented on code in PR #2753:
URL: https://github.com/apache/tinkerpop/pull/2753#discussion_r1744124435


##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java:
##########
@@ -87,6 +88,7 @@ default String getScheme(final boolean sslEnabled) {
     abstract class AbstractChannelizer extends ChannelInitializer<SocketChannel> implements Channelizer {
         protected Connection connection;
         protected Cluster cluster;
+        protected SslHandler sslHandler;

Review Comment:
   Is this safe to do? The SslHandler isn't annotated with "Shareable".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org