[jira] [Commented] (FLINK-9852) Expose descriptor-based sink creation in table environments

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545413#comment-16545413 ] 

ASF GitHub Bot commented on FLINK-9852:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/6343

    [FLINK-9852] [table] Expose descriptor-based sink creation

    ## What is the purpose of the change
    
    This commit exposes the new unified sink creation through the table environments and the external catalog table. It introduce a new `update-mode` property in order to distinguish between append, retract, and upsert table sources and sinks. This commit refactors the top-level API classes a last time and adds more documentation. This commit completes the unified table sources/sinks story from an API point of view.
    
    ## Brief change log
    
    - Introduction of `TableEnvironment.connect()` and corresponding API builder classes
    - Introduction of property `update-mode: table` and update of existing connectors
    - External catalog support with proper source/sink discovery and API
    
    ## Verifying this change
    
    Existing tests were adapted.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not documented


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-9852

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6343.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6343
    
----

----


> Expose descriptor-based sink creation in table environments
> -----------------------------------------------------------
>
>                 Key: FLINK-9852
>                 URL: https://issues.apache.org/jira/browse/FLINK-9852
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> Currently, only a table source can be created using the unified table descriptors with {{tableEnv.from(...)}}. A similar approach should be supported for defining sinks or even both types at the same time.
> I suggest the following syntax:
> {code}
> tableEnv.connect(Kafka(...)).registerSource("name")
> tableEnv.connect(Kafka(...)).registerSink("name")
> tableEnv.connect(Kafka(...)).registerSourceAndSink("name")
> {code}
> A table could then access the registered source/sink.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)