You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Adrian Crum (JIRA)" <ji...@apache.org> on 2008/07/19 17:29:31 UTC
[jira] Created: (OFBIZ-1885) Selectable Visual Themes
Selectable Visual Themes
------------------------
Key: OFBIZ-1885
URL: https://issues.apache.org/jira/browse/OFBIZ-1885
Project: OFBiz
Issue Type: Improvement
Components: framework
Reporter: Adrian Crum
Priority: Minor
Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by Bruno Busco <br...@gmail.com>.
I cannot find any usage of the request setUserPreference in OFBiz.
I think that in order to be used as a form target, the method should be
defined with a different prototype such as
setUserPreference(HttpServletRequest, HttpServletResponse)
I have seen that similar event services follow this pattern.
Am i right?
-Bruno
2008/7/31 Bruno Busco <br...@gmail.com>
> Adrian,
> I am trying to simplify the VisualTheme selection form but unfortunately I
> need still to learn...
> Using this form:
>
> <form name="VisualTheme" type="single"
> target="setUserPreference?userPrefTypeId=VISUAL_THEME&userPrefGroupId=GLOBAL_PREFERENCES&userPrefValue=${myTheme}">
> <actions>
> <service service-name="getUserPreference">
> <field-map field-name="userPrefTypeId"
> value="VISUAL_THEME"/>
> </service>
> <set field="myTheme" from-field="userPrefValue"
> default-value="DEFAULT"/>
> </actions>
>
> <field name="myTheme" title="${uiLabelMap.SelectedVisualTheme}">
> <drop-down allow-empty="false">
> <entity-options description="${description}"
> entity-name="VisualTheme" key-field-name="visualThemeId"/>
> </drop-down>
> </field>
> <field name="updateButton"><submit/></field>
> </form>
>
> i effectively do not need to define a new service in the Events.xml. The
> actual selected theme is displayied correctly but when i submit the form i
> get the following error:
>
> The Following Errors Occurred:
>
> Error calling event: org.ofbiz.webapp.event.EventHandlerException: Problems
> processing event: java.lang.NoSuchMethodException:
> org.ofbiz.common.preferences.PreferenceServices.setUserPreference(javax.servlet.http.HttpServletRequest,
> javax.servlet.http.HttpServletResponse)
> (org.ofbiz.common.preferences.PreferenceServices.setUserPreference(javax.servlet.http.HttpServletRequest,
> javax.servlet.http.HttpServletResponse))
> Could someone help me? Sorry if it is (as I suppose) a basic question.
> Thanks,
> -Bruno
>
>
>
>
>
> 2008/7/31 David E Jones <jo...@hotwaxmedia.com>
>
>
>> On Jul 30, 2008, at 11:36 PM, Bruno Busco wrote:
>>
>> Adrian,
>>> I agree that it could be simplyfied using the setUserPreferences request,
>>> thanks for the hint, I was also trying to understand how to rewrite it.
>>> In any case, if we consider that in the Visual Theme form additional
>>> fields
>>> could be added later like for example:
>>> - Default number of rows to display in the FindScreens
>>> - Specific colors for themes that allow the user to change them
>>>
>>
>> These sounds more like things that would go directly into the
>> UserPreference stuff, and wouldn't have so much to do with the themes.
>>
>> -David
>>
>>
>>
>
Re: [jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by Bruno Busco <br...@gmail.com>.
Adrian,
I am trying to simplify the VisualTheme selection form but unfortunately I
need still to learn...
Using this form:
<form name="VisualTheme" type="single"
target="setUserPreference?userPrefTypeId=VISUAL_THEME&userPrefGroupId=GLOBAL_PREFERENCES&userPrefValue=${myTheme}">
<actions>
<service service-name="getUserPreference">
<field-map field-name="userPrefTypeId"
value="VISUAL_THEME"/>
</service>
<set field="myTheme" from-field="userPrefValue"
default-value="DEFAULT"/>
</actions>
<field name="myTheme" title="${uiLabelMap.SelectedVisualTheme}">
<drop-down allow-empty="false">
<entity-options description="${description}"
entity-name="VisualTheme" key-field-name="visualThemeId"/>
</drop-down>
</field>
<field name="updateButton"><submit/></field>
</form>
i effectively do not need to define a new service in the Events.xml. The
actual selected theme is displayied correctly but when i submit the form i
get the following error:
The Following Errors Occurred:
Error calling event: org.ofbiz.webapp.event.EventHandlerException: Problems
processing event: java.lang.NoSuchMethodException:
org.ofbiz.common.preferences.PreferenceServices.setUserPreference(javax.servlet.http.HttpServletRequest,
javax.servlet.http.HttpServletResponse)
(org.ofbiz.common.preferences.PreferenceServices.setUserPreference(javax.servlet.http.HttpServletRequest,
javax.servlet.http.HttpServletResponse))
Could someone help me? Sorry if it is (as I suppose) a basic question.
Thanks,
-Bruno
2008/7/31 David E Jones <jo...@hotwaxmedia.com>
>
> On Jul 30, 2008, at 11:36 PM, Bruno Busco wrote:
>
> Adrian,
>> I agree that it could be simplyfied using the setUserPreferences request,
>> thanks for the hint, I was also trying to understand how to rewrite it.
>> In any case, if we consider that in the Visual Theme form additional
>> fields
>> could be added later like for example:
>> - Default number of rows to display in the FindScreens
>> - Specific colors for themes that allow the user to change them
>>
>
> These sounds more like things that would go directly into the
> UserPreference stuff, and wouldn't have so much to do with the themes.
>
> -David
>
>
>
Re: [jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by David E Jones <jo...@hotwaxmedia.com>.
On Jul 30, 2008, at 11:36 PM, Bruno Busco wrote:
> Adrian,
> I agree that it could be simplyfied using the setUserPreferences
> request,
> thanks for the hint, I was also trying to understand how to rewrite
> it.
> In any case, if we consider that in the Visual Theme form additional
> fields
> could be added later like for example:
> - Default number of rows to display in the FindScreens
> - Specific colors for themes that allow the user to change them
These sounds more like things that would go directly into the
UserPreference stuff, and wouldn't have so much to do with the themes.
-David
Re: [jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by Bruno Busco <br...@gmail.com>.
Adrian,
I agree that it could be simplyfied using the setUserPreferences request,
thanks for the hint, I was also trying to understand how to rewrite it.
In any case, if we consider that in the Visual Theme form additional fields
could be added later like for example:
- Default number of rows to display in the FindScreens
- Specific colors for themes that allow the user to change them
- etc.
may be following the same pattern as done for the preferences form is not
wrong.
Don't you think so?
2008/7/31 Adrian Crum (JIRA) <ji...@apache.org>
>
> [
> https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618564#action_12618564]
>
> Adrian Crum commented on OFBIZ-1885:
> ------------------------------------
>
> Bruno,
>
> Thank you for your contribution. Your patch could be simplified by having
> the Visual Theme selection form call the setUserPreference request (found in
> common-controller.xml).
>
>
> > Selectable Visual Themes
> > ------------------------
> >
> > Key: OFBIZ-1885
> > URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> > Project: OFBiz
> > Issue Type: Improvement
> > Components: framework
> > Reporter: Adrian Crum
> > Priority: Minor
> > Attachments: theme_1.zip, visual_themes.patch,
> visual_themes.patch, VisualThemeSelection.patch
> >
> >
> > Implement entities, services, and UI artifacts to add support for
> selectable Visual Themes.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
Re: [jira] Issue Comment Edited: (OFBIZ-1885) Selectable Visual Themes
Posted by Bruno Busco <br...@gmail.com>.
Thank you for comments,
as suggested I will open a new Jira issue and will submit a patch to have
the collapsible header in the framework (i.e. in the default theme).
I will also update the graphics, there is no reason to have it different.
Thank you,
-Bruno
2008/8/13 Jacques Le Roux (JIRA) <ji...@apache.org>
>
> [
> https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622283#action_12622283]
>
> jacques.le.roux edited comment on OFBIZ-1885 at 8/13/08 11:27 AM:
> ------------------------------------------------------------------
>
> +1 for a new issue for the collapsible masthead
> +1 for keeping things consistent (same expand/collapse graphics for the
> control)
>
> was (Author: jacques.le.roux):
> +1 for a new issue for the collapsible masthead
> +1 for keeping things consistent (sale expand/collapse graphics for the
> control)
>
> > Selectable Visual Themes
> > ------------------------
> >
> > Key: OFBIZ-1885
> > URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> > Project: OFBiz
> > Issue Type: Improvement
> > Components: framework
> > Reporter: Adrian Crum
> > Assignee: Adrian Crum
> > Priority: Minor
> > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg,
> theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch,
> visualtheme_merged.patch, visualtheme_merged.patch,
> visualtheme_merged.patch, visualtheme_merged.patch,
> visualtheme_merged.patch, visualtheme_merged.patch,
> VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
> >
> >
> > Implement entities, services, and UI artifacts to add support for
> selectable Visual Themes.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
Re: [jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by Bruno Busco <br...@gmail.com>.
One more consideration...
Since we are thinking now to move the content application in the framework,
and having seen that how the Visual Theme is structured is not far from a
piece of content that has many pieces of resources linked to it, wouldn't be
beneficial to define a VisualTheme just as a particular ContentType and
having the contentmgr handling it?
2008/7/31 Bruno Busco (JIRA) <ji...@apache.org>
>
> [
> https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Bruno Busco updated OFBIZ-1885:
> -------------------------------
>
> Attachment: VisualThemeSelection.patch
>
> In the attached VisualThemeSelection.patch file there is an implementation
> of a screen that lets the user choose his personal Visual Theme among the
> available ones.
> I tried to follow Adrian's specification (as far as I understood).
>
> > Selectable Visual Themes
> > ------------------------
> >
> > Key: OFBIZ-1885
> > URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> > Project: OFBiz
> > Issue Type: Improvement
> > Components: framework
> > Reporter: Adrian Crum
> > Priority: Minor
> > Attachments: theme_1.zip, visual_themes.patch,
> visual_themes.patch, VisualThemeSelection.patch
> >
> >
> > Implement entities, services, and UI artifacts to add support for
> selectable Visual Themes.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
Re: [jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by Jacques Le Roux <ja...@les7arts.com>.
This is interesting and make sense, but I think we should keep such comments in respective Jira issues. It's easier to follow later.
I noticed some others that why I suggest this, nothing specific.
My 2 cts
Jacques
From: "Bruno Busco" <br...@gmail.com>
> In my opinion both Select Visual Theme, Select language and Select Time-zone
> should be part of a user preferences/profile screen.
>
> The User Preferences screen should be a screen implemented in the common
> component and should let other applications to insert additional settings
> application related (perhaps on different tabs).
>
> On the header (both expanded and collapsed) there should be a link to the
> User profile screen.
>
> The actual User preferences screen implemented in MyPage should be moved in
> the common User preferences screen (in a MyPage settings tab).
>
> My two cents,
> Bruno
>
>
>
>
> 2008/9/24 Jacopo Cappellato (JIRA) <ji...@apache.org>
>
>>
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634046#action_12634046]
>>
>> Jacopo Cappellato commented on OFBIZ-1885:
>> ------------------------------------------
>>
>> In my opinion it is ok to show the link only in the expanded header because
>> changing visual theme is not something that the user will do very often.
>> Jacopo
>>
>> > Selectable Visual Themes
>> > ------------------------
>> >
>> > Key: OFBIZ-1885
>> > URL: https://issues.apache.org/jira/browse/OFBIZ-1885
>> > Project: OFBiz
>> > Issue Type: Improvement
>> > Components: framework
>> > Reporter: Adrian Crum
>> > Assignee: Adrian Crum
>> > Priority: Minor
>> > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg,
>> theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch,
>> visualtheme_merged.patch, visualtheme_merged.patch,
>> visualtheme_merged.patch, visualtheme_merged.patch,
>> visualtheme_merged.patch, visualtheme_merged.patch,
>> visualtheme_merged.patch, visualtheme_merged.patch,
>> visualtheme_merged.patch, visualtheme_merged.patch,
>> VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>> >
>> >
>> > Implement entities, services, and UI artifacts to add support for
>> selectable Visual Themes.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
Re: [jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by Bruno Busco <br...@gmail.com>.
In my opinion both Select Visual Theme, Select language and Select Time-zone
should be part of a user preferences/profile screen.
The User Preferences screen should be a screen implemented in the common
component and should let other applications to insert additional settings
application related (perhaps on different tabs).
On the header (both expanded and collapsed) there should be a link to the
User profile screen.
The actual User preferences screen implemented in MyPage should be moved in
the common User preferences screen (in a MyPage settings tab).
My two cents,
Bruno
2008/9/24 Jacopo Cappellato (JIRA) <ji...@apache.org>
>
> [
> https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634046#action_12634046]
>
> Jacopo Cappellato commented on OFBIZ-1885:
> ------------------------------------------
>
> In my opinion it is ok to show the link only in the expanded header because
> changing visual theme is not something that the user will do very often.
> Jacopo
>
> > Selectable Visual Themes
> > ------------------------
> >
> > Key: OFBIZ-1885
> > URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> > Project: OFBiz
> > Issue Type: Improvement
> > Components: framework
> > Reporter: Adrian Crum
> > Assignee: Adrian Crum
> > Priority: Minor
> > Attachments: compact_header_screenshot.jpg, no_screenshot.jpg,
> theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch,
> visualtheme_merged.patch, visualtheme_merged.patch,
> visualtheme_merged.patch, visualtheme_merged.patch,
> visualtheme_merged.patch, visualtheme_merged.patch,
> visualtheme_merged.patch, visualtheme_merged.patch,
> visualtheme_merged.patch, visualtheme_merged.patch,
> VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
> >
> >
> > Implement entities, services, and UI artifacts to add support for
> selectable Visual Themes.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618013#action_12618013 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
Unfortunately #3 seems not as easy as adding a drop-down field in the same form where the mypage preferences check boxes are...sorry :-(
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1885:
-------------------------------
Attachment: visual_theme_data.patch
Updated patch.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: visual_theme_data.patch, visual_theme_data.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1885:
-------------------------------
Attachment: visualtheme_merged.patch
Updated patch attached.
Bruno,
Thank you very much for your continued work on this! I apologize for the difficulty you had with the last patch - I included the wrong file in the patch.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617981#action_12617981 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
May be a special reader could be defined just for themes.
This reader could be imported using a UI command in order to install new themes after they have been copied in the hot-deploy folder.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum closed OFBIZ-1885.
------------------------------
Resolution: Fixed
Fixed - rev 698346.
Thank you Bruno, and others who commented.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622475#action_12622475 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
Please find the new issue with a new patch here: OFBIZ-1919
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629742#action_12629742 ]
Jacques Le Roux commented on OFBIZ-1885:
----------------------------------------
Bruno,
I'd be interested to see counter arguments to your proposition (if any).
But I guess to get a wider audience you should made this proposition on dv ML
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618015#action_12618015 ]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
The MyPage Preferences page should have a tab bar menu with two items: Main and Visual Theme. The Main tab would contain the current MyPage preferences form, the Visual Theme tab would contain the visual theme selection box.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1885:
-------------------------------
Attachment: visualtheme_merged.patch
Updated visualtheme_merged.patch file. Changed entity package name, modified how global user preferences are retrieved (modified from Bruno's patch).
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634008#action_12634008 ]
Hans Bakker commented on OFBIZ-1885:
------------------------------------
perhaps good to mention that the visual themes button can be found on the header of any screen as long as the header is not minimized.....
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615014#action_12615014 ]
Jacopo Cappellato commented on OFBIZ-1885:
------------------------------------------
Hi Adrian,
this is interesting, thanks for sharing your work in progress.
IMO it would be better to rename the entity "VisualThemeType" to "VisualTheme" so that the naming conventions for the header/item patter are better followed:
VisualTheme
|______________> VisualThemeResource
|______________> VisualThemeResource
|______________> VisualThemeResource
....
Also, but not sure about this: would it make sense to store the VisualThemeResourceTypes in the Enumeration entity instead of their own one?
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: visual_theme_data.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1885:
-------------------------------
Attachment: visual_themes.patch
New patch. Now includes a service to get visual themes and changes to the UI artifacts to display the theme.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum reassigned OFBIZ-1885:
----------------------------------
Assignee: Adrian Crum
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617271#action_12617271 ]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
How would I implement the theme cache in Groovy or simple method?
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1885:
-------------------------------
Attachment: VisualThemeSelection.patch
Bruno,
I updated your patch. Take a look.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622283#action_12622283 ]
Jacques Le Roux commented on OFBIZ-1885:
----------------------------------------
+1 for a new issue for the collapsible masthead
+1 for keeping things consistent (sale expand/collapse graphics for the control)
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634046#action_12634046 ]
Jacopo Cappellato commented on OFBIZ-1885:
------------------------------------------
In my opinion it is ok to show the link only in the expanded header because changing visual theme is not something that the user will do very often.
Jacopo
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1885:
-------------------------------
Attachment: (was: visualtheme_merged.patch)
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629903#action_12629903 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
Adrian,
what do you think of committing this work to a sandbox branch?
It will be much simple to work instead of handling all the changes to the patches.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1885:
-------------------------------
Attachment: visual_themes.patch
Updated patch.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: visual_themes.patch, visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618564#action_12618564 ]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
Bruno,
Thank you for your contribution. Your patch could be simplified by having the Visual Theme selection form call the setUserPreference request (found in common-controller.xml).
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617245#action_12617245 ]
David E. Jones commented on OFBIZ-1885:
---------------------------------------
To make things more consistent, how about renaming resourceEnumId as resourceTypeEnumId.
BTW, just a side note while reviewing this... implementing the main service in Java is interesting, but the code would be simpler and more concise written in Groovy, and you could probably even do this in a simple-method.
BTW2: for the CrUD services try the entity-auto thingy.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1885:
-------------------------------
Attachment: visualtheme_merged.patch
OK,
I updated the merged patch according to your recent suggestion.
Yes, I agree that for the eCommerce there could be a store or catalog field to specify the theme to be used.
May be the "listVisualThemes.ftl" could be converted in a lookup so that it could be easily used in the store or catalog screen to select a theme looking at their screenshot.
I will wait to hear from others on this.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620146#action_12620146 ]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
Bruno,
On the eCommerce side, I know David Jones had something in mind already. Let's hold off on that and let others offer their input.
We already discussed on the dev mailing list that user preferences would not be used on the eCommerce side. Instead, the theme used would be determined by the store or the catalog.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632314#action_12632314 ]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
Bruno,
I looked at the screencap of your theme - it looks great! I haven't looked at your patch yet - I don't have the time right now. I will review it and get all of this committed as soon as I have some time.
Thank you for your help with this!
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629775#action_12629775 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
Jacques,
where I work we have set up years ago SVN, Jira, Confluence, Luntbuild etc. so if I propose something is only because I know that using those tools in some way (as for example the sandbox path) is extremely productive.
Moreover I see that the OFBiz Community is generally very mind-open and (at least) allows to discuss about these management subjets.
I will follow your suggestion to move to the dev ml this thread.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630113#action_12630113 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
We have now the Visual Theme Gallery here: http://docs.ofbiz.org/display/OFBIZ/Visual+Themes+Gallery
Just a first try... ;-)
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629716#action_12629716 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
Giving a quick look at some other Apache project SVN repositories it seems that some of them also have somethink like this:
http://svn.apache.org/repos/asf/ant/sandbox
http://svn.apache.org/repos/asf/beehive/sandbox
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618062#action_12618062 ]
David E. Jones commented on OFBIZ-1885:
---------------------------------------
I'd say this is a case where a custom cache might be a bad idea. Why not just use the entity engine cache? Then at least it would automatically clear when data is changed, etc.
The running time to assemble the list per type based on a cached result from the database should be minimal, so I wouldn't worry about that.
On a side note, the visualTheme package name would be the first like that, ie with multiple words combined in. Could we simplify it to just "theme"?
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1885:
-------------------------------
Attachment: visualtheme_merged.patch
Adrian,
I updated the visualtheme_merged.patch replacing the no_screenshot.jpg with a label so that now we support internationalization.
For the visualtheme.default property and the "_NA_" Userlogin record I ask you to think about it when you have time becouse this is used is order to:
- have the default theme changed very easily. A new theme must be dropped in the hot-deploy folder and the property changed
- have also the login screens (when no UserLogin is specified yet) be consistent with the new default theme
Moreover, the record for "_NA_" that I removed is for the VisualTheme only and not for the other preferences.
If we remove the property then several manual database changes to the VisualThemeResource entities should be required making the default theme not so easy.
An option to the property could be a command in the UI like "Set as default theme" this could make the required changes to the VisualThemeResource and be used instead of the property.
Of course this command should be only available to users having a theme admin permission (that should be introduced).
In order to help people who wants to try the Visual Theme feature I summarize the steps needed:
- Apply on a fresh WD the last version of the visualtheme_merged.patch and run ant build
- Download the last version of the file theme_1.zip and unzip it the hot-deploy folder
- Run OFBiz and import the "ext" reader using webtools
- Go to MyPage -> Preferences -> Visual Theme
- Select the Theme_1 theme to change the theme
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1885:
-------------------------------
Attachment: visualtheme_merged.patch
Adrian,
please forget the branch, I thought we where not so close to the commit.
Please find attached the updated patch with the permission and seed data.
I hope to have done it correctly, if not please advice.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618930#action_12618930 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
Many thanks Adrian,
now I understand (and learned)
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617998#action_12617998 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
Theme_1.zip does not pretend to be an usable theme,
the css file is something I was working on but not finisched and header and footer are the standard one with an additional label to check that they were loaded in plase of the original. So it is just a test theme to discuss about the format.
Looking forward to the real theme-gallery !!! ;-)
I will try to include a drop-down field in the preferences screen to have #3 working...
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617985#action_12617985 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
Reading the thread back I found the list of todos:
1. Theme CRUD services.
2. Theme CRUD UI artifacts.
3. Theme selection screen in MyPage component.
May be we only need n. 3, don't we?
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1885:
-------------------------------
Attachment: visualtheme_merged.patch
Updated patch - now includes CRUD services. Still needs permission service and related seed data.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632306#action_12632306 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
Adrian,
I wonder if you are happy with the permission implementation I did.
BTW I think we should implement also a permission that controls if a user is allowed to select a different Visual Theme or must use the theme the admin has selected for him.
What do you think about?
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622216#action_12622216 ]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
Bruno,
A collapsible masthead would be nice to have in the framework. Maybe we could make another Jira issue just for that, so others will have an opportunity to comment and offer suggestions on what should be collapsed and what should be visible.
Why didn't you use the expand/collapse graphics for the control?
The setUserPreference request should return the user to the application's "main" view. Since a user must be logged in to set their preferences, the expand/collapse controls should only appear if the user is logged in.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634042#action_12634042 ]
Jacques Le Roux commented on OFBIZ-1885:
----------------------------------------
Maybe we could put at screen left, near the logo, and show it even when minimized ?
In the same spirit we could show the languages link at right when minimized...
What do you think guys ?
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617976#action_12617976 ]
bruno.busco edited comment on OFBIZ-1885 at 7/29/08 3:03 PM:
-------------------------------------------------------------
Adrian,
I tryed your patch and I found it really cool !!!
I did not resist to see how a theme could be distributed and installed leveraging on the theme system you have built and I found a way that IMO is really easy but for sure it needs a review...
In the attached file theme_1.zip there is something that could be considered a pluggable theme.
To install the theme it must be unzipped in the hot-deploy directory and then, using the webtool, the ext reader must be imported (or this can be done executing ant run-extseed).
Then, since we have not yet the UI to select the theme, a manual selection can be done changing the line:
<set field="visualThemeId" from-field="userPrefValue" default-value="DEFAULT"/>
to:
<set field="visualThemeId" from-field="userPrefValue" default-value="THEME_1"/>
in the framework\common\widget\CommonScreens.xml file.
What do you think of it?
was (Author: bruno.busco):
Adrian,
I tryed your patch and I found it really cool !!!
I did not resist to see how a theme could be distributed and installed leveraging on the theme system you have built and I found a way that IMO is really easy but for sure it needs a review...
In the attached file theme_1.zip there is something that could be considered a pluggable theme.
To install the theme it must be unzipped in the hot-deploy directory and then, using the webtool, the ext seed must be imported (or this can be done executing ant run-extseed).
Then, since we have not yet the UI to select the theme, a manual selection can be done changing the line:
<set field="visualThemeId" from-field="userPrefValue" default-value="DEFAULT"/>
to:
<set field="visualThemeId" from-field="userPrefValue" default-value="THEME_1"/>
in the framework\common\widget\CommonScreens.xml file.
What do you think of it?
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: désinscription listes ofbiz
Posted by Fabien JALABERT <fa...@laposte.net>.
Bonjour, je l'ai déjà fait plusieurs fois, je n'ai jamais reçu le fameux
pour confirmer...
Malin Nicolas a écrit :
>
> In french :
>
> Bonjour Fabien,
> As tu bien envoyer un message vide sur l'adresse de désinscription ?
> dev-unsubscribe@ofbiz.apache.org
>
> Nicolas
>
> Fabien JALABERT a écrit :
>>
>> Bonjour,
>>
>> j'ai essayé de multiples fois de me désinscrire des listes ofbiz,
>> jamais je ne recois de mail et jamais je ne peux me désinscrire...
>> peux tu m'aider ?
>>
>> Merci.
>>
>>
>
>
Re: désinscription listes ofbiz
Posted by Malin Nicolas <ma...@librenberry.net>.
In french :
Bonjour Fabien,
As tu bien envoyer un message vide sur l'adresse de désinscription ?
dev-unsubscribe@ofbiz.apache.org
Nicolas
Fabien JALABERT a écrit :
>
> Bonjour,
>
> j'ai essayé de multiples fois de me désinscrire des listes ofbiz,
> jamais je ne recois de mail et jamais je ne peux me désinscrire...
> peux tu m'aider ?
>
> Merci.
>
>
--
Nicolas MALIN
Consultant
Tél : 06.17.66.40.06
Site projet : http://www.neogia.org/
-------
Société LibrenBerry
Tél : 02.48.02.56.12
Site : http://www.librenberry.net/
Re: désinscription listes ofbiz
Posted by Jacques Le Roux <ja...@les7arts.com>.
Vraiment étrange, c'est la première fois que ce cas de figure se présente.
The mailing lists administrator should be David I guess. Please David, could you have a look at this ?
Thanks
Jacques
From: "Fabien JALABERT" <fa...@laposte.net>
>
> Je n'ai aucun antispam actif à ma connaissance (provider?) et normalement, je me suis inscrit avec cette adresse
> fabien.jalabert@laposte.net (à défaut : fjspam@laposte.net ). Mais j'ai déjà essayé les unsubscribe avec les deux adresses...
>
> Connaissez vous l'administrateur de la liste ?
>
> Merci.
>
>
> Jacques Le Roux a écrit :
>>
>> Dans ce cas il peut s'agir soit
>> 1. d'une erreur d'adresse. Je veux dire de l'adresse utilisée pour s'inscrire. Etait-ce bien avec fabien.jalabert@laposte.net ?
>> 2. Ou d'un spam qui bloque le message envoyé par le gestionnaire (automatique) de la liste
>>
>> Jacques
>>
>> From: "Fabien JALABERT" <fa...@laposte.net>
>>>
>>> Bonjour, je l'ai déjà fait plusieurs fois, je n'ai jamais reçu le fameux pour confirmer...
>>>
>>> Jacques Le Roux a écrit :
>>>>
>>>> Fabien,
>>>>
>>>> Pour te désinscrire rien de plus facile, envoie un mail à dev-unsubscribe@ofbiz.apache.org (même chose pour les autres listes
>>>> voir plus bas).
>>>> Tu recevras alors un mail auquel il te faudra simplement répondre, sans rien ajouter.
>>>> Tu devrais alors recevoir un second mail confirmant ta désinscription
>>>> Tout est là : http://docs.ofbiz.org/display/OFBADMIN/Mailing+Lists
>>>>
>>>> Jacques
>>>>
>>>> From: "Fabien JALABERT" <fa...@laposte.net>
>>>>>
>>>>> Bonjour,
>>>>>
>>>>> j'ai essayé de multiples fois de me désinscrire des listes ofbiz, jamais je ne recois de mail et jamais je ne peux me
>>>>> désinscrire...
>>>>> peux tu m'aider ?
>>>>>
>>>>> Merci.
>>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>>
>
>
Re: désinscription listes ofbiz
Posted by Fabien JALABERT <fa...@laposte.net>.
Je n'ai aucun antispam actif à ma connaissance (provider?) et
normalement, je me suis inscrit avec cette adresse
fabien.jalabert@laposte.net (à défaut : fjspam@laposte.net ). Mais j'ai
déjà essayé les unsubscribe avec les deux adresses...
Connaissez vous l'administrateur de la liste ?
Merci.
Jacques Le Roux a écrit :
>
> Dans ce cas il peut s'agir soit
> 1. d'une erreur d'adresse. Je veux dire de l'adresse utilisée pour
> s'inscrire. Etait-ce bien avec fabien.jalabert@laposte.net ?
> 2. Ou d'un spam qui bloque le message envoyé par le gestionnaire
> (automatique) de la liste
>
> Jacques
>
> From: "Fabien JALABERT" <fa...@laposte.net>
>>
>> Bonjour, je l'ai déjà fait plusieurs fois, je n'ai jamais reçu le
>> fameux pour confirmer...
>>
>> Jacques Le Roux a écrit :
>>>
>>> Fabien,
>>>
>>> Pour te désinscrire rien de plus facile, envoie un mail à
>>> dev-unsubscribe@ofbiz.apache.org (même chose pour les autres listes
>>> voir plus bas).
>>> Tu recevras alors un mail auquel il te faudra simplement répondre,
>>> sans rien ajouter.
>>> Tu devrais alors recevoir un second mail confirmant ta désinscription
>>> Tout est là : http://docs.ofbiz.org/display/OFBADMIN/Mailing+Lists
>>>
>>> Jacques
>>>
>>> From: "Fabien JALABERT" <fa...@laposte.net>
>>>>
>>>> Bonjour,
>>>>
>>>> j'ai essayé de multiples fois de me désinscrire des listes ofbiz,
>>>> jamais je ne recois de mail et jamais je ne peux me désinscrire...
>>>> peux tu m'aider ?
>>>>
>>>> Merci.
>>>>
>>>
>>>
>>>
>>
>>
>
>
>
Re: désinscription listes ofbiz
Posted by Jacques Le Roux <ja...@les7arts.com>.
Dans ce cas il peut s'agir soit
1. d'une erreur d'adresse. Je veux dire de l'adresse utilisée pour s'inscrire. Etait-ce bien avec fabien.jalabert@laposte.net ?
2. Ou d'un spam qui bloque le message envoyé par le gestionnaire (automatique) de la liste
Jacques
From: "Fabien JALABERT" <fa...@laposte.net>
>
> Bonjour, je l'ai déjà fait plusieurs fois, je n'ai jamais reçu le fameux pour confirmer...
>
> Jacques Le Roux a écrit :
>>
>> Fabien,
>>
>> Pour te désinscrire rien de plus facile, envoie un mail à dev-unsubscribe@ofbiz.apache.org (même chose pour les autres listes
>> voir plus bas).
>> Tu recevras alors un mail auquel il te faudra simplement répondre, sans rien ajouter.
>> Tu devrais alors recevoir un second mail confirmant ta désinscription
>> Tout est là : http://docs.ofbiz.org/display/OFBADMIN/Mailing+Lists
>>
>> Jacques
>>
>> From: "Fabien JALABERT" <fa...@laposte.net>
>>>
>>> Bonjour,
>>>
>>> j'ai essayé de multiples fois de me désinscrire des listes ofbiz, jamais je ne recois de mail et jamais je ne peux me
>>> désinscrire...
>>> peux tu m'aider ?
>>>
>>> Merci.
>>>
>>
>>
>>
>
>
Re: désinscription listes ofbiz
Posted by Fabien JALABERT <fa...@laposte.net>.
Bonjour, je l'ai déjà fait plusieurs fois, je n'ai jamais reçu le fameux
pour confirmer...
Jacques Le Roux a écrit :
>
> Fabien,
>
> Pour te désinscrire rien de plus facile, envoie un mail à
> dev-unsubscribe@ofbiz.apache.org (même chose pour les autres listes
> voir plus bas).
> Tu recevras alors un mail auquel il te faudra simplement répondre,
> sans rien ajouter.
> Tu devrais alors recevoir un second mail confirmant ta désinscription
> Tout est là : http://docs.ofbiz.org/display/OFBADMIN/Mailing+Lists
>
> Jacques
>
> From: "Fabien JALABERT" <fa...@laposte.net>
>>
>> Bonjour,
>>
>> j'ai essayé de multiples fois de me désinscrire des listes ofbiz,
>> jamais je ne recois de mail et jamais je ne peux me désinscrire...
>> peux tu m'aider ?
>>
>> Merci.
>>
>
>
>
Re: désinscription listes ofbiz
Posted by Jacques Le Roux <ja...@les7arts.com>.
Fabien,
Pour te désinscrire rien de plus facile, envoie un mail à dev-unsubscribe@ofbiz.apache.org (même chose pour les autres listes voir
plus bas).
Tu recevras alors un mail auquel il te faudra simplement répondre, sans rien ajouter.
Tu devrais alors recevoir un second mail confirmant ta désinscription
Tout est là : http://docs.ofbiz.org/display/OFBADMIN/Mailing+Lists
Jacques
From: "Fabien JALABERT" <fa...@laposte.net>
>
> Bonjour,
>
> j'ai essayé de multiples fois de me désinscrire des listes ofbiz, jamais je ne recois de mail et jamais je ne peux me
> désinscrire...
> peux tu m'aider ?
>
> Merci.
>
désinscription listes ofbiz
Posted by Fabien JALABERT <fa...@laposte.net>.
Bonjour,
j'ai essayé de multiples fois de me désinscrire des listes ofbiz, jamais
je ne recois de mail et jamais je ne peux me désinscrire...
peux tu m'aider ?
Merci.
[jira] Issue Comment Edited: (OFBIZ-1885) Selectable Visual Themes
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622283#action_12622283 ]
jacques.le.roux edited comment on OFBIZ-1885 at 8/13/08 11:27 AM:
------------------------------------------------------------------
+1 for a new issue for the collapsible masthead
+1 for keeping things consistent (same expand/collapse graphics for the control)
was (Author: jacques.le.roux):
+1 for a new issue for the collapsible masthead
+1 for keeping things consistent (sale expand/collapse graphics for the control)
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1885:
-------------------------------
Attachment: visualtheme_merged.patch
Updated patch. I moved the Visual Theme selection to a lookup screen - so it operates just like locale and time zone settings.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619936#action_12619936 ]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
Bruno,
I have already spent a considerable amount of time thinking about user preference settings. I had them implemented where I work years before their introduction to the project. Maybe you aren't understanding how they are intended to to be used.
The "_NA_" user login ID found in User Preferences is intended to be used when the user isn't logged into OFBiz (or they are logged in and no preference has been set) and some sort of default values must be supplied. Doing things this way simplifies the code using the preferences - instead of always checking to see if a preference exists, you can assume it exists because the preference data was set up that way. Doing things this way also provides a single point where a particular default value can be changed.
In the trunk there is only one global preference implemented - a flag to indicate if the user has JavaScript enabled. (A global preference is a preference that is used by more than one component.) Once the visual theme feature is implemented there will be two global preferences. In a few months there might be more. As time goes on and more global preferences are implemented, it will be easy to have one service call to get them all - by retrieving the GLOBAL_PREFERENCES group. (I'm picturing the global preferences being retrieved by the view handler at the start of view processing. I might even add that change to this issue - I'm still thinking about it.)
I believe this process is fundamentally sound and easy for developers to understand. What will cause confusion is when a property and a bit of code changes the behavior of a particular preference.
If an installation wants to have a different default theme, then they will only have to overwrite the "_NA_" user login preference record with their own data. One thing we can change to help avoid confusion is the description of the OFBiz default theme. Maybe call it "Standard OFBiz - Floating" or "Original OFBiz - Floating", etc.
I would prefer to start off with a simple implementation and see how it goes. If switching default visual themes becomes an issue down the road, then we can address it at that time.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1885:
-------------------------------
Attachment: visualtheme_merged.patch
Updated visualtheme_merged.patch file.
Converted the Java service to simple method, cleaned up the Visual Theme selection screen, added a resource type, and changed one resource type.
Bruno - you will need to update your zip file to work with the latest patch.
I plan to commit this next weekend.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629974#action_12629974 ]
Jacques Le Roux commented on OFBIZ-1885:
----------------------------------------
Something I do when I don't want to mix things too much is to create a speficic check out for a specific set of complex functionnalities.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615032#action_12615032 ]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
Jacopo,
Those are great suggestions - thanks!
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: visual_theme_data.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1885:
-------------------------------
Attachment: VisualThemeSelection.patch
In the attached VisualThemeSelection.patch file there is an implementation of a screen that lets the user choose his personal Visual Theme among the available ones.
I tried to follow Adrian's specification (as far as I understood).
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1885:
-------------------------------
Attachment: theme_1.zip
no_screenshot.jpg
visualtheme_merged.patch
Adrian,
I have done the following improvements to the VisualTheme:
- added the visualtheme.default property in general.properties
This let us select the default theme that will be used as long as the user does not select another one.
If the visualtheme.default is not set (as OOTB) then the default theme will be "DEFAULT"
- removed the visualtheme record for the "_NA_" UserLogin
In this way, if a default theme is specified in the visualtheme.default property it will be used for the login page also.
- added a new VisualThemeResource type VT_SCREENSHOT to have a theme preview screenshot
- changed the Visual theme selection screen to show the VisualTheme preview screenshot
- created the no_screenshot.jpg
This, at the moment is a copy of the default.jpg image showing "No photo available", could be something more specific.
I merged together the two patches because it was not easy for me to make a patch to a patched and not committed file.
I hope its ok with you. The new patch is "VisualTheme_Merged.patch" and should be comprensive of everything needed but the binary file "no_screenshot.jpg" that is attached separately.
I attach to this issue also a new theme_1.zip file that now includes the screenshot jpg.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619550#action_12619550 ]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
Bruno,
Thank you for your continuing work on this. There are a few things that need to be changed however.
I don't believe we need a default setting in a properties file. If an installation wanted to have a different default theme, then they could replace it in the VisualThemeResources entity.
The _NA_ UserLogin is needed to support a default global preferences setting group.
The VT_SCREENSHOT resource is a great idea.
The no_screenshot.jpg file is an interesting idea, but it doesn't support internationalization. Maybe we should just display text to indicate there is no screen shot available, or have nothing at all.
Merging the two patches is a good idea. That will make it easier for others to evaluate the feature.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617225#action_12617225 ]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
Steps needed for completion:
1. Theme CRUD services.
2. Theme CRUD UI artifacts.
3. Theme selection screen in MyPage component.
I won't be able to work on this for a few weeks. If anyone wants to jump in and help, they are welcome to do so.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1885:
-------------------------------
Attachment: visual_theme_data.patch
visual_theme_data.patch contains the entities and seed data.
I'll continue working on this when I have time.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: visual_theme_data.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1885:
-------------------------------
Attachment: (was: visual_theme_data.patch)
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629803#action_12629803 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
No problem at all, Adrian!
Thank you.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1885:
-------------------------------
Attachment: compact_header_screenshot.jpg
visualtheme_merged.patch
vt_compactheader.zip
Hi Adrian,
please find attached the new vt_compactheader Visual Theme.
This theme is like the standard OFBiz theme but with a collapsable header like we have spoken in the DEV ML with Jacopo and Jacques.
When the header is collapsed the screen looks like you can see in the compact_header_screenshot.jpg.
Using the little "^" link on the right of the header this is collapsed and the UserPreference COMPACTHEADER is set to "Y".
In this way all the screens are rendered with the collapsed header and the setting is rememered for future logins.
The new "COMPACTHEADER" UserPreferences is only defined within the VisualTheme. No specific hack is necessary to support it outside of the theme.
To retrieve new UserPreference I used the getUserPreferenceGroup service instead of the getUserPreference that we used before to get the VisualTheme only.
I hope that doing this change I have well understood and followed the UserPreferences design that you implemented. (please see the updated visualtheme_merged.patch)
One thing that IMO may be needs some cleaning is how the setUserPreferences service is handled.
It always takes to the MyPage screen and if the MyPage application was not logged in by the user he is prompted for the login.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617990#action_12617990 ]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
Bruno,
Thank you very much for taking the time to look at this!
Your zip file represents what we have discussed on the dev mailing list so far - themes can be added to OFBiz by dropping them in the hot-deploy folder.
Don't worry about the theme implementation changing - I'm pretty happy with where it is right now. If any changes are made to the code I've submitted so far, they will be minor ones. (Example: I'm thinking we should have a "Footer Javascript" resource type.)
Getting step #3 implemented would help others see the visual theme capability sooner. Steps #1 and #2 are based on something David suggested: a UI so people can build their own themes by uploading style sheets, java script files, and such.
I don't have time right now to try out your theme. I'm fully committed to other projects for the next few weeks. I will get back to this though - it is something I have been wanting in OFBiz for a long time.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630160#action_12630160 ]
Jacques Le Roux commented on OFBIZ-1885:
----------------------------------------
Not sure for the colors :D but great initiative, yes !
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-1885:
-------------------------------
Attachment: theme_1.zip
Adrian,
I tryed your patch and I found it really cool !!!
I did not resist to see how a theme could be distributed and installed leveraging on the theme system you have built and I found a way that IMO is really easy but for sure it needs a review...
In the attached file theme_1.zip there is something that could be considered a pluggable theme.
To install the theme it must be unzipped in the hot-deploy directory and then, using the webtool, the ext seed must be imported (or this can be done executing ant run-extseed).
Then, since we have not yet the UI to select the theme, a manual selection can be done changing the line:
<set field="visualThemeId" from-field="userPrefValue" default-value="DEFAULT"/>
to:
<set field="visualThemeId" from-field="userPrefValue" default-value="THEME_1"/>
in the framework\common\widget\CommonScreens.xml file.
What do you think of it?
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: theme_1.zip, visual_themes.patch, visual_themes.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629905#action_12629905 ]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
Bruno,
I have very little time to spend on this as it is, let alone manage another SVN branch. Why do you feel it is difficult to apply a patch to your local copy?
This issue is nearly complete. Once the permissions are in place, I will commit it to the trunk.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620143#action_12620143 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
Thank you for explanation, I now better understand the schema that is behind the VisuaTheme and the user preferences in general.
I agree with you that the property will alter the schema and should be avoided using the "_NA_" user login. I will update the patch soon in this direction.
BTW I was looking at how to change the ecommerce to make it use a VisualTheme.
I am looking at the changes made by you to the CommonSreen.xml and the header.ftl files of the backoffice and trying to replicate in the ecommerce.
In this case, I propose, as first step, to have only one VisualTheme defined for the ecommerce in a WebStore field (I am temporary using the StyleSheet field now).
So users won't be able to change the theme of the WebStore and no UserPreferences is used.
Are you OK with this? Or a different schema should be used?
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623570#action_12623570 ]
Adrian Crum commented on OFBIZ-1885:
------------------------------------
Bruno,
Thank you for taking the time to review the patch. I agree it would be preferable to have a screen for user preferences, but that is not in the scope of this issue. For now, let's stay focused on getting the visual themes implemented. We can tackle the user preferences screen in another issue.
We still need CRUD services for this.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621211#action_12621211 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
Adrian,
I cannot find the listVisualThemes.ftl file in your last patch.
>From your comments I guess you changed it.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629713#action_12629713 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
Hi Adrian,
I was trying to give a little contribution on this following your path ("Still needs permission service and related seed data.")
Unfortunately patching a fresh OFBiz installation with the latest visualtheme_merged.patch gives me some problem:
1) The listVisualThemes.ftl is expected to be in framework\common\webcommon\includes but the patch puts it into the path where it was earlier (specialpurpose\mypage\webapp\mypage\visualtheme)
And I have easily copied the file in my wd to start working
2) When I try to select a different Visual Theme I get the following error:
org.ofbiz.webapp.control.RequestHandlerException: Unknown request [updateVisualTheme]; this request does not exist or cannot be called directly.
Note that I have accessed the VisualTheme Selection screen from the catalog application.
I have a proposal that, if the Community agree, we could continue discussing in the dev ML:
Could we have in SVN a "sandboxes" folder where things like this are developed and tested and then merged to the trunk?
This will make life very easier instead of building patches over and over and replacing them on a jira issue.
Just my two cents.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1885) Selectable Visual Themes
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1885:
-------------------------------
Attachment: visualtheme_merged.patch
Updated patch - includes file missing in previous patch.
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1885) Selectable Visual Themes
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623567#action_12623567 ]
Bruno Busco commented on OFBIZ-1885:
------------------------------------
Tryed the updated patch and looks good to me.
I suggest to put a width=320 height=200 to resize the image in the lookup.
I have seen that now the VisualTheme can be selected using a button in the header (not colapsed) like for language and timezone.
I think that all three selections should go in a User Preference screen defined in the framework as described in the Discussion thread in the ML.
In the header (both standard sized and collapsed a simple profile link should take the user to its profile and preference settings. This is much more standard and will let us put mny other preference settings that otherwise will get the header more and more confused.
-Bruno
> Selectable Visual Themes
> ------------------------
>
> Key: OFBIZ-1885
> URL: https://issues.apache.org/jira/browse/OFBIZ-1885
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Adrian Crum
> Priority: Minor
> Attachments: compact_header_screenshot.jpg, no_screenshot.jpg, theme_1.zip, theme_1.zip, visual_themes.patch, visual_themes.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, visualtheme_merged.patch, VisualThemeSelection.patch, VisualThemeSelection.patch, vt_compactheader.zip
>
>
> Implement entities, services, and UI artifacts to add support for selectable Visual Themes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.