[GitHub] QiuMM commented on a change in pull request #6676: Handoff should ignore segments that are dropped by drop rules

[GitBox <gi...@apache.org>]

QiuMM commented on a change in pull request #6676: Handoff should ignore segments that are dropped by drop rules
URL: https://github.com/apache/incubator-druid/pull/6676#discussion_r238615837
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/http/DatasourcesResource.java
 ##########
 @@ -620,23 +627,49 @@ private ImmutableDruidDataSource getDataSource(final String dataSourceName)
   @Path("/{dataSourceName}/intervals/{interval}/serverview")
   @Produces(MediaType.APPLICATION_JSON)
   @ResourceFilters(DatasourceResourceFilter.class)
-  public Response getSegmentDataSourceSpecificInterval(
+  public Response getSegmentServerview(
 
 Review comment:
   Changed the method name since I think it makes more sense, and there is another method using the same name `getSegmentDataSourceSpecificInterval` in this class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org