You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2007/02/20 23:21:06 UTC

[jira] Created: (HTTPCLIENT-638) MultiThreadedHttpConnectionManager:connectionPool.numConnections synchronised using two different objects

MultiThreadedHttpConnectionManager:connectionPool.numConnections synchronised using two different objects
---------------------------------------------------------------------------------------------------------

                 Key: HTTPCLIENT-638
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-638
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: HttpClient
    Affects Versions: 3.1 RC1
            Reporter: Sebb
            Priority: Minor


connectionPool.numConnections in MultiThreadedHttpConnectionManager is synchronized using two different objects: "this" and connectionPool.

Is this intended?

Can it cause problems?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org

Re: [jira] Closed: (HTTPCLIENT-638) MultiThreadedHttpConnectionManager:connectionPool.numConnections synchronised using two different objects

Posted by Michael Becke <mb...@gmail.com>.
No worries.  Looks like HttpClient has turned out to be a good
debugging tool for Findbugs :)

Mike

On 2/20/07, sebb <se...@gmail.com> wrote:
> Duh! Sorry, did not spot that.
>
> BTW, Findbugs complains that it is _unsynchronized_ at lines 474 and
> 575, which is clearly wrong.
>
> S.
> On 21/02/07, Michael Becke (JIRA) <ji...@apache.org> wrote:
> >
> >     [ https://issues.apache.org/jira/browse/HTTPCLIENT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> >
> > Michael Becke closed HTTPCLIENT-638.
> > ------------------------------------
> >
> >    Resolution: Invalid
> >
> > Hi Sebb,
> >
> > In these cases 'this' and 'connectionPool' refer to the same object.  It just depends if the code is inside the connectionPool (uses this) or inside MTHCM (uses connectionPool).
> >
> > Mike
> >
> > > MultiThreadedHttpConnectionManager:connectionPool.numConnections synchronised using two different objects
> > > ---------------------------------------------------------------------------------------------------------
> > >
> > >                 Key: HTTPCLIENT-638
> > >                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-638
> > >             Project: HttpComponents HttpClient
> > >          Issue Type: Bug
> > >          Components: HttpClient
> > >    Affects Versions: 3.1 RC1
> > >            Reporter: Sebb
> > >            Priority: Minor
> > >
> > > connectionPool.numConnections in MultiThreadedHttpConnectionManager is synchronized using two different objects: "this" and connectionPool.
> > > Is this intended?
> > > Can it cause problems?
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org

Re: [jira] Closed: (HTTPCLIENT-638) MultiThreadedHttpConnectionManager:connectionPool.numConnections synchronised using two different objects

Posted by sebb <se...@gmail.com>.
Duh! Sorry, did not spot that.

BTW, Findbugs complains that it is _unsynchronized_ at lines 474 and
575, which is clearly wrong.

S.
On 21/02/07, Michael Becke (JIRA) <ji...@apache.org> wrote:
>
>     [ https://issues.apache.org/jira/browse/HTTPCLIENT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Michael Becke closed HTTPCLIENT-638.
> ------------------------------------
>
>    Resolution: Invalid
>
> Hi Sebb,
>
> In these cases 'this' and 'connectionPool' refer to the same object.  It just depends if the code is inside the connectionPool (uses this) or inside MTHCM (uses connectionPool).
>
> Mike
>
> > MultiThreadedHttpConnectionManager:connectionPool.numConnections synchronised using two different objects
> > ---------------------------------------------------------------------------------------------------------
> >
> >                 Key: HTTPCLIENT-638
> >                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-638
> >             Project: HttpComponents HttpClient
> >          Issue Type: Bug
> >          Components: HttpClient
> >    Affects Versions: 3.1 RC1
> >            Reporter: Sebb
> >            Priority: Minor
> >
> > connectionPool.numConnections in MultiThreadedHttpConnectionManager is synchronized using two different objects: "this" and connectionPool.
> > Is this intended?
> > Can it cause problems?
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org

[jira] Closed: (HTTPCLIENT-638) MultiThreadedHttpConnectionManager:connectionPool.numConnections synchronised using two different objects

Posted by "Michael Becke (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Becke closed HTTPCLIENT-638.
------------------------------------

    Resolution: Invalid

Hi Sebb,

In these cases 'this' and 'connectionPool' refer to the same object.  It just depends if the code is inside the connectionPool (uses this) or inside MTHCM (uses connectionPool).

Mike

> MultiThreadedHttpConnectionManager:connectionPool.numConnections synchronised using two different objects
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-638
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-638
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.1 RC1
>            Reporter: Sebb
>            Priority: Minor
>
> connectionPool.numConnections in MultiThreadedHttpConnectionManager is synchronized using two different objects: "this" and connectionPool.
> Is this intended?
> Can it cause problems?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org