You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Gurkan Erdogdu (JIRA)" <de...@myfaces.apache.org> on 2010/09/14 13:19:32 UTC
[jira] Created: (MYFACES-2919) LifecycleProvider Based Problems and
Tomcat7 LifeCycleProvider Support
LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
----------------------------------------------------------------------
Key: MYFACES-2919
URL: https://issues.apache.org/jira/browse/MYFACES-2919
Project: MyFaces Core
Issue Type: Bug
Reporter: Gurkan Erdogdu
Patch content
----------------------
1- ResourceAnnotationLifecycleProvider : It does not check super class for annotations. It must examine super classes. This is specificed in Java EE 6 specification, EE 5.2.5 Annotations and Injections.
2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch "Throwable" and ignore them. Otherwise, it throws error/s that are not catched and calling code is not able to process other lifecycle providers.
3- StartupServletContextListener : Early initiliazation of lifecycle provider. Otherwise, it is not possible to use META-INF/services providers.
4- pom.xml : Adding Tomcat 7 libs.
5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909446#action_12909446 ]
Jakob Korherr commented on MYFACES-2919:
----------------------------------------
Hi Leo,
1. It was changed to catch Throwable to allow swallowing Errors too, in order to prevent Errors in one LifecycleProvider affect any other LifecycleProvider.
2. It will work just as before (already tested), because the "old" TomcatAnnotationLifecycleProvider will be picked up and will return true in isAvailable(), and the new Tomcat7AnnotationLifecycleProvider will be picked up too, but return false in isAvailable(), because it is not a Tomcat-7 environment, and thus will not be installed.
3. This coded was commented in the first place, because we were not sure whether or not to include annotations from super-classes, but Gurkan is right, the spec states that we should also scan super-classes. Thus the code was uncommented.
I tested some scenarios and it all worked well. However if you think it is too unstable to include it in the release, please feel free to revert the code ;)
Regards,
Jakob
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Gurkan Erdogdu
> Assignee: Jakob Korherr
> Fix For: 2.0.2-SNAPSHOT
>
> Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for annotations. It must examine super classes. This is specificed in Java EE 6 specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch "Throwable" and ignore them. Otherwise, it throws error/s that are not catched and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider. Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr resolved MYFACES-2919.
------------------------------------
Fix Version/s: 2.0.2
Resolution: Fixed
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.1
> Reporter: Gurkan Erdogdu
> Assignee: Jakob Korherr
> Fix For: 2.0.2
>
> Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for annotations. It must examine super classes. This is specificed in Java EE 6 specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch "Throwable" and ignore them. Otherwise, it throws error/s that are not catched and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider. Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909297#action_12909297 ]
Jakob Korherr commented on MYFACES-2919:
----------------------------------------
Hi Gurkan,
I provided another patch with a few minor changes from your original patch: I changed the access to ServletContext.getAttribute() to use the ApplicationMap, I changed the provided-scope to the compile-scope on the optional-dependencies (because optional = true needs compile-scope) and I removed the call to
DefaultLifecycleProviderFactory.getLifecycleProviderFactory().getLifecycleProvider(externalContext);
from StartupServletContextListener, because we already do this a few lines earlier in AbstractFacesInitializer.
Could you please check if the new patch works for you? If so, I'll commit it asap ;)
Thanks,
Jakob
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Gurkan Erdogdu
> Assignee: Jakob Korherr
> Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for annotations. It must examine super classes. This is specificed in Java EE 6 specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch "Throwable" and ignore them. Otherwise, it throws error/s that are not catched and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider. Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2919) LifecycleProvider Based Problems and
Tomcat7 LifeCycleProvider Support
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr updated MYFACES-2919:
-----------------------------------
Status: Resolved (was: Patch Available)
Fix Version/s: 2.0.2-SNAPSHOT
Resolution: Fixed
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Gurkan Erdogdu
> Assignee: Jakob Korherr
> Fix For: 2.0.2-SNAPSHOT
>
> Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for annotations. It must examine super classes. This is specificed in Java EE 6 specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch "Throwable" and ignore them. Otherwise, it throws error/s that are not catched and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider. Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909485#action_12909485 ]
Leonardo Uribe commented on MYFACES-2919:
-----------------------------------------
Hi Jakob
1. Yes, but if there is one LifecycleProvider per webapp, this problem dissapear. At least, we should log a message in that location.
2. Ok, I was expecting something changed on DefaultLifecycleProviderFactory, but I was looking on the wrong place (now there are two entries on
META-INF/services/org.apache.myfaces.config.annotation.LifecycleProvider file)
3. Ok, good.
Now it is clear we need to fix DefaultLifecycleProviderFactory, to use one LifecycleProvider per webapp, revert the point when exceptions are swallowed and add a log message there. I'll do that.
regards,
Leonardo
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Gurkan Erdogdu
> Assignee: Jakob Korherr
> Fix For: 2.0.2-SNAPSHOT
>
> Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for annotations. It must examine super classes. This is specificed in Java EE 6 specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch "Throwable" and ignore them. Otherwise, it throws error/s that are not catched and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider. Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909491#action_12909491 ]
Jakob Korherr commented on MYFACES-2919:
----------------------------------------
OK, great :)
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Gurkan Erdogdu
> Assignee: Jakob Korherr
> Fix For: 2.0.2-SNAPSHOT
>
> Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for annotations. It must examine super classes. This is specificed in Java EE 6 specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch "Throwable" and ignore them. Otherwise, it throws error/s that are not catched and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider. Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by Werner Punz <we...@gmail.com>.
Am 16.09.10 16:47, schrieb Leonardo Uribe:
> Hi Werner
>
> It was a missing .toLowerCase on the function _Dom._isTableElement(). I
> already commit that one.
>
> regards ,
Thanks a lot Leo, thats exactly the only thing I was not testing in my
pre release testing.
Werner
Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by Jakob Korherr <ja...@gmail.com>.
You're welcome, guys :)
Looking forward to the 2.0.2 release now!
Regards,
Jakob
2010/9/16 Leonardo Uribe <lu...@gmail.com>:
> Hi Werner
>
> It was a missing .toLowerCase on the function _Dom._isTableElement(). I
> already commit that one.
>
> regards ,
>
> Leonardo
>
> 2010/9/16 Werner Punz <we...@gmail.com>
>>
>> Hi Leo which bug can you raise an issue, so that I can fix it?
>>
>> Werner
>>
>>
>> Am 16.09.10 16:27, schrieb Leonardo Uribe:
>>>
>>> Hi
>>>
>>> Yes, thanks a lot. Now it looks better. Yesterday I did all release
>>> procedure but doing some tests, I found a bug on the ajax part, so I had
>>> to rollback everything. I'll do another attempt to release next week.
>>>
>>> regards,
>>>
>>> Leonardo
>>>
>>> 2010/9/16 Werner Punz <werner.punz@gmail.com
>>> <ma...@gmail.com>>
>>>
>>> I guess Jakob has earned himself a big applause for fixing the
>>> problem so quickly, also from my side thank you.
>>>
>>> Werner
>>>
>>>
>>>
>>> Am 16.09.10 15:52, schrieb Gurkan Erdogdu:
>>>
>>> Problem has gone, thanks Jakob.
>>>
>>>
>>>
>>> ----- Original Message ----
>>> From: Jakob Korherr<jakob.korherr@gmail.com
>>> <ma...@gmail.com>>
>>> To: MyFaces Development<dev@myfaces.apache.org
>>> <ma...@myfaces.apache.org>>
>>> Sent: Thu, September 16, 2010 4:01:38 PM
>>> Subject: Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider
>>> Based Problems
>>> and Tomcat7 LifeCycleProvider Support
>>>
>>> Hi,
>>>
>>> I refactored the whole ManagedBeanDestroyer(-Listener) handling
>>> and
>>> now both cases work again (Werner tested his problem for me and I
>>> tested running a non-JSF application with MyFaces on the
>>> classpath).
>>> Furthermore @PreDestroy is also invoked properly.
>>>
>>> So now I think we can finally resolve this issue and move on
>>> with the
>>> 2.0.2 release!
>>>
>>> Regards,
>>> Jakob
>>>
>>> 2010/9/16 Werner Punz<werner.punz@gmail.com
>>> <ma...@gmail.com>>:
>>>
>>>
>>> Hi I have similar issues since the latest patch, I am
>>> getting an NPE here in
>>> a JSF App since today because it is losing the link to the
>>> servlet context
>>> when trying to set an attribute.
>>> Yesterday it worked and I quickly reverted to 2.0.1 there it
>>> also worked.
>>>
>>> java.lang.NullPointerException
>>> at
>>>
>>> org.apache.myfaces.context.servlet.ApplicationMap.getAttribute(ApplicationMap.java:47)
>>> )
>>> at
>>>
>>> org.apache.myfaces.util.AbstractThreadSafeAttributeMap.get(AbstractThreadSafeAttributeMap.java:90)
>>> )
>>> at
>>>
>>> org.apache.myfaces.config.annotation.DefaultLifecycleProviderFactory.getLifecycleProvider(DefaultLifecycleProviderFactory.java:62)
>>> )
>>> at
>>>
>>> org.apache.myfaces.config.ManagedBeanDestroyer.getCurrentLifecycleProvider(ManagedBeanDestroyer.java:195)
>>> )
>>> at
>>>
>>> org.apache.myfaces.config.ManagedBeanDestroyer.destroy(ManagedBeanDestroyer.java:153)
>>> )
>>> at
>>>
>>> org.apache.myfaces.webapp.ManagedBeanDestroyerListener.attributeReplaced(ManagedBeanDestroyerListener.java:183)
>>> )
>>> at
>>>
>>> org.apache.myfaces.webapp.StartupServletContextListener.attributeReplaced(StartupServletContextListener.java:286)
>>> )
>>> at
>>> org.mortbay.jetty.Request.setAttribute(Request.java:1356)
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.jsf.RequestMap.setAttribute(RequestMap.java:47)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:102)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:31)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.api.BaseWeaver.requestRefresh(BaseWeaver.java:303)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.core.CoreWeaver.requestRefresh(CoreWeaver.java:140)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.core.util.WeavingContext.doRequestRefreshes(WeavingContext.java:195)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter$1.run(ScriptingServletFilter.java:76)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter.doFilter(ScriptingServletFilter.java:65)
>>> )
>>> at
>>>
>>> org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1115)
>>> )
>>>
>>> So I assume it must have something to do with Leos latest
>>> commit in this
>>> area yesterday night. I have to say however this code is
>>> called from a
>>> servlet filter, so this might also play in, but nevertheless
>>> it used to work
>>> yesterday.
>>>
>>>
>>> Werner
>>>
>>>
>>>
>>> Am 16.09.10 12:29, schrieb Jakob Korherr:
>>>
>>>
>>> Yes, you're right, Gurkan.
>>>
>>> I reopened the issue, because this is a total
>>> showstopper for the 2.0.2
>>> release!
>>>
>>> Regards,
>>> Jakob
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>
>>
>
>
--
Jakob Korherr
blog: http://www.jakobk.com
twitter: http://twitter.com/jakobkorherr
work: http://www.irian.at
Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by Leonardo Uribe <lu...@gmail.com>.
Hi Werner
It was a missing .toLowerCase on the function _Dom._isTableElement(). I
already commit that one.
regards ,
Leonardo
2010/9/16 Werner Punz <we...@gmail.com>
> Hi Leo which bug can you raise an issue, so that I can fix it?
>
> Werner
>
>
> Am 16.09.10 16:27, schrieb Leonardo Uribe:
>
>> Hi
>>
>> Yes, thanks a lot. Now it looks better. Yesterday I did all release
>> procedure but doing some tests, I found a bug on the ajax part, so I had
>> to rollback everything. I'll do another attempt to release next week.
>>
>> regards,
>>
>> Leonardo
>>
>> 2010/9/16 Werner Punz <werner.punz@gmail.com <mailto:
>> werner.punz@gmail.com>>
>>
>>
>> I guess Jakob has earned himself a big applause for fixing the
>> problem so quickly, also from my side thank you.
>>
>> Werner
>>
>>
>>
>> Am 16.09.10 15:52, schrieb Gurkan Erdogdu:
>>
>> Problem has gone, thanks Jakob.
>>
>>
>>
>> ----- Original Message ----
>> From: Jakob Korherr<jakob.korherr@gmail.com
>> <ma...@gmail.com>>
>> To: MyFaces Development<dev@myfaces.apache.org
>> <ma...@myfaces.apache.org>>
>> Sent: Thu, September 16, 2010 4:01:38 PM
>> Subject: Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider
>> Based Problems
>> and Tomcat7 LifeCycleProvider Support
>>
>> Hi,
>>
>> I refactored the whole ManagedBeanDestroyer(-Listener) handling and
>> now both cases work again (Werner tested his problem for me and I
>> tested running a non-JSF application with MyFaces on the
>> classpath).
>> Furthermore @PreDestroy is also invoked properly.
>>
>> So now I think we can finally resolve this issue and move on
>> with the
>> 2.0.2 release!
>>
>> Regards,
>> Jakob
>>
>> 2010/9/16 Werner Punz<werner.punz@gmail.com
>> <ma...@gmail.com>>:
>>
>>
>>
>> Hi I have similar issues since the latest patch, I am
>> getting an NPE here in
>> a JSF App since today because it is losing the link to the
>> servlet context
>> when trying to set an attribute.
>> Yesterday it worked and I quickly reverted to 2.0.1 there it
>> also worked.
>>
>> java.lang.NullPointerException
>> at
>>
>> org.apache.myfaces.context.servlet.ApplicationMap.getAttribute(ApplicationMap.java:47)
>> )
>> at
>>
>> org.apache.myfaces.util.AbstractThreadSafeAttributeMap.get(AbstractThreadSafeAttributeMap.java:90)
>> )
>> at
>>
>> org.apache.myfaces.config.annotation.DefaultLifecycleProviderFactory.getLifecycleProvider(DefaultLifecycleProviderFactory.java:62)
>> )
>> at
>>
>> org.apache.myfaces.config.ManagedBeanDestroyer.getCurrentLifecycleProvider(ManagedBeanDestroyer.java:195)
>> )
>> at
>>
>> org.apache.myfaces.config.ManagedBeanDestroyer.destroy(ManagedBeanDestroyer.java:153)
>> )
>> at
>>
>> org.apache.myfaces.webapp.ManagedBeanDestroyerListener.attributeReplaced(ManagedBeanDestroyerListener.java:183)
>> )
>> at
>>
>> org.apache.myfaces.webapp.StartupServletContextListener.attributeReplaced(StartupServletContextListener.java:286)
>> )
>> at
>> org.mortbay.jetty.Request.setAttribute(Request.java:1356)
>> at
>>
>> org.apache.myfaces.extensions.scripting.jsf.RequestMap.setAttribute(RequestMap.java:47)
>> )
>> at
>>
>> org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:102)
>> )
>> at
>>
>> org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:31)
>> )
>> at
>>
>> org.apache.myfaces.extensions.scripting.api.BaseWeaver.requestRefresh(BaseWeaver.java:303)
>> )
>> at
>>
>> org.apache.myfaces.extensions.scripting.core.CoreWeaver.requestRefresh(CoreWeaver.java:140)
>> )
>> at
>>
>> org.apache.myfaces.extensions.scripting.core.util.WeavingContext.doRequestRefreshes(WeavingContext.java:195)
>> )
>> at
>>
>> org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter$1.run(ScriptingServletFilter.java:76)
>> )
>> at
>>
>> org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter.doFilter(ScriptingServletFilter.java:65)
>> )
>> at
>>
>> org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1115)
>> )
>>
>> So I assume it must have something to do with Leos latest
>> commit in this
>> area yesterday night. I have to say however this code is
>> called from a
>> servlet filter, so this might also play in, but nevertheless
>> it used to work
>> yesterday.
>>
>>
>> Werner
>>
>>
>>
>> Am 16.09.10 12:29, schrieb Jakob Korherr:
>>
>>
>> Yes, you're right, Gurkan.
>>
>> I reopened the issue, because this is a total
>> showstopper for the 2.0.2
>> release!
>>
>> Regards,
>> Jakob
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>
>
Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by Werner Punz <we...@gmail.com>.
Hi Leo which bug can you raise an issue, so that I can fix it?
Werner
Am 16.09.10 16:27, schrieb Leonardo Uribe:
> Hi
>
> Yes, thanks a lot. Now it looks better. Yesterday I did all release
> procedure but doing some tests, I found a bug on the ajax part, so I had
> to rollback everything. I'll do another attempt to release next week.
>
> regards,
>
> Leonardo
>
> 2010/9/16 Werner Punz <werner.punz@gmail.com <ma...@gmail.com>>
>
> I guess Jakob has earned himself a big applause for fixing the
> problem so quickly, also from my side thank you.
>
> Werner
>
>
>
> Am 16.09.10 15:52, schrieb Gurkan Erdogdu:
>
> Problem has gone, thanks Jakob.
>
>
>
> ----- Original Message ----
> From: Jakob Korherr<jakob.korherr@gmail.com
> <ma...@gmail.com>>
> To: MyFaces Development<dev@myfaces.apache.org
> <ma...@myfaces.apache.org>>
> Sent: Thu, September 16, 2010 4:01:38 PM
> Subject: Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider
> Based Problems
> and Tomcat7 LifeCycleProvider Support
>
> Hi,
>
> I refactored the whole ManagedBeanDestroyer(-Listener) handling and
> now both cases work again (Werner tested his problem for me and I
> tested running a non-JSF application with MyFaces on the classpath).
> Furthermore @PreDestroy is also invoked properly.
>
> So now I think we can finally resolve this issue and move on
> with the
> 2.0.2 release!
>
> Regards,
> Jakob
>
> 2010/9/16 Werner Punz<werner.punz@gmail.com
> <ma...@gmail.com>>:
>
>
> Hi I have similar issues since the latest patch, I am
> getting an NPE here in
> a JSF App since today because it is losing the link to the
> servlet context
> when trying to set an attribute.
> Yesterday it worked and I quickly reverted to 2.0.1 there it
> also worked.
>
> java.lang.NullPointerException
> at
> org.apache.myfaces.context.servlet.ApplicationMap.getAttribute(ApplicationMap.java:47)
> )
> at
> org.apache.myfaces.util.AbstractThreadSafeAttributeMap.get(AbstractThreadSafeAttributeMap.java:90)
> )
> at
> org.apache.myfaces.config.annotation.DefaultLifecycleProviderFactory.getLifecycleProvider(DefaultLifecycleProviderFactory.java:62)
> )
> at
> org.apache.myfaces.config.ManagedBeanDestroyer.getCurrentLifecycleProvider(ManagedBeanDestroyer.java:195)
> )
> at
> org.apache.myfaces.config.ManagedBeanDestroyer.destroy(ManagedBeanDestroyer.java:153)
> )
> at
> org.apache.myfaces.webapp.ManagedBeanDestroyerListener.attributeReplaced(ManagedBeanDestroyerListener.java:183)
> )
> at
> org.apache.myfaces.webapp.StartupServletContextListener.attributeReplaced(StartupServletContextListener.java:286)
> )
> at
> org.mortbay.jetty.Request.setAttribute(Request.java:1356)
> at
> org.apache.myfaces.extensions.scripting.jsf.RequestMap.setAttribute(RequestMap.java:47)
> )
> at
> org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:102)
> )
> at
> org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:31)
> )
> at
> org.apache.myfaces.extensions.scripting.api.BaseWeaver.requestRefresh(BaseWeaver.java:303)
> )
> at
> org.apache.myfaces.extensions.scripting.core.CoreWeaver.requestRefresh(CoreWeaver.java:140)
> )
> at
> org.apache.myfaces.extensions.scripting.core.util.WeavingContext.doRequestRefreshes(WeavingContext.java:195)
> )
> at
> org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter$1.run(ScriptingServletFilter.java:76)
> )
> at
> org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter.doFilter(ScriptingServletFilter.java:65)
> )
> at
> org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1115)
> )
>
> So I assume it must have something to do with Leos latest
> commit in this
> area yesterday night. I have to say however this code is
> called from a
> servlet filter, so this might also play in, but nevertheless
> it used to work
> yesterday.
>
>
> Werner
>
>
>
> Am 16.09.10 12:29, schrieb Jakob Korherr:
>
>
> Yes, you're right, Gurkan.
>
> I reopened the issue, because this is a total
> showstopper for the 2.0.2
> release!
>
> Regards,
> Jakob
>
>
>
>
>
>
>
>
>
>
Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by Leonardo Uribe <lu...@gmail.com>.
Hi
Yes, thanks a lot. Now it looks better. Yesterday I did all release
procedure but doing some tests, I found a bug on the ajax part, so I had to
rollback everything. I'll do another attempt to release next week.
regards,
Leonardo
2010/9/16 Werner Punz <we...@gmail.com>
> I guess Jakob has earned himself a big applause for fixing the problem so
> quickly, also from my side thank you.
>
> Werner
>
>
>
> Am 16.09.10 15:52, schrieb Gurkan Erdogdu:
>
> Problem has gone, thanks Jakob.
>>
>>
>>
>> ----- Original Message ----
>> From: Jakob Korherr<ja...@gmail.com>
>> To: MyFaces Development<de...@myfaces.apache.org>
>> Sent: Thu, September 16, 2010 4:01:38 PM
>> Subject: Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based
>> Problems
>> and Tomcat7 LifeCycleProvider Support
>>
>> Hi,
>>
>> I refactored the whole ManagedBeanDestroyer(-Listener) handling and
>> now both cases work again (Werner tested his problem for me and I
>> tested running a non-JSF application with MyFaces on the classpath).
>> Furthermore @PreDestroy is also invoked properly.
>>
>> So now I think we can finally resolve this issue and move on with the
>> 2.0.2 release!
>>
>> Regards,
>> Jakob
>>
>> 2010/9/16 Werner Punz<we...@gmail.com>:
>>
>>>
>>> Hi I have similar issues since the latest patch, I am getting an NPE here
>>> in
>>> a JSF App since today because it is losing the link to the servlet
>>> context
>>> when trying to set an attribute.
>>> Yesterday it worked and I quickly reverted to 2.0.1 there it also worked.
>>>
>>> java.lang.NullPointerException
>>> at
>>>
>>> org.apache.myfaces.context.servlet.ApplicationMap.getAttribute(ApplicationMap.java:47)
>>> )
>>> at
>>>
>>> org.apache.myfaces.util.AbstractThreadSafeAttributeMap.get(AbstractThreadSafeAttributeMap.java:90)
>>> )
>>> at
>>>
>>> org.apache.myfaces.config.annotation.DefaultLifecycleProviderFactory.getLifecycleProvider(DefaultLifecycleProviderFactory.java:62)
>>> )
>>> at
>>>
>>> org.apache.myfaces.config.ManagedBeanDestroyer.getCurrentLifecycleProvider(ManagedBeanDestroyer.java:195)
>>> )
>>> at
>>>
>>> org.apache.myfaces.config.ManagedBeanDestroyer.destroy(ManagedBeanDestroyer.java:153)
>>> )
>>> at
>>>
>>> org.apache.myfaces.webapp.ManagedBeanDestroyerListener.attributeReplaced(ManagedBeanDestroyerListener.java:183)
>>> )
>>> at
>>>
>>> org.apache.myfaces.webapp.StartupServletContextListener.attributeReplaced(StartupServletContextListener.java:286)
>>> )
>>> at org.mortbay.jetty.Request.setAttribute(Request.java:1356)
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.jsf.RequestMap.setAttribute(RequestMap.java:47)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:102)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:31)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.api.BaseWeaver.requestRefresh(BaseWeaver.java:303)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.core.CoreWeaver.requestRefresh(CoreWeaver.java:140)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.core.util.WeavingContext.doRequestRefreshes(WeavingContext.java:195)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter$1.run(ScriptingServletFilter.java:76)
>>> )
>>> at
>>>
>>> org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter.doFilter(ScriptingServletFilter.java:65)
>>> )
>>> at
>>>
>>> org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1115)
>>> )
>>>
>>> So I assume it must have something to do with Leos latest commit in this
>>> area yesterday night. I have to say however this code is called from a
>>> servlet filter, so this might also play in, but nevertheless it used to
>>> work
>>> yesterday.
>>>
>>>
>>> Werner
>>>
>>>
>>>
>>> Am 16.09.10 12:29, schrieb Jakob Korherr:
>>>
>>>>
>>>> Yes, you're right, Gurkan.
>>>>
>>>> I reopened the issue, because this is a total showstopper for the 2.0.2
>>>> release!
>>>>
>>>> Regards,
>>>> Jakob
>>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>
>
Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by Werner Punz <we...@gmail.com>.
I guess Jakob has earned himself a big applause for fixing the problem
so quickly, also from my side thank you.
Werner
Am 16.09.10 15:52, schrieb Gurkan Erdogdu:
> Problem has gone, thanks Jakob.
>
>
>
> ----- Original Message ----
> From: Jakob Korherr<ja...@gmail.com>
> To: MyFaces Development<de...@myfaces.apache.org>
> Sent: Thu, September 16, 2010 4:01:38 PM
> Subject: Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
> and Tomcat7 LifeCycleProvider Support
>
> Hi,
>
> I refactored the whole ManagedBeanDestroyer(-Listener) handling and
> now both cases work again (Werner tested his problem for me and I
> tested running a non-JSF application with MyFaces on the classpath).
> Furthermore @PreDestroy is also invoked properly.
>
> So now I think we can finally resolve this issue and move on with the
> 2.0.2 release!
>
> Regards,
> Jakob
>
> 2010/9/16 Werner Punz<we...@gmail.com>:
>>
>> Hi I have similar issues since the latest patch, I am getting an NPE here in
>> a JSF App since today because it is losing the link to the servlet context
>> when trying to set an attribute.
>> Yesterday it worked and I quickly reverted to 2.0.1 there it also worked.
>>
>> java.lang.NullPointerException
>> at
>> org.apache.myfaces.context.servlet.ApplicationMap.getAttribute(ApplicationMap.java:47)
>> )
>> at
>> org.apache.myfaces.util.AbstractThreadSafeAttributeMap.get(AbstractThreadSafeAttributeMap.java:90)
>> )
>> at
>> org.apache.myfaces.config.annotation.DefaultLifecycleProviderFactory.getLifecycleProvider(DefaultLifecycleProviderFactory.java:62)
>> )
>> at
>> org.apache.myfaces.config.ManagedBeanDestroyer.getCurrentLifecycleProvider(ManagedBeanDestroyer.java:195)
>> )
>> at
>> org.apache.myfaces.config.ManagedBeanDestroyer.destroy(ManagedBeanDestroyer.java:153)
>> )
>> at
>> org.apache.myfaces.webapp.ManagedBeanDestroyerListener.attributeReplaced(ManagedBeanDestroyerListener.java:183)
>> )
>> at
>> org.apache.myfaces.webapp.StartupServletContextListener.attributeReplaced(StartupServletContextListener.java:286)
>> )
>> at org.mortbay.jetty.Request.setAttribute(Request.java:1356)
>> at
>> org.apache.myfaces.extensions.scripting.jsf.RequestMap.setAttribute(RequestMap.java:47)
>> )
>> at
>> org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:102)
>> )
>> at
>> org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:31)
>> )
>> at
>> org.apache.myfaces.extensions.scripting.api.BaseWeaver.requestRefresh(BaseWeaver.java:303)
>> )
>> at
>> org.apache.myfaces.extensions.scripting.core.CoreWeaver.requestRefresh(CoreWeaver.java:140)
>> )
>> at
>> org.apache.myfaces.extensions.scripting.core.util.WeavingContext.doRequestRefreshes(WeavingContext.java:195)
>> )
>> at
>> org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter$1.run(ScriptingServletFilter.java:76)
>> )
>> at
>> org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter.doFilter(ScriptingServletFilter.java:65)
>> )
>> at
>> org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1115)
>> )
>>
>> So I assume it must have something to do with Leos latest commit in this
>> area yesterday night. I have to say however this code is called from a
>> servlet filter, so this might also play in, but nevertheless it used to work
>> yesterday.
>>
>>
>> Werner
>>
>>
>>
>> Am 16.09.10 12:29, schrieb Jakob Korherr:
>>>
>>> Yes, you're right, Gurkan.
>>>
>>> I reopened the issue, because this is a total showstopper for the 2.0.2
>>> release!
>>>
>>> Regards,
>>> Jakob
>>
>>
>>
>
>
>
Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
Posted by Gurkan Erdogdu <gu...@yahoo.com>.
Problem has gone, thanks Jakob.
----- Original Message ----
From: Jakob Korherr <ja...@gmail.com>
To: MyFaces Development <de...@myfaces.apache.org>
Sent: Thu, September 16, 2010 4:01:38 PM
Subject: Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Hi,
I refactored the whole ManagedBeanDestroyer(-Listener) handling and
now both cases work again (Werner tested his problem for me and I
tested running a non-JSF application with MyFaces on the classpath).
Furthermore @PreDestroy is also invoked properly.
So now I think we can finally resolve this issue and move on with the
2.0.2 release!
Regards,
Jakob
2010/9/16 Werner Punz <we...@gmail.com>:
>
> Hi I have similar issues since the latest patch, I am getting an NPE here in
> a JSF App since today because it is losing the link to the servlet context
> when trying to set an attribute.
> Yesterday it worked and I quickly reverted to 2.0.1 there it also worked.
>
> java.lang.NullPointerException
> at
>org.apache.myfaces.context.servlet.ApplicationMap.getAttribute(ApplicationMap.java:47)
>)
> at
>org.apache.myfaces.util.AbstractThreadSafeAttributeMap.get(AbstractThreadSafeAttributeMap.java:90)
>)
> at
>org.apache.myfaces.config.annotation.DefaultLifecycleProviderFactory.getLifecycleProvider(DefaultLifecycleProviderFactory.java:62)
>)
> at
>org.apache.myfaces.config.ManagedBeanDestroyer.getCurrentLifecycleProvider(ManagedBeanDestroyer.java:195)
>)
> at
>org.apache.myfaces.config.ManagedBeanDestroyer.destroy(ManagedBeanDestroyer.java:153)
>)
> at
>org.apache.myfaces.webapp.ManagedBeanDestroyerListener.attributeReplaced(ManagedBeanDestroyerListener.java:183)
>)
> at
>org.apache.myfaces.webapp.StartupServletContextListener.attributeReplaced(StartupServletContextListener.java:286)
>)
> at org.mortbay.jetty.Request.setAttribute(Request.java:1356)
> at
>org.apache.myfaces.extensions.scripting.jsf.RequestMap.setAttribute(RequestMap.java:47)
>)
> at
>org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:102)
>)
> at
>org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:31)
>)
> at
>org.apache.myfaces.extensions.scripting.api.BaseWeaver.requestRefresh(BaseWeaver.java:303)
>)
> at
>org.apache.myfaces.extensions.scripting.core.CoreWeaver.requestRefresh(CoreWeaver.java:140)
>)
> at
>org.apache.myfaces.extensions.scripting.core.util.WeavingContext.doRequestRefreshes(WeavingContext.java:195)
>)
> at
>org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter$1.run(ScriptingServletFilter.java:76)
>)
> at
>org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter.doFilter(ScriptingServletFilter.java:65)
>)
> at
>org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1115)
>)
>
> So I assume it must have something to do with Leos latest commit in this
> area yesterday night. I have to say however this code is called from a
> servlet filter, so this might also play in, but nevertheless it used to work
> yesterday.
>
>
> Werner
>
>
>
> Am 16.09.10 12:29, schrieb Jakob Korherr:
>>
>> Yes, you're right, Gurkan.
>>
>> I reopened the issue, because this is a total showstopper for the 2.0.2
>> release!
>>
>> Regards,
>> Jakob
>
>
>
--
Jakob Korherr
blog: http://www.jakobk.com
twitter: http://twitter.com/jakobkorherr
work: http://www.irian.at
Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by Jakob Korherr <ja...@gmail.com>.
Hi,
I refactored the whole ManagedBeanDestroyer(-Listener) handling and
now both cases work again (Werner tested his problem for me and I
tested running a non-JSF application with MyFaces on the classpath).
Furthermore @PreDestroy is also invoked properly.
So now I think we can finally resolve this issue and move on with the
2.0.2 release!
Regards,
Jakob
2010/9/16 Werner Punz <we...@gmail.com>:
>
> Hi I have similar issues since the latest patch, I am getting an NPE here in
> a JSF App since today because it is losing the link to the servlet context
> when trying to set an attribute.
> Yesterday it worked and I quickly reverted to 2.0.1 there it also worked.
>
> java.lang.NullPointerException
> at
> org.apache.myfaces.context.servlet.ApplicationMap.getAttribute(ApplicationMap.java:47)
> at
> org.apache.myfaces.util.AbstractThreadSafeAttributeMap.get(AbstractThreadSafeAttributeMap.java:90)
> at
> org.apache.myfaces.config.annotation.DefaultLifecycleProviderFactory.getLifecycleProvider(DefaultLifecycleProviderFactory.java:62)
> at
> org.apache.myfaces.config.ManagedBeanDestroyer.getCurrentLifecycleProvider(ManagedBeanDestroyer.java:195)
> at
> org.apache.myfaces.config.ManagedBeanDestroyer.destroy(ManagedBeanDestroyer.java:153)
> at
> org.apache.myfaces.webapp.ManagedBeanDestroyerListener.attributeReplaced(ManagedBeanDestroyerListener.java:183)
> at
> org.apache.myfaces.webapp.StartupServletContextListener.attributeReplaced(StartupServletContextListener.java:286)
> at org.mortbay.jetty.Request.setAttribute(Request.java:1356)
> at
> org.apache.myfaces.extensions.scripting.jsf.RequestMap.setAttribute(RequestMap.java:47)
> at
> org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:102)
> at
> org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:31)
> at
> org.apache.myfaces.extensions.scripting.api.BaseWeaver.requestRefresh(BaseWeaver.java:303)
> at
> org.apache.myfaces.extensions.scripting.core.CoreWeaver.requestRefresh(CoreWeaver.java:140)
> at
> org.apache.myfaces.extensions.scripting.core.util.WeavingContext.doRequestRefreshes(WeavingContext.java:195)
> at
> org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter$1.run(ScriptingServletFilter.java:76)
> at
> org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter.doFilter(ScriptingServletFilter.java:65)
> at
> org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1115)
>
> So I assume it must have something to do with Leos latest commit in this
> area yesterday night. I have to say however this code is called from a
> servlet filter, so this might also play in, but nevertheless it used to work
> yesterday.
>
>
> Werner
>
>
>
> Am 16.09.10 12:29, schrieb Jakob Korherr:
>>
>> Yes, you're right, Gurkan.
>>
>> I reopened the issue, because this is a total showstopper for the 2.0.2
>> release!
>>
>> Regards,
>> Jakob
>
>
>
--
Jakob Korherr
blog: http://www.jakobk.com
twitter: http://twitter.com/jakobkorherr
work: http://www.irian.at
Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by Werner Punz <we...@gmail.com>.
Hi I have similar issues since the latest patch, I am getting an NPE
here in a JSF App since today because it is losing the link to the
servlet context when trying to set an attribute.
Yesterday it worked and I quickly reverted to 2.0.1 there it also worked.
java.lang.NullPointerException
at
org.apache.myfaces.context.servlet.ApplicationMap.getAttribute(ApplicationMap.java:47)
at
org.apache.myfaces.util.AbstractThreadSafeAttributeMap.get(AbstractThreadSafeAttributeMap.java:90)
at
org.apache.myfaces.config.annotation.DefaultLifecycleProviderFactory.getLifecycleProvider(DefaultLifecycleProviderFactory.java:62)
at
org.apache.myfaces.config.ManagedBeanDestroyer.getCurrentLifecycleProvider(ManagedBeanDestroyer.java:195)
at
org.apache.myfaces.config.ManagedBeanDestroyer.destroy(ManagedBeanDestroyer.java:153)
at
org.apache.myfaces.webapp.ManagedBeanDestroyerListener.attributeReplaced(ManagedBeanDestroyerListener.java:183)
at
org.apache.myfaces.webapp.StartupServletContextListener.attributeReplaced(StartupServletContextListener.java:286)
at org.mortbay.jetty.Request.setAttribute(Request.java:1356)
at
org.apache.myfaces.extensions.scripting.jsf.RequestMap.setAttribute(RequestMap.java:47)
at
org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:102)
at
org.apache.myfaces.extensions.scripting.jsf.AbstractThreadSafeAttributeMap.put(AbstractThreadSafeAttributeMap.java:31)
at
org.apache.myfaces.extensions.scripting.api.BaseWeaver.requestRefresh(BaseWeaver.java:303)
at
org.apache.myfaces.extensions.scripting.core.CoreWeaver.requestRefresh(CoreWeaver.java:140)
at
org.apache.myfaces.extensions.scripting.core.util.WeavingContext.doRequestRefreshes(WeavingContext.java:195)
at
org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter$1.run(ScriptingServletFilter.java:76)
at
org.apache.myfaces.extensions.scripting.servlet.ScriptingServletFilter.doFilter(ScriptingServletFilter.java:65)
at
org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1115)
So I assume it must have something to do with Leos latest commit in this
area yesterday night. I have to say however this code is called from a
servlet filter, so this might also play in, but nevertheless it used to
work yesterday.
Werner
Am 16.09.10 12:29, schrieb Jakob Korherr:
> Yes, you're right, Gurkan.
>
> I reopened the issue, because this is a total showstopper for the 2.0.2 release!
>
> Regards,
> Jakob
Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by Jakob Korherr <ja...@gmail.com>.
Yes, you're right, Gurkan.
I reopened the issue, because this is a total showstopper for the 2.0.2 release!
Regards,
Jakob
2010/9/16 Gurkan Erdogdu <gu...@yahoo.com>:
> I think problem is that for non JSF applications, factories are not configured.
> Therefore in ManagedBeanDestroyerListener # contextInitialized
>
>
> facesContext.getApplication().subscribeToEvent(PreDestroyCustomScopeEvent.class,
> destroyer);
>
> facesContext.getApplication().subscribeToEvent(PreDestroyViewMapEvent.class,
> destroyer);
>
>
> facesContext.getApplication() throws below exception,
>
>
>
> ----- Original Message ----
> From: Gurkan Erdogdu <gu...@yahoo.com>
> To: MyFaces Development <de...@myfaces.apache.org>
> Sent: Thu, September 16, 2010 10:58:59 AM
> Subject: Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
> and Tomcat7 LifeCycleProvider Support
>
> After applying latest changes and build trunk, I am getting exception when
> deploying non JSF based web application
>
>
> SEVERE: Exception sending context initialized event to listener instance of
> class org.apache.myfaces.webapp.StartupServletContextListener
> java.lang.IllegalStateException: No Factories configured for this Application.
> This happens if the faces-initialization does not work at all - make sure that
> you properly include all configuration settings necessary for a basic faces
> application and that all the necessary libs are included. Also check the logging
>
> output of your web application and your container for any exceptions!
> If you did that and find nothing, the mistake might be due to the fact that you
> use some special web-containers which do not support registering
> context-listeners via TLD files and a context listener is not setup in your
> web.xml.
> A typical config looks like this;
> <listener>
>
> <listener-class>org.apache.myfaces.webapp.StartupServletContextListener</listener-class>
>
>
> </listener>
>
> · at javax.faces.FactoryFinder.getFactory(FactoryFinder.java:172)
> · at
> org.apache.myfaces.context.servlet.FacesContextImplBase.getApplication(FacesContextImplBase.java:131)
>
>
> · at
> org.apache.myfaces.webapp.ManagedBeanDestroyerListener.contextInitialized(ManagedBeanDestroyerListener.java:143)
>
>
> · at
> org.apache.myfaces.webapp.StartupServletContextListener.contextInitialized(StartupServletContextListener.java:111)
>
>
> · at
> org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4323)
>
>
> · at
> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:4780)
>
>
> ..................
> ..................
>
>
>
> ----- Original Message ----
> From: Leonardo Uribe (JIRA) <de...@myfaces.apache.org>
> To: dev@myfaces.apache.org
> Sent: Thu, September 16, 2010 3:35:33 AM
> Subject: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems and
> Tomcat7 LifeCycleProvider Support
>
>
> [
> https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>
> ]
>
> Leonardo Uribe resolved MYFACES-2919.
> -------------------------------------
>
> Resolution: Fixed
>
> Revert the point when exceptions are swallowed and add a log message there is
> not necessary, because the related code is only for check if tomcat 6 is
> available. Now, DefaultLifecycleProviderFactory uses one LifecycleProvider per
> webapp. It was also necessary other fixes like register ManagedBeanDestroyer on
> a proper location (that code should be on ManagedBeanDestroyerListener, not on
> FacesConfigurator)
>
>> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
>> ----------------------------------------------------------------------
>>
>> Key: MYFACES-2919
>> URL: https://issues.apache.org/jira/browse/MYFACES-2919
>> Project: MyFaces Core
>> Issue Type: Bug
>> Reporter: Gurkan Erdogdu
>> Assignee: Jakob Korherr
>> Fix For: 2.0.2-SNAPSHOT
>>
>> Attachments: MYFACES-2919-2.patch, patch.txt
>>
>>
>> Patch content
>> ----------------------
>> 1- ResourceAnnotationLifecycleProvider : It does not check super class for
>>annotations. It must examine super classes. This is specificed in Java EE 6
>>specification, EE 5.2.5 Annotations and Injections.
>> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch
>>"Throwable" and ignore them. Otherwise, it throws error/s that are not catched
>>and calling code is not able to process other lifecycle providers.
>> 3- StartupServletContextListener : Early initiliazation of lifecycle provider.
>
>>Otherwise, it is not possible to use META-INF/services providers.
>> 4- pom.xml : Adding Tomcat 7 libs.
>> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider
>>implementation.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
>
--
Jakob Korherr
blog: http://www.jakobk.com
twitter: http://twitter.com/jakobkorherr
work: http://www.irian.at
Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
Posted by Gurkan Erdogdu <gu...@yahoo.com>.
I think problem is that for non JSF applications, factories are not configured.
Therefore in ManagedBeanDestroyerListener # contextInitialized
facesContext.getApplication().subscribeToEvent(PreDestroyCustomScopeEvent.class,
destroyer);
facesContext.getApplication().subscribeToEvent(PreDestroyViewMapEvent.class,
destroyer);
facesContext.getApplication() throws below exception,
----- Original Message ----
From: Gurkan Erdogdu <gu...@yahoo.com>
To: MyFaces Development <de...@myfaces.apache.org>
Sent: Thu, September 16, 2010 10:58:59 AM
Subject: Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
After applying latest changes and build trunk, I am getting exception when
deploying non JSF based web application
SEVERE: Exception sending context initialized event to listener instance of
class org.apache.myfaces.webapp.StartupServletContextListener
java.lang.IllegalStateException: No Factories configured for this Application.
This happens if the faces-initialization does not work at all - make sure that
you properly include all configuration settings necessary for a basic faces
application and that all the necessary libs are included. Also check the logging
output of your web application and your container for any exceptions!
If you did that and find nothing, the mistake might be due to the fact that you
use some special web-containers which do not support registering
context-listeners via TLD files and a context listener is not setup in your
web.xml.
A typical config looks like this;
<listener>
<listener-class>org.apache.myfaces.webapp.StartupServletContextListener</listener-class>
</listener>
· at javax.faces.FactoryFinder.getFactory(FactoryFinder.java:172)
· at
org.apache.myfaces.context.servlet.FacesContextImplBase.getApplication(FacesContextImplBase.java:131)
· at
org.apache.myfaces.webapp.ManagedBeanDestroyerListener.contextInitialized(ManagedBeanDestroyerListener.java:143)
· at
org.apache.myfaces.webapp.StartupServletContextListener.contextInitialized(StartupServletContextListener.java:111)
· at
org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4323)
· at
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:4780)
..................
..................
----- Original Message ----
From: Leonardo Uribe (JIRA) <de...@myfaces.apache.org>
To: dev@myfaces.apache.org
Sent: Thu, September 16, 2010 3:35:33 AM
Subject: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems and
Tomcat7 LifeCycleProvider Support
[
https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe resolved MYFACES-2919.
-------------------------------------
Resolution: Fixed
Revert the point when exceptions are swallowed and add a log message there is
not necessary, because the related code is only for check if tomcat 6 is
available. Now, DefaultLifecycleProviderFactory uses one LifecycleProvider per
webapp. It was also necessary other fixes like register ManagedBeanDestroyer on
a proper location (that code should be on ManagedBeanDestroyerListener, not on
FacesConfigurator)
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Gurkan Erdogdu
> Assignee: Jakob Korherr
> Fix For: 2.0.2-SNAPSHOT
>
> Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for
>annotations. It must examine super classes. This is specificed in Java EE 6
>specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch
>"Throwable" and ignore them. Otherwise, it throws error/s that are not catched
>and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider.
>Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider
>implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
Posted by Gurkan Erdogdu <gu...@yahoo.com>.
After applying latest changes and build trunk, I am getting exception when
deploying non JSF based web application
SEVERE: Exception sending context initialized event to listener instance of
class org.apache.myfaces.webapp.StartupServletContextListener
java.lang.IllegalStateException: No Factories configured for this Application.
This happens if the faces-initialization does not work at all - make sure that
you properly include all configuration settings necessary for a basic faces
application and that all the necessary libs are included. Also check the logging
output of your web application and your container for any exceptions!
If you did that and find nothing, the mistake might be due to the fact that you
use some special web-containers which do not support registering
context-listeners via TLD files and a context listener is not setup in your
web.xml.
A typical config looks like this;
<listener>
<listener-class>org.apache.myfaces.webapp.StartupServletContextListener</listener-class>
</listener>
· at javax.faces.FactoryFinder.getFactory(FactoryFinder.java:172)
· at
org.apache.myfaces.context.servlet.FacesContextImplBase.getApplication(FacesContextImplBase.java:131)
· at
org.apache.myfaces.webapp.ManagedBeanDestroyerListener.contextInitialized(ManagedBeanDestroyerListener.java:143)
· at
org.apache.myfaces.webapp.StartupServletContextListener.contextInitialized(StartupServletContextListener.java:111)
· at
org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4323)
· at
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:4780)
..................
..................
----- Original Message ----
From: Leonardo Uribe (JIRA) <de...@myfaces.apache.org>
To: dev@myfaces.apache.org
Sent: Thu, September 16, 2010 3:35:33 AM
Subject: [jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems and
Tomcat7 LifeCycleProvider Support
[
https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe resolved MYFACES-2919.
-------------------------------------
Resolution: Fixed
Revert the point when exceptions are swallowed and add a log message there is
not necessary, because the related code is only for check if tomcat 6 is
available. Now, DefaultLifecycleProviderFactory uses one LifecycleProvider per
webapp. It was also necessary other fixes like register ManagedBeanDestroyer on
a proper location (that code should be on ManagedBeanDestroyerListener, not on
FacesConfigurator)
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Gurkan Erdogdu
> Assignee: Jakob Korherr
> Fix For: 2.0.2-SNAPSHOT
>
> Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for
>annotations. It must examine super classes. This is specificed in Java EE 6
>specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch
>"Throwable" and ignore them. Otherwise, it throws error/s that are not catched
>and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider.
>Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider
>implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved MYFACES-2919.
-------------------------------------
Resolution: Fixed
Revert the point when exceptions are swallowed and add a log message there is not necessary, because the related code is only for check if tomcat 6 is available. Now, DefaultLifecycleProviderFactory uses one LifecycleProvider per webapp. It was also necessary other fixes like register ManagedBeanDestroyer on a proper location (that code should be on ManagedBeanDestroyerListener, not on FacesConfigurator)
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Gurkan Erdogdu
> Assignee: Jakob Korherr
> Fix For: 2.0.2-SNAPSHOT
>
> Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for annotations. It must examine super classes. This is specificed in Java EE 6 specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch "Throwable" and ignore them. Otherwise, it throws error/s that are not catched and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider. Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr reopened MYFACES-2919:
------------------------------------
The applied changes chause problems with non-JSF applications.
>From Gurkan:
After applying latest changes and build trunk, I am getting exception when
deploying non JSF based web application
SEVERE: Exception sending context initialized event to listener instance of
class org.apache.myfaces.webapp.StartupServletContextListener
java.lang.IllegalStateException: No Factories configured for this Application.
This happens if the faces-initialization does not work at all - make sure that
you properly include all configuration settings necessary for a basic faces
application and that all the necessary libs are included. Also check the logging
output of your web application and your container for any exceptions!
If you did that and find nothing, the mistake might be due to the fact that you
use some special web-containers which do not support registering
context-listeners via TLD files and a context listener is not setup in your
web.xml.
A typical config looks like this;
<listener>
<listener-class>org.apache.myfaces.webapp.StartupServletContextListener</listener-class>
</listener>
- at javax.faces.FactoryFinder.getFactory(FactoryFinder.java:172)
- at
org.apache.myfaces.context.servlet.FacesContextImplBase.getApplication(FacesContextImplBase.java:131)
- at
org.apache.myfaces.webapp.ManagedBeanDestroyerListener.contextInitialized(ManagedBeanDestroyerListener.java:143)
- at
org.apache.myfaces.webapp.StartupServletContextListener.contextInitialized(StartupServletContextListener.java:111)
- at
org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4323)
- at
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:4780)
This is a total showstopper for the 2.0.2 release!
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Gurkan Erdogdu
> Assignee: Jakob Korherr
> Fix For: 2.0.2
>
> Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for annotations. It must examine super classes. This is specificed in Java EE 6 specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch "Throwable" and ignore them. Otherwise, it throws error/s that are not catched and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider. Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2919) LifecycleProvider Based Problems and
Tomcat7 LifeCycleProvider Support
Posted by "Gurkan Erdogdu (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gurkan Erdogdu updated MYFACES-2919:
------------------------------------
Status: Patch Available (was: Open)
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Gurkan Erdogdu
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for annotations. It must examine super classes. This is specificed in Java EE 6 specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch "Throwable" and ignore them. Otherwise, it throws error/s that are not catched and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider. Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by "Gurkan Erdogdu (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909401#action_12909401 ]
Gurkan Erdogdu commented on MYFACES-2919:
-----------------------------------------
Thanks Jakob, go for it, patch is looking good.
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Gurkan Erdogdu
> Assignee: Jakob Korherr
> Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for annotations. It must examine super classes. This is specificed in Java EE 6 specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch "Throwable" and ignore them. Otherwise, it throws error/s that are not catched and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider. Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (MYFACES-2919) LifecycleProvider Based Problems
and Tomcat7 LifeCycleProvider Support
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe reopened MYFACES-2919:
-------------------------------------
I have some questions about this patch:
1. Why some code has changed to swallow all Throwable exceptions? If we change it to have one LifecycleProvider per webapp it is not valid the argument proposed.
2. What will happen in a Tomcat 6 environment since we changed the entry on META-INF/services?
3. Why there was uncommented some code on ResourceAnnotationLifecycleProvider?
This issue is preventing me for do a release, and in my opinion we should revert it and examine more carefully the consequences of the same. There are too many questions left and we need to check them one by one.
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Gurkan Erdogdu
> Assignee: Jakob Korherr
> Fix For: 2.0.2-SNAPSHOT
>
> Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for annotations. It must examine super classes. This is specificed in Java EE 6 specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch "Throwable" and ignore them. Otherwise, it throws error/s that are not catched and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider. Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.