You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "jay vyas (JIRA)" <ji...@apache.org> on 2014/11/12 06:34:33 UTC
[jira] [Comment Edited] (BIGTOP-1524) FailureExecutor breaks smoke
tests
[ https://issues.apache.org/jira/browse/BIGTOP-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207710#comment-14207710 ]
jay vyas edited comment on BIGTOP-1524 at 11/12/14 5:34 AM:
------------------------------------------------------------
okay ! heres a patch to upgrade {{smoke-tests}} so that they work again. There were *a bug* in the Failure Executor that needed to be patched, and also, i needed to add source dependencies on itest (so that the Failure executor classes are available).
- There was a minor bug in FailureExecutor which caused booleans to be parsed as "true" on accident .
- This fixes that, and also updates the smoke-tests.sh script in vagrant recipe to run clean before testing.
- Finally, it also adds iTest to the source path, so that smoke tests (for mapreduce) no longer require an ITest jar.
Later we can upgrade all smokes to run from HEAD, but for now, this is the minimal patch to fix the problem.
looks okay ?
was (Author: jayunit100):
okay ! heres a patch to upgrade {{smoke-tests}} so that they work.
- There was a minor bug in FailureExecutor which caused booleans to be parsed as "true" on accident .
- This fixes that, and also updates the smoke-tests.sh script in vagrant recipe to run clean before testing.
- Finally, it also adds iTest to the source path, so that smoke tests (for mapreduce) no longer require an ITest jar.
Later we can upgrade all smokes to run from HEAD, but for now, this is the minimal patch to fix the problem.
looks okay ?
> FailureExecutor breaks smoke tests
> ------------------------------------
>
> Key: BIGTOP-1524
> URL: https://issues.apache.org/jira/browse/BIGTOP-1524
> Project: Bigtop
> Issue Type: Bug
> Components: tests
> Reporter: jay vyas
> Fix For: 0.9.0
>
> Attachments: BIGTOP-1524.patch
>
>
> Duh : By adding a hard requirement on itest-snapshot-0.9.0, we now break the existing mapreduce smoke tests.
> Maybe i can add ITest as a compiled, rather than jar file, dependency for {{smoke-tests}} . let me look into it
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)