[jira] Commented: (ASYNCWEB-4) caller supplied content is ignored, and some request headers may be added twice

["Mike Heath (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ASYNCWEB-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568791#action_12568791 ] 

Mike Heath commented on ASYNCWEB-4:
-----------------------------------

Is this still an issue in the AsyncWeb common codec?

> caller supplied content is ignored, and some request headers may be added twice
> -------------------------------------------------------------------------------
>
>                 Key: ASYNCWEB-4
>                 URL: https://issues.apache.org/jira/browse/ASYNCWEB-4
>             Project: Asyncweb
>          Issue Type: Bug
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>         Attachments: ASYNCWEB-4.patch, GERONIMO-3839-v2.patch, GERONIMO-3839.patch
>
>
> Some request headers get special treatment by HttpRequestEncoder.  HttpRequestEncoder does not make any effort in checking to see if they are present in the headers already.  As a result, they may be added twice if one is not careful.  For example,
> - Content-Type & Content-Length are added by HttpRequestEncoder for POST requests, and should not be added by callers.
> - Host & User-Agent are always added by HttpRequestEncoder, and should not be added by callers as ordinary headers.
> Although one could argue that callers should not add these headers by hand, I think HttpRequestEncoder still should ensure that they are not added twice.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.