You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/04/29 01:40:20 UTC

[GitHub] [iotdb] zjx1230 commented on a diff in pull request #5710: Add SyncThriftClientErrorHandler for proxy to clean the code

zjx1230 commented on code in PR #5710:
URL: https://github.com/apache/iotdb/pull/5710#discussion_r861415057


##########
node-commons/src/main/java/org/apache/iotdb/commons/client/ClientManager.java:
##########
@@ -56,7 +56,9 @@ public V borrowClient(K node) throws IOException {
       throw e;
     } catch (Exception e) {
       // external doesn't care of other exceptions
-      logger.error(String.format("Borrow client from pool for node %s failed.", node), e);
+      String errorMessage = String.format("Borrow client from pool for node %s failed.", node);
+      logger.error(errorMessage, e);
+      throw new IOException(errorMessage, e);

Review Comment:
   Do you want me to try to remove all the relevant null judgment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org