[jira] [Commented] (CB-11636) Merging config.xml w/ attributes containing " fails.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-11636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403095#comment-15403095 ] 

ASF GitHub Bot commented on CB-11636:
-------------------------------------

Github user stevengill commented on the issue:

    https://github.com/apache/cordova-lib/pull/470
  
    LGTM


> Merging config.xml w/ attributes containing " fails.
> ---------------------------------------------------------
>
>                 Key: CB-11636
>                 URL: https://issues.apache.org/jira/browse/CB-11636
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaCommon
>    Affects Versions: 1.4.0
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>              Labels: reproduced, triaged, xml
>             Fix For: 1.4.1
>
>
> Repro steps:
> - Create an empty project
> - Add {{<preference name="name" value="my &quot;quoted&quot; value">}} to config.xml (notice that JIRA replaces &quot; by " symbol)
> - Add any of ios, windows or android platform
> - Call {{cordova prepare}}
> Expected:
> prepare succeds and preference copied to platform's config.xml
> Actual:
> prepare fails with unrelevant stacktrace:
> {noformat}
> No scripts found for hook "before_prepare".
> Checking config.xml for saved platforms that haven't been added to the project
> Checking for any plugins added to the project that have not been installed in android platform
> No differences found between plugins added to project and installed in android platform. Continuing...
> Generating config.xml from defaults for platform "android"
> net.js:647
>     throw new TypeError(
>     ^
> TypeError: Invalid data, chunk must be a string or buffer, not undefined
>     at WriteStream.Socket.write (net.js:647:11)
>     at WriteStream.stream.write (D:\cordova\cordova-lib\cordova-common\node_modules\ansi\lib\newlines.js:36:21)
>     at Cursor.write (D:\cordova\cordova-lib\cordova-common\node_modules\ansi\lib\ansi.js:157:23)
>     at CordovaLogger.log (D:\cordova\cordova-lib\cordova-common\src\CordovaLogger.js:102:12)
>     at process.<anonymous> (D:\cordova\cordova-cli\src\cli.js:253:16)
>     at emitOne (events.js:96:13)
>     at process.emit (events.js:188:7)
>     at process._fatalException (bootstrap_node.js:254:26)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org