You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/05/28 05:14:56 UTC
[GitHub] flink pull request #6086: [FLINK-9452] Flink 1.5 document version title show...
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6086
[FLINK-9452] Flink 1.5 document version title shows snapshot
## What is the purpose of the change
*This pull request fixed 1.5 document version title*
## Brief change log
- *Removed 1.5-SNAPSHOT to 1.5 version*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-9452
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6086.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6086
----
commit 5fff20437db9bef05a8fde0ec5615c071ed4ee47
Author: yanghua <ya...@...>
Date: 2018-05-28T05:11:29Z
[FLINK-9452] Flink 1.5 document version title shows snapshot
----
---
[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6086
@alpinegizmo nice catch!
---
[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6086
cc @tillrohrmann @zentol
---
[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...
Posted by alpinegizmo <gi...@git.apache.org>.
Github user alpinegizmo commented on the issue:
https://github.com/apache/flink/pull/6086
@zentol I think the baseurl variable also needs to be changed -- for a stable release, it should not point to master.
---
[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6086
will fix things while merging...
---
[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6086
ok, closing...
---
[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6086
merged, @yanghua please close the PR. Thanks!
---
[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6086
@zentol I have tried to switch to release-1.5 and fix it, but it seems in release-1.5 branch, I can not send a PR correctly, the PR will contains many changes.
---
[GitHub] flink pull request #6086: [FLINK-9452] Flink 1.5 document version title show...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/6086
---