You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/11/25 15:16:13 UTC
[jira] [Commented] (ACTIVEMQ6-42) Fix FORCED_DELIVERY_MESSAGE
dependent on hornetq naming
[ https://issues.apache.org/jira/browse/ACTIVEMQ6-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224579#comment-14224579 ]
ASF GitHub Bot commented on ACTIVEMQ6-42:
-----------------------------------------
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-6/pull/24
ACTIVEMQ6-42 Fix FORCED_DELIVERY_MESSAGE dependent on hornetq naming
When dealing with receiveNoWait messages, a special message with
a property called _activemq.forced.delivery.seq is being sent.
This property used to be _hornetq.forced.delivery.seq. In order
to be compatible with 'old' hornetq clients, this fix does the
following:
1. Determine the client type of a client during protocol handshake
phase of a connection. New clients will connect with a 'ACTIVEMQ'
and old clients will do with either 'HORNETQ' or nothing.
2. The clien types are identified by a new enum type ClientType.
It has two values 'AMQ' (new clients) and 'HQ' (old ones).
3. When a forced delivery is being sent, put a proper property
to the special message based on the client type. If it is 'AMQ'
client, use _activemq.forced.delivery.seq, if it is 'HQ' use
_hornetq_forced.delivery.seq.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward/activemq-6 master_amq_64
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-6/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit afe55861300d60eceeedd34eb95fe6a0da43ce4a
Author: Howard Gao <hg...@redhat.com>
Date: 2014-11-25T13:40:48Z
ACTIVEMQ6-42 Fix FORCED_DELIVERY_MESSAGE dependent on hornetq naming
When dealing with receiveNoWait messages, a special message with
a property called _activemq.forced.delivery.seq is being sent.
This property used to be _hornetq.forced.delivery.seq. In order
to be compatible with 'old' hornetq clients, this fix does the
following:
1. Determine the client type of a client during protocol handshake
phase of a connection. New clients will connect with a 'ACTIVEMQ'
and old clients will do with either 'HORNETQ' or nothing.
2. The clien types are identified by a new enum type ClientType.
It has two values 'AMQ' (new clients) and 'HQ' (old ones).
3. When a forced delivery is being sent, put a proper property
to the special message based on the client type. If it is 'AMQ'
client, use _activemq.forced.delivery.seq, if it is 'HQ' use
_hornetq_forced.delivery.seq.
----
> Fix FORCED_DELIVERY_MESSAGE dependent on hornetq naming
> -------------------------------------------------------
>
> Key: ACTIVEMQ6-42
> URL: https://issues.apache.org/jira/browse/ACTIVEMQ6-42
> Project: Apache ActiveMQ 6
> Issue Type: Sub-task
> Reporter: clebert suconic
> Assignee: Howard Gao
> Priority: Critical
> Fix For: 6.0.0
>
>
> When dealing with receiveNoWait messages, core clients are sending a special message with a property called _hornetq.forced.delivery.seq
> We intend to keep the wire protocol compatible with old hornetq clients so we may have to do some smarts on ACTIVEMQ6-8 to support the proper name here (either _hornetq or _activemq).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)