You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2015/12/23 17:13:22 UTC

Review Request 41692: Improve config recommendations flow

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41692/
-----------------------------------------------------------

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-14483
    https://issues.apache.org/jira/browse/AMBARI-14483


Repository: ambari


Description
-------

For now config recommendations may take more time that it should due to not perfect code. Need to make refactor to improve performance


Diffs
-----

  ambari-web/app/controllers/main/service/info/configs.js c59bd9120dacc066554c329116b61fd787a51699 
  ambari-web/app/controllers/wizard/step7_controller.js 608b163a02b70d915cd1af2cd9b6480e389ad98d 
  ambari-web/app/mixins/common/configs/enhanced_configs.js 230493bda87de25698807b6cdb171695c39f65cc 
  ambari-web/app/mixins/common/serverValidator.js 0306a9707ec366edd7f0ecd2093a42fcc2800c68 
  ambari-web/app/utils/config.js df92ebec1a33af51428f4d466ef1040dcc3c6094 
  ambari-web/app/views/common/controls_view.js 26441922ec3450a5ab1fd916f124303f63a9e3eb 
  ambari-web/app/views/common/modal_popups/dependent_configs_list_popup.js 684598e0d00fd5bd8f9e0ee881e9a68bbe6e8902 

Diff: https://reviews.apache.org/r/41692/diff/


Testing
-------

11748 tests complete (10 seconds)
137 tests pending


Thanks,

Andriy Babiichuk

Re: Review Request 41692: Improve config recommendations flow

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41692/#review111851
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On Dec. 23, 2015, 4:13 p.m., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41692/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2015, 4:13 p.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-14483
>     https://issues.apache.org/jira/browse/AMBARI-14483
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> For now config recommendations may take more time that it should due to not perfect code. Need to make refactor to improve performance
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/info/configs.js c59bd9120dacc066554c329116b61fd787a51699 
>   ambari-web/app/controllers/wizard/step7_controller.js 608b163a02b70d915cd1af2cd9b6480e389ad98d 
>   ambari-web/app/mixins/common/configs/enhanced_configs.js 230493bda87de25698807b6cdb171695c39f65cc 
>   ambari-web/app/mixins/common/serverValidator.js 0306a9707ec366edd7f0ecd2093a42fcc2800c68 
>   ambari-web/app/utils/config.js df92ebec1a33af51428f4d466ef1040dcc3c6094 
>   ambari-web/app/views/common/controls_view.js 26441922ec3450a5ab1fd916f124303f63a9e3eb 
>   ambari-web/app/views/common/modal_popups/dependent_configs_list_popup.js 684598e0d00fd5bd8f9e0ee881e9a68bbe6e8902 
> 
> Diff: https://reviews.apache.org/r/41692/diff/
> 
> 
> Testing
> -------
> 
> 11748 tests complete (10 seconds)
> 137 tests pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>