You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/23 17:17:25 UTC
[GitHub] [nifi] alopresto opened a new pull request #4228: NIFI-7122 Introduce new KDFs and encryption metadata attributes to EncryptContent processor
alopresto opened a new pull request #4228:
URL: https://github.com/apache/nifi/pull/4228
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_This PR allows the `EncryptContent` processor to use the new Argon2 KDF, fixes a legacy issue in the Bcrypt KDF (with backward compatibility), introduces encryption metadata attributes to flowfiles encrypted/decrypted by `EncryptContent` (also completing NIFI-3889), and improves the custom validation in the processor._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on pull request #4228: NIFI-7122 Introduce new KDFs and encryption metadata attributes to EncryptContent processor
Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4228:
URL: https://github.com/apache/nifi/pull/4228#issuecomment-648405432
The compilation errors in the CI/CD checks are odd; the previous (non-merge commit aee2fce) has all four checks passing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto closed pull request #4228: NIFI-7122 Introduce new KDFs and encryption metadata attributes to EncryptContent processor
Posted by GitBox <gi...@apache.org>.
alopresto closed pull request #4228:
URL: https://github.com/apache/nifi/pull/4228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto edited a comment on pull request #4228: NIFI-7122 Introduce new KDFs and encryption metadata attributes to EncryptContent processor
Posted by GitBox <gi...@apache.org>.
alopresto edited a comment on pull request #4228:
URL: https://github.com/apache/nifi/pull/4228#issuecomment-662636647
This has been rebased and opened as PR 4421. Closing this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on pull request #4228: NIFI-7122 Introduce new KDFs and encryption metadata attributes to EncryptContent processor
Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4228:
URL: https://github.com/apache/nifi/pull/4228#issuecomment-618632096
There is a compilation error on Java 8 due to the use of `InputStream.readNBytes()` which was introduced in Java 11. I'll resolve this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on pull request #4228: NIFI-7122 Introduce new KDFs and encryption metadata attributes to EncryptContent processor
Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4228:
URL: https://github.com/apache/nifi/pull/4228#issuecomment-662636647
This has been rebased and opened as PR 4221. Closing this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on a change in pull request #4228: NIFI-7122 Introduce new KDFs and encryption metadata attributes to EncryptContent processor
Posted by GitBox <gi...@apache.org>.
alopresto commented on a change in pull request #4228:
URL: https://github.com/apache/nifi/pull/4228#discussion_r414059381
##########
File path: nifi-api/src/main/java/org/apache/nifi/flowfile/FlowFile.java
##########
@@ -108,7 +108,7 @@
*/
Map<String, String> getAttributes();
- public static class KeyValidator {
Review comment:
I agree. This was the IDE being aggressive about code cleanliness because any class defined in an `interface` is `public static` already. I can revert this change to make it explicitly apparent to callers, but there is no functional change here. See https://stackoverflow.com/a/7486111/70465.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on a change in pull request #4228: NIFI-7122 Introduce new KDFs and encryption metadata attributes to EncryptContent processor
Posted by GitBox <gi...@apache.org>.
joewitt commented on a change in pull request #4228:
URL: https://github.com/apache/nifi/pull/4228#discussion_r414035894
##########
File path: nifi-api/src/main/java/org/apache/nifi/flowfile/FlowFile.java
##########
@@ -108,7 +108,7 @@
*/
Map<String, String> getAttributes();
- public static class KeyValidator {
Review comment:
Give that this is in the nifi-api I don't believe this change is ok outside of major nifi release boundary (nifi 2.0). The only way this change would be ok is if having this class public and static was unintentional/a bug and that we are sure someone else should not be reasonably using this. Do you think that is the case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on pull request #4228: NIFI-7122 Introduce new KDFs and encryption metadata attributes to EncryptContent processor
Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4228:
URL: https://github.com/apache/nifi/pull/4228#issuecomment-648404789
@joewitt Any further comments on this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org