You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Vincent Poon (JIRA)" <ji...@apache.org> on 2019/04/17 23:42:00 UTC
[jira] [Comment Edited] (PHOENIX-5213) Phoenix-client improvements:
add more relocations, exclude log binding, add source jar
[ https://issues.apache.org/jira/browse/PHOENIX-5213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817494#comment-16817494 ]
Vincent Poon edited comment on PHOENIX-5213 at 4/17/19 11:41 PM:
-----------------------------------------------------------------
added version to the exec-maven-plugin to get rid of a warning
Also looks like the sources jar had to be on the main classifier
was (Author: vincentpoon):
added version to the exec-maven-plugin to get rid of a warning
> Phoenix-client improvements: add more relocations, exclude log binding, add source jar
> ---------------------------------------------------------------------------------------
>
> Key: PHOENIX-5213
> URL: https://issues.apache.org/jira/browse/PHOENIX-5213
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Vincent Poon
> Assignee: Vincent Poon
> Priority: Major
> Attachments: PHOENIX-5213.4.x-HBase-1.4.v1.patch, PHOENIX-5213.4.x-HBase-1.4.v2.patch, PHOENIX-5213.4.x-HBase-1.4.v3.patch, PHOENIX-5213.4.x-HBase-1.4.v4.patch
>
>
> To make the existing phoenix-client, I'm proposing the following changes:
> 1) Add additional relocations of some packages
> Add a new "embedded" classifier to phoenix-client that does the following:
> 2) Exclude the slf4j-log4j12 binding. Apparently this isn't pulled in directly from phoenix-core itself, but transitively from other projects. It's generally considered best practice to not impose a log binding on downstream projects. The slf4j-log4j12 jar will still be in the phoenix tarball's /lib folder.
> 3) Create a source jar for phoenix-client embedded.
> 4) Create a dependency-reduced pom, so that the client can be used directly in downstream projects without having to exclude transitive artifacts.
> 5) rename the jar to match the final name in the repository: phoenix-client-{version}.jar There is now a symlink phoenix-{version}-client.jar to maintain backwards compatibility.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)