[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4091: [IOTDB-1798]Compatibility of Apache IoTDB with InfluxDB - More function support

[GitBox <gi...@apache.org>]

SteveYurongSu commented on a change in pull request #4091:
URL: https://github.com/apache/iotdb/pull/4091#discussion_r725424079



##########
File path: influxdb-protocol/src/test/java/org/apache/iotdb/influxdb/integration/IoTDBInfluxDBIT.java
##########
@@ -99,4 +109,15 @@ public void testConnectRefusedFailed() {
   public void testConnectAuthFailed() {
     InfluxDB influxDB = IoTDBInfluxDBFactory.connect(host, port, "1", "1");
   }
+
+  @Test
+  public void testVersion() {
+    // TODO docker image version is latest, may not 0.12.2 in the feature
+    assertEquals("0.12.2", influxDB.version());

Review comment:
       ```suggestion
       String version = influxDB.version();
       assertNotNull(version);
       assertTrue(version.length() != 0);
   ```

##########
File path: influxdb-protocol/src/test/java/org/apache/iotdb/influxdb/integration/IoTDBInfluxDBIT.java
##########
@@ -99,4 +109,15 @@ public void testConnectRefusedFailed() {
   public void testConnectAuthFailed() {
     InfluxDB influxDB = IoTDBInfluxDBFactory.connect(host, port, "1", "1");
   }
+
+  @Test
+  public void testVersion() {
+    // TODO docker image version is latest, may not 0.12.2 in the feature
+    assertEquals("0.12.2", influxDB.version());
+  }
+
+  @Test
+  public void testPing() {
+    assertEquals("0.12.2", influxDB.ping().getVersion());

Review comment:
       ```suggestion
       assertTrue(influxDB.ping().getResponseTime() > 0);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org