[GitHub] [netbeans] JaroslavTulach commented on issue #1407: [NETBEANS-1159] Using UPL licensed graal-js-parser.

[GitBox <gi...@apache.org>]

JaroslavTulach commented on issue #1407: [NETBEANS-1159] Using UPL licensed graal-js-parser.
URL: https://github.com/apache/netbeans/pull/1407#issuecomment-518944005
 
 
   Thanks for the detailed review, @matthiasblaesing. The `TypeError: __init__() takes at least 6 arguments (5 given)` problem has something to do with old/new version of `mx`. I have seen it as well before (but not when writing the above steps). The workaround was:
   ```diff
   graal-js$ git diff
   diff --git a/graal-js/mx.graal-js/mx_graal_js.py b/graal-js/mx.graal-js/mx_graal_js.py
   index bb59b035d7..ae60755801 100644
   --- a/graal-js/mx.graal-js/mx_graal_js.py
   +++ b/graal-js/mx.graal-js/mx_graal_js.py
   @@ -331,12 +331,6 @@ mx_sdk.register_graalvm_component(mx_sdk.GraalVmLanguage(
            'graal-js:ICU4J-DIST'
        ],
        launcher_configs=[
   -        mx_sdk.LanguageLauncherConfig(
   -            destination='bin/<exe:js>',
   -            jar_distributions=['graal-js:GRAALJS_LAUNCHER'],
   -            main_class='com.oracle.truffle.js.shell.JSLauncher',
   -            build_args=['--language:js']
   -        )
        ],
        boot_jars=['graal-js:GRAALJS_SCRIPTENGINE']
    ))
   ``` 
   
   Thanks for the license check. Yes, the `graal-js/src/com.oracle.js.parser/src/com/oracle/js/parser/package-info.java` and `graal-js/src/com.oracle.js.parser/src/com/oracle/js/parser/resources/Messages.properties` are an oversight that I will fix. The other files are unrelated and I'd rather leave them without any modification. They aren't used in the parser anyway. When I run:
   ```
   graaljs/graal-js$ mx clean
   graaljs/graal-js$ mx -v build --project GRAAL_JS_PARSER
   javac -g -d mxbuild/src/com.oracle.js.parser/bin -classpath  
   -parameters -proc:none -target 1.8 -source 1.8 
   @mxbuild/src/com.oracle.js.parser/javafilelist.txt 
   -Xlint:none -XDignore.symbol.file -encoding UTF-8 -Xmaxerrs 10000
   ```
   e.g. it should be enough to run just the `javac` and then package the source and resource files somehow:
   ```
   $ /jdk1.8.0/bin/javac -g -d mxbuild/src/com.oracle.js.parser/bin 
   -classpath  -parameters -proc:none -target 1.8 -source 1.8 
   @mxbuild/src/com.oracle.js.parser/javafilelist.txt 
   -Xlint:none -XDignore.symbol.file -encoding UTF-8 -Xmaxerrs 10000
   ```
   The `javafilelist.txt` contains only files under the `src/com.oracle.js.parser/src` directory, so licenses of other files shall not matter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists