[jira] [Commented] (TEZ-1384) Move recovery related code into inner class

["Jeff Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088625#comment-14088625 ] 

Jeff Zhang commented on TEZ-1384:
---------------------------------

Attach the patch. 

*  This patch move the logHistoryEvent, restoreFromHistoryEvent and RecoverTransition into one inner class. Maybe in the future I could extract common interface/abstract class, but considering this is a large patch, just keep it simple.
*  Manually test recover function, it still works.  But consider this is a large patch, maybe we could wait [Tez-850|https://issues.apache.org/jira/browse/TEZ-850] to complete, then commit this patch. 

> Move recovery related code into inner class
> -------------------------------------------
>
>                 Key: TEZ-1384
>                 URL: https://issues.apache.org/jira/browse/TEZ-1384
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: Tez-1384.patch
>
>
> Currently each entity (DAG, Vertex, Task, TaskAttempt) has some common recovery code like log history event and restore from history event. These are 2 opposite aspects of recovery. One for store status while the other is for restore status. This jira is for putting these pieces of code together ( in an inner class ). In this way, it is easy to maintain and cut down the possibility that one field is not stored or restored.  



--
This message was sent by Atlassian JIRA
(v6.2#6252)