You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/01 14:23:11 UTC
[GitHub] [superset] comdiv opened a new pull request, #20588: (pivot_table_v2) fix #20564
comdiv opened a new pull request, #20588:
URL: https://github.com/apache/superset/pull/20588
### SUMMARY
Fix and improve `value_a_z`, `value_z_a` sort order for pivot table
1. work on any size of cols and rows in pivot table options, groups them
2. keep subtotals with their groups
3. keep subtotals on required top/bottom position
4. switches to a-z order in case of same numerical values
### TESTING INSTRUCTIONS
Create any pivot v2 table with
1. at least two rows (or/and to cols) and summable metric
5. switch on subtotals
6. try switch different orderings (all row/col groups should be consistent)
7. try switch subtotal position (all row/col groups should be consistent and subtotals should be at expected place)
### ADDITIONAL INFORMATION
Known issue - not tested for non monotonic summable aggregates with natural order (sum, count, avg).
It's because it collect raw subtotals sumarrizing internal values.
Some aggregate function (min, max for) could have unexpected behavior in sorting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "Kamkoz93 (via GitHub)" <gi...@apache.org>.
Kamkoz93 commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-3338932461
I would like to revive this topic since this fix is crucial for making any use of pivot table. Could anybody help me to make this PR into the codebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] comdiv commented on pull request #20588: fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering
Posted by GitBox <gi...@apache.org>.
comdiv commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-1173336080
As in previous version you should sum whole row, not just 'Abigail' because 'value order' means 'row value order'. Because you cannot express that Abigail column should be sorted while Alicia not. Sum of values used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #20588: (pivot_table_v2) fix #20564
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-1173259400
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #20588: fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering
URL: https://github.com/apache/superset/pull/20588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-2156123881
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-2156460296
@comdiv Would you mind rebasing your PR on the latest master? Maybe that will unblock the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-2844090392
@sadpandajoe the test envs aren't working here. Any interest in pulling/testing this locally, if you have bandwidth?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20588: (pivot_table_v2) fix #20564
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-1173262265
@zhaoyongjie Container image not yet published for this PR. Please try again when build is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-1922562464
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/20588?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `43 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`8d4994a`)](https://app.codecov.io/gh/apache/superset/commit/8d4994a89900c2cf636444e4febad61ce3b69d68?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 66.85% compared to head [(`e9d84df`)](https://app.codecov.io/gh/apache/superset/pull/20588?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 68.63%.
> Report is 2728 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/superset/pull/20588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hart-pivot-table/src/react-pivottable/utilities.js](https://app.codecov.io/gh/apache/superset/pull/20588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGl2b3QtdGFibGUvc3JjL3JlYWN0LXBpdm90dGFibGUvdXRpbGl0aWVzLmpz) | 0.00% | [43 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/20588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #20588 +/- ##
==========================================
+ Coverage 66.85% 68.63% +1.77%
==========================================
Files 1753 1854 +101
Lines 65825 70163 +4338
Branches 7006 8263 +1257
==========================================
+ Hits 44010 48159 +4149
+ Misses 20030 19955 -75
- Partials 1785 2049 +264
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/20588/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/20588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.87% <0.00%> (+4.91%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/20588?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-1934821399
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-4071025586
Last commit was over a year ago. I'm going to put this in draft. Anyone can feel free to take this over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-2159103028
There are a bunch of CI tasks not running. Let's kick-start it by closing/reopening and see if that gets us through the full list. Then hopefully the ephemeral will work ¯\_(ツ)_/¯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-2844088435
@rusackas Processing your ephemeral environment request [here](https://github.com/apache/superset/actions/runs/14769850620). Action: **up**. More information on [how to use or configure ephemeral environments](https://superset.apache.org/docs/contributing/howtos/#github-ephemeral-environments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-4702279281
This has sat since 2022 and the original author's gone quiet despite a few folks asking to revive it. Closing as inactive - if anyone wants to carry it forward, a fresh PR off current master (with tests) is the cleanest path. Happy to review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-2844058606
Rebooting CI once more. Hopefully we can (finally) test and merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-1922513037
closing/reopening to see if this'll pass CI. It also still needs a review, of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20588: (pivot_table_v2) fix #20564
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-1173262278
@zhaoyongjie Ephemeral environment creation failed. Please check the Actions logs for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #20588: fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-1173279895
@comdiv Thanks for the fixing. It can not work when I populate a column and select `value asc` by rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "SBIN2010 (via GitHub)" <gi...@apache.org>.
SBIN2010 commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-3825740808
Hi @comdiv !
Please let me know if you would like to continue. This PR is required for rebasing to master.
And I would break the groupingValueSort function into smaller functions for better code readability and add tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #20588: fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering
URL: https://github.com/apache/superset/pull/20588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-2156482033
Also, for the sake of completeness, could you add before/after screenshots or recordings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-2145891773
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #20588: fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering
URL: https://github.com/apache/superset/pull/20588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-1922867816
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #20588:
URL: https://github.com/apache/superset/pull/20588#issuecomment-2844094212
...or @kgabryje for that matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #20588: fix(pivot_table_v2): Pivot table cannot validly group rows and keep ordering
URL: https://github.com/apache/superset/pull/20588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org