You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/05 16:18:56 UTC
[GitHub] [airflow] pdebelak opened a new pull request, #25556: Cache the custom secrets backend so the same instance gets re-used
pdebelak opened a new pull request, #25556:
URL: https://github.com/apache/airflow/pull/25556
closes: #25555
This uses `functools.lru_cache` to re-use the same secrets backend instance between the `conf` global when it loads configuration from secrets and uses outside the `configuration` module like variables and connections. Previously, each fetch of a configuration value from secrets would use its own secrets backend instance.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #25556: Cache the custom secrets backend so the same instance gets re-used
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #25556: Cache the custom secrets backend so the same instance gets re-used
URL: https://github.com/apache/airflow/pull/25556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25556: Cache the custom secrets backend so the same instance gets re-used
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25556:
URL: https://github.com/apache/airflow/pull/25556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25556: Cache the custom secrets backend so the same instance gets re-used
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25556:
URL: https://github.com/apache/airflow/pull/25556#issuecomment-1207223254
Nice. Thanks for being persistent!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25556: Cache the custom secrets backend so the same instance gets re-used
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25556:
URL: https://github.com/apache/airflow/pull/25556#issuecomment-1206629360
you misdiagnosed the problem. see comment in #25555 . This will not solve your problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25556: Cache the custom secrets backend so the same instance gets re-used
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25556:
URL: https://github.com/apache/airflow/pull/25556#issuecomment-1207198649
OK. Let's see. You convinced me - but you have to fix tests failing (there were some) and it woudl be great to add unit test covering it showing that there is one instance after (and likely failing before the change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pdebelak commented on pull request #25556: Cache the custom secrets backend so the same instance gets re-used
Posted by GitBox <gi...@apache.org>.
pdebelak commented on PR #25556:
URL: https://github.com/apache/airflow/pull/25556#issuecomment-1207225740
👍 I appreciate you digging into this with me. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org