[GitHub] [beam] benWize commented on a change in pull request #16037: [BEAM-11936] Fix errorprone UnusedVariable in core,examples,harness..

[GitBox <gi...@apache.org>]

benWize commented on a change in pull request #16037:
URL: https://github.com/apache/beam/pull/16037#discussion_r763166826



##########
File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/FinalizeBundleHandler.java
##########
@@ -65,45 +59,13 @@ public static CallbackRegistration create(
     public abstract BundleFinalizer.Callback getCallback();
   }
 
-  private static final Logger LOG = LoggerFactory.getLogger(FinalizeBundleHandler.class);
   private final ConcurrentMap<String, Collection<CallbackRegistration>> bundleFinalizationCallbacks;
   private final PriorityQueue<TimestampedValue<String>> cleanUpQueue;
-  private final Future<Void> cleanUpResult;
 
-  public FinalizeBundleHandler(ExecutorService executorService) {
+  public FinalizeBundleHandler() {
     this.bundleFinalizationCallbacks = new ConcurrentHashMap<>();
     this.cleanUpQueue =
         new PriorityQueue<>(11, Comparator.comparing(TimestampedValue::getTimestamp));
-    this.cleanUpResult =

Review comment:
       I'm not sure about this, Is there a way we can test this? Or maybe we can suppress this warning to avoid unexpected side effects. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org