You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/11/07 11:13:07 UTC
[GitHub] incubator-brooklyn pull request: Fix Live-sanity tests
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/308
Fix Live-sanity tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/LiveSanity-20141106
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/308.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #308
----
commit 6e1ec7260328342925fd565b05ec9980c8835ee8
Author: Aled Sage <al...@gmail.com>
Date: 2014-11-06T13:38:00Z
EC2 CentOS 6.3 test: openIptables=true
- The AMI has iptables locked down; need to open iptables for the
jclouds “open ports”. Otherwise things like JBoss7 live test fails.
commit 6416575da12c739052c473ef29077d93edc17b39
Author: Aled Sage <al...@gmail.com>
Date: 2014-11-06T13:38:38Z
Fix NodeJs live tests: don’t assert REQUEST_COUNT
- attributes like REQUEST_COUNT are not set for NodeJs, so don’t
assert that they are non-null
commit 69e2f86501a5b4b9397d4aa5db96e89abfada40b
Author: Aled Sage <al...@gmail.com>
Date: 2014-11-06T13:41:13Z
TaskFinalizer: add TODO about logging
commit 48c7b447a5cf9d29527289a5c2e6f40821fb7196
Author: Aled Sage <al...@gmail.com>
Date: 2014-11-07T08:19:53Z
entity.getAllAttributes() return everything
- Even if the AttributeSensor is unknown for a given key name, still
return it.
- There’s a race where persister thread calls getAllAttributes() at
same time as new attribute type is being added to entityType.
Previously the sensor was not returned, so was not persisted.
commit 64d927e44a0ff5d826bce6643c1175c0474976c9
Author: Aled Sage <al...@gmail.com>
Date: 2014-11-07T08:24:19Z
RebindTestFixture: support for dumping mementoDir
- Create a mementoDirBackup field, in case wants to be used by
sub-classes.
- Adds dumpMementoDir(File dir)
commit 6bf49b3914b5e508301a0b921a284f167fc037aa
Author: Aled Sage <al...@gmail.com>
Date: 2014-11-07T08:24:33Z
More logging for failing BindDnsServerIntegrationTest
- Fails non-deterministically on jenkins; can’t reproduce locally.
Therefore adding logging to dump out a copy of the persistence dir,
as it was at the point of rebind.
- Also terminates the old management context.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix Live-sanity tests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/308
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix Live-sanity tests
Posted by alasdairhodge <gi...@git.apache.org>.
Github user alasdairhodge commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/308#discussion_r20072045
--- Diff: core/src/test/java/brooklyn/entity/rebind/RebindTestFixture.java ---
@@ -114,9 +127,36 @@ public void tearDown() throws Exception {
if (origManagementContext != null) Entities.destroyAll(origManagementContext);
if (mementoDir != null) FileBasedObjectStore.deleteCompletely(mementoDir);
+ if (mementoDirBackup != null) FileBasedObjectStore.deleteCompletely(mementoDir);
origManagementContext = null;
}
+ protected void dumpMementoDir(File dir) {
--- End diff --
Could use a brief javadoc comment, particularly describing what gets created at the target dir.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix Live-sanity tests
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/308#issuecomment-62203332
@alasdairhodge did you get a chance to review this - any comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix Live-sanity tests
Posted by alasdairhodge <gi...@git.apache.org>.
Github user alasdairhodge commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/308#issuecomment-62358848
Only suggestion is javadoc, otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix Live-sanity tests
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/308#issuecomment-62371643
Thanks @alasdairhodge - I've added the javadoc and rebased. Will merge now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---