You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/16 09:45:03 UTC

[GitHub] [arrow] thisisnic commented on a change in pull request #10519: ARROW-12867: [R] Bindings for abs()

thisisnic commented on a change in pull request #10519:
URL: https://github.com/apache/arrow/pull/10519#discussion_r652529386



##########
File path: r/tests/testthat/test-dplyr-arrange.R
##########
@@ -139,18 +139,14 @@ test_that("arrange() on integer, double, and character columns", {
       collect(),
     tbl
   )
-  expect_warning(
-    expect_equal(
-      tbl %>%
-        Table$create() %>%
-        arrange(abs(int), dbl) %>%
-        collect(),
-      tbl %>%
-        arrange(abs(int), dbl) %>%
-        collect()
-    ),
-    "not supported in Arrow",
-    fixed = TRUE
+  expect_equal(

Review comment:
       I was thinking about this myself, and am wondering if that could be achieved via a user-defined function called something ridiculous like `not_a_function` or similar? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org