You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/01/17 03:17:59 UTC
[GitHub] carbondata pull request #1816: [CARBONDATA-2038][Tests] use junit assertion ...
GitHub user xuchuanyin opened a pull request:
https://github.com/apache/carbondata/pull/1816
[CARBONDATA-2038][Tests] use junit assertion in java tests
Java native assertion is affected by JVM parameter `-ea/-da`. It only
works with `-ea` specified. So we should replace it with Junit assertion
which always behaves the same.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x] Any interfaces changed?
`NO`
- [x] Any backward compatibility impacted?
`NO`
- [x] Document update required?
`NO`
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
`NO, only fix bugs in tests`
- How it is tested? Please attach test report.
`Tested in local node`
- Is it a performance related change? Please attach the performance test report.
`NO, only fix bugs in tests`
- Any additional information to help reviewers in testing this change.
`NO`
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
`Not related`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xuchuanyin/carbondata 0117_use_junit_assert
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1816.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1816
----
commit bfd33a1070f2ec8d5b2b3f403a4d04cbefc1c854
Author: xuchuanyin <xu...@...>
Date: 2018-01-17T02:54:11Z
use junit assertion in java tests
Java native assertion is affected by JVM parameter `-ea/-da`. It only
works with `-ea` specified. So we should replace it with Junit assertion
which always behaves the same.
----
---
[GitHub] carbondata issue #1816: [CARBONDATA-2038][Tests] use junit assertion in java...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1816
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1634/
---
[GitHub] carbondata issue #1816: [CARBONDATA-2038][Tests] use junit assertion in java...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1816
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2867/
---
[GitHub] carbondata pull request #1816: [CARBONDATA-2038][Tests] use junit assertion ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1816
---
[GitHub] carbondata issue #1816: [CARBONDATA-2038][Tests] use junit assertion in java...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1816
retest this please
---
[GitHub] carbondata issue #1816: [CARBONDATA-2038][Tests] use junit assertion in java...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1816
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2957/
---
[GitHub] carbondata issue #1816: [CARBONDATA-2038][Tests] use junit assertion in java...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1816
LGTM
---
[GitHub] carbondata issue #1816: [CARBONDATA-2038][Tests] use junit assertion in java...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1816
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1636/
---
[GitHub] carbondata issue #1816: [CARBONDATA-2038][Tests] use junit assertion in java...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1816
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1694/
---
[GitHub] carbondata issue #1816: [CARBONDATA-2038][Tests] use junit assertion in java...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1816
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2869/
---
[GitHub] carbondata issue #1816: [CARBONDATA-2038][Tests] use junit assertion in java...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1816
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1649/
---
[GitHub] carbondata issue #1816: [CARBONDATA-2038][Tests] use junit assertion in java...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1816
retest this please
---
[GitHub] carbondata issue #1816: [CARBONDATA-2038][Tests] use junit assertion in java...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1816
retest this please
---
[GitHub] carbondata issue #1816: [CARBONDATA-2038][Tests] use junit assertion in java...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1816
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2927/
---
[GitHub] carbondata issue #1816: [CARBONDATA-2038][Tests] use junit assertion in java...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1816
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2881/
---