You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by agura <gi...@git.apache.org> on 2017/03/06 18:19:52 UTC

[GitHub] zeppelin pull request #2101: ZEPPELIN-2219 Apache Ignite version updated to ...

GitHub user agura opened a pull request:

    https://github.com/apache/zeppelin/pull/2101

    ZEPPELIN-2219 Apache Ignite version updated to 1.9

    ### What is this PR for?
    Apache Ignite version update to 1.9 in Ignite interpreter
    
    ### What type of PR is it?
    [Improvement]
    
    ### What is the Jira issue?
    ZEPPELIN-2219


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agura/incubator-zeppelin ZEPPELIN-2219

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2101
    
----
commit 7f053d7dfb75826e67a69aee7afe5a855aa729c0
Author: agura <ag...@apache.org>
Date:   2017-03-06T18:15:37Z

    ZEPPELIN-2219 Apache Ignite version updated to 1.9

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2101: ZEPPELIN-2219 Apache Ignite version updated to 1.9

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2101
  
    Yeah makes sense. LGTM \U0001f44d 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2101: ZEPPELIN-2219 Apache Ignite version updated to 1.9

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2101
  
    Merge into master and branch-0.7 if there are no more comments 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2101: ZEPPELIN-2219 Apache Ignite version updated to 1.9

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2101
  
    @agura Thanks always for taking care of up-to-date ignite. Can you set up your own travis as described in [here](https://zeppelin.apache.org/contribution/contributions.html#continuous-integration)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2101: ZEPPELIN-2219 Apache Ignite version updated to 1.9

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2101
  
    @agura Yes I know it's not related with this PR's CI status, but I thought it's good to do for anyone who is contributing to Zeppelin :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2101: ZEPPELIN-2219 Apache Ignite version updated to 1.9

Posted by agura <gi...@git.apache.org>.
Github user agura commented on the issue:

    https://github.com/apache/zeppelin/pull/2101
  
    Thanks a lot!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2101: ZEPPELIN-2219 Apache Ignite version updated to 1.9

Posted by agura <gi...@git.apache.org>.
Github user agura commented on the issue:

    https://github.com/apache/zeppelin/pull/2101
  
    @AhyoungRyu Thanks for quick answer. Yes, I can. But IMO it doesn't make sense. There are only two tests related with Ignite interpreter and this tests are finished successfully. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2101: ZEPPELIN-2219 Apache Ignite version updated to 1.9

Posted by agura <gi...@git.apache.org>.
Github user agura commented on the issue:

    https://github.com/apache/zeppelin/pull/2101
  
    It seems that build failure isn't related with my changes. Could somebody look at this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2101: ZEPPELIN-2219 Apache Ignite version updated to ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2101


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2101: ZEPPELIN-2219 Apache Ignite version updated to 1.9

Posted by agura <gi...@git.apache.org>.
Github user agura commented on the issue:

    https://github.com/apache/zeppelin/pull/2101
  
    Could somebody merge it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2101: ZEPPELIN-2219 Apache Ignite version updated to 1.9

Posted by agura <gi...@git.apache.org>.
Github user agura commented on the issue:

    https://github.com/apache/zeppelin/pull/2101
  
    @AhyoungRyu :) I agree wih you. But I sure that GUI tests don't make sense for this change because interpreter implementation isn't changed, interface between interpreter and front-end is still the same and unit tests show that returned data set is the same. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---