You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Frank David Martinez (Created) (JIRA)" <ji...@apache.org> on 2012/04/17 16:44:16 UTC
[jira] [Created] (DIGESTER-164) RulesBase performance optimization
RulesBase performance optimization
----------------------------------
Key: DIGESTER-164
URL: https://issues.apache.org/jira/browse/DIGESTER-164
Project: Commons Digester
Issue Type: Improvement
Affects Versions: 3.2
Reporter: Frank David Martinez
Priority: Minor
Attachments: rulesbase.patch
RulesBase iterates over all patterns looking for the longest key. It could be optimized with a separate cache of wildcards.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DIGESTER-164) RulesBase performance optimization
Posted by "Simone Tripodi (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simone Tripodi resolved DIGESTER-164.
-------------------------------------
Resolution: Fixed
Fix Version/s: 3.3
Assignee: Simone Tripodi
Patch applied at [r1328103|http://svn.apache.org/viewvc?rev=1328103&view=rev], thanks for contributing Frank!
> RulesBase performance optimization
> ----------------------------------
>
> Key: DIGESTER-164
> URL: https://issues.apache.org/jira/browse/DIGESTER-164
> Project: Commons Digester
> Issue Type: Improvement
> Affects Versions: 3.2
> Reporter: Frank David Martinez
> Assignee: Simone Tripodi
> Priority: Minor
> Labels: patch
> Fix For: 3.3
>
> Attachments: rulesbase.patch, rulesbase2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> RulesBase iterates over all patterns looking for the longest key. It could be optimized with a separate cache of wildcards.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIGESTER-164) RulesBase performance optimization
Posted by "Frank David Martinez (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank David Martinez updated DIGESTER-164:
------------------------------------------
Attachment: rulesbase.patch
Copy wildcard patterns to its own cache, so it will be a smaller collection to iterate when search for a longest key.
> RulesBase performance optimization
> ----------------------------------
>
> Key: DIGESTER-164
> URL: https://issues.apache.org/jira/browse/DIGESTER-164
> Project: Commons Digester
> Issue Type: Improvement
> Affects Versions: 3.2
> Reporter: Frank David Martinez
> Priority: Minor
> Labels: patch
> Attachments: rulesbase.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> RulesBase iterates over all patterns looking for the longest key. It could be optimized with a separate cache of wildcards.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIGESTER-164) RulesBase performance
optimization
Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256427#comment-13256427 ]
Simone Tripodi commented on DIGESTER-164:
-----------------------------------------
It is not clear to me how {{Wildcard.rules}} is useful since it won't be read after the Wildcard is created.
Can you please explain me that, please?
TIA and all the best
> RulesBase performance optimization
> ----------------------------------
>
> Key: DIGESTER-164
> URL: https://issues.apache.org/jira/browse/DIGESTER-164
> Project: Commons Digester
> Issue Type: Improvement
> Affects Versions: 3.2
> Reporter: Frank David Martinez
> Priority: Minor
> Labels: patch
> Attachments: rulesbase.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> RulesBase iterates over all patterns looking for the longest key. It could be optimized with a separate cache of wildcards.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DIGESTER-164) RulesBase performance optimization
Posted by "Frank David Martinez (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank David Martinez updated DIGESTER-164:
------------------------------------------
Attachment: rulesbase2.patch
Removed Wildcard class and use simple String pattern.
> RulesBase performance optimization
> ----------------------------------
>
> Key: DIGESTER-164
> URL: https://issues.apache.org/jira/browse/DIGESTER-164
> Project: Commons Digester
> Issue Type: Improvement
> Affects Versions: 3.2
> Reporter: Frank David Martinez
> Priority: Minor
> Labels: patch
> Attachments: rulesbase.patch, rulesbase2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> RulesBase iterates over all patterns looking for the longest key. It could be optimized with a separate cache of wildcards.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIGESTER-164) RulesBase performance
optimization
Posted by "Frank David Martinez (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256525#comment-13256525 ]
Frank David Martinez commented on DIGESTER-164:
-----------------------------------------------
Hi Simo,
You are right, Wildcard class is useless, I started with one idea but changed on the way...
I attached a new pacth. Much more smaller. And i have fixed a bug introduced with the previous patch too.
> RulesBase performance optimization
> ----------------------------------
>
> Key: DIGESTER-164
> URL: https://issues.apache.org/jira/browse/DIGESTER-164
> Project: Commons Digester
> Issue Type: Improvement
> Affects Versions: 3.2
> Reporter: Frank David Martinez
> Priority: Minor
> Labels: patch
> Attachments: rulesbase.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> RulesBase iterates over all patterns looking for the longest key. It could be optimized with a separate cache of wildcards.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DIGESTER-164) RulesBase performance
optimization
Posted by "Simone Tripodi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIGESTER-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256415#comment-13256415 ]
Simone Tripodi commented on DIGESTER-164:
-----------------------------------------
Hola Frank,
thanks a lot, looks good, I am going to test it.
PS for future patches, can you please mind the original code format? TIA!
> RulesBase performance optimization
> ----------------------------------
>
> Key: DIGESTER-164
> URL: https://issues.apache.org/jira/browse/DIGESTER-164
> Project: Commons Digester
> Issue Type: Improvement
> Affects Versions: 3.2
> Reporter: Frank David Martinez
> Priority: Minor
> Labels: patch
> Attachments: rulesbase.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> RulesBase iterates over all patterns looking for the longest key. It could be optimized with a separate cache of wildcards.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira