[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5014: fixing converting PinotQuery to BrokerRequest for group by clause with selections

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #5014: fixing converting PinotQuery to BrokerRequest for group by clause with selections
URL: https://github.com/apache/incubator-pinot/pull/5014#discussion_r370769811
 
 

 ##########
 File path: pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java
 ##########
 @@ -832,4 +849,17 @@ public void testSqlDistinctQueryCompilation() {
     Assert.assertEquals(aggregationInfo.getAggregationParams().get(FunctionCallAstNode.COLUMN_KEY_IN_AGGREGATION_INFO),
         "add(div(col1,col2),mul(col3,col4)):sub(col3,col4):col5:col6");
   }
+
+  @Test
+  public void testQueryValidationFailure() {
+    String sql;
+    try {
+      sql = "select group_city,group_country, sum(rsvp_count), count(*) from meetupRsvp group by group_country, sum(rsvp_count), count(*) limit 50";
 
 Review comment:
   I agree that we should be checking for identifiers. However, I don't think a query like this:
   SELECT State, Count(*) from Customers GROUP BY State, Count(*) should be supported.
   In other words, we should not have the aggregations as one of the GROUP BY columns.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org