You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/28 12:00:01 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #988: examples/pca9635: remote read mode from driver open call

xiaoxiang781216 commented on a change in pull request #988:
URL: https://github.com/apache/incubator-nuttx-apps/pull/988#discussion_r794443854



##########
File path: examples/pca9635/pca9635_main.c
##########
@@ -59,7 +59,7 @@ int main(int argc, FAR char *argv[])
   int fd;
   int ret;
 
-  fd = open(CONFIG_EXAMPLES_PCA9635_DEVNAME, O_RDONLY);
+  fd = open(CONFIG_EXAMPLES_PCA9635_DEVNAME, 0);

Review comment:
       Should we change O_RDONLY to O_WRONLY? PWMIOC_SETLED_BRIGHTNESS need the write permission.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org