You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "jeanouii (via GitHub)" <gi...@apache.org> on 2026/01/26 10:00:56 UTC

[PR] Fix race condition in AMQ4889Test [activemq]

jeanouii opened a new pull request, #1630:
URL: https://github.com/apache/activemq/pull/1630

   by ensuring proper connection handling and verification of successful and failed connections


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] Fix race condition in AMQ4889Test [activemq]

Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #1630:
URL: https://github.com/apache/activemq/pull/1630#issuecomment-3800555446

   I don't think there is @cshannon when there is an associated bug I always create a JIRA, but not always for every single test I fix. There is only one in this PR, I can start creating JIRA issues for all tests I fix from now on. 
   Totally fine with me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQ-9845 Fix race condition in AMQ4889Test [activemq]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #1630:
URL: https://github.com/apache/activemq/pull/1630


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQ-9845 Fix race condition in AMQ4889Test [activemq]

Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #1630:
URL: https://github.com/apache/activemq/pull/1630#issuecomment-3813522456

   @jbonofre Should be done and running again
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQ-9845 Fix race condition in AMQ4889Test [activemq]

Posted by "jeanouii (via GitHub)" <gi...@apache.org>.
jeanouii commented on PR #1630:
URL: https://github.com/apache/activemq/pull/1630#issuecomment-3810686694

   Failed because of 
   
   ```
   [INFO] Results:
   [INFO] 
   Error:  Errors: 
   Error:    AdvisoryBrokerTest>CombinationTestSupport.runBare:107->testConsumerAdvisoriesReplayed:175 ClassCast class org.apache.activemq.command.ConsumerInfo cannot be cast to class org.apache.activemq.command.RemoveInfo (org.apache.activemq.command.ConsumerInfo and org.apache.activemq.command.RemoveInfo are in unnamed module of loader 'app')
   Error:    VirtualTopicsAndDurableSubsTest>CombinationTestSupport.runBare:113->CombinationTestSupport.runBare:107->MBeanTest.testQueuePauseResume:1823 ยป ConnectionFailed The JMS connection has failed: Estimated allocated buffer size of 308 bytes is larger than frame size of 154 bytes
   [INFO] 
   Error:  Tests run: 1506, Failures: 0, Errors: 2, Skipped: 153
   ```
   
   The flaky tests have been addressed in PR #1634 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] AMQ-9845 Fix race condition in AMQ4889Test [activemq]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1630:
URL: https://github.com/apache/activemq/pull/1630#issuecomment-3813168442

   @jeanouii mind to rebase ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact